From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74231C56201 for ; Wed, 21 Oct 2020 16:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B4AC223C7 for ; Wed, 21 Oct 2020 16:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KrcsCvPH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503291AbgJUQ7L (ORCPT ); Wed, 21 Oct 2020 12:59:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503290AbgJUQ7K (ORCPT ); Wed, 21 Oct 2020 12:59:10 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69187C0613CE; Wed, 21 Oct 2020 09:59:10 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id d3so3362566wma.4; Wed, 21 Oct 2020 09:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZOAwZaaZ/beDzvPjh4DfLLmuqS+BF1EdS0841cgpzLs=; b=KrcsCvPHQglJCf7oeEF5m7FV7XdFHt9x7F3gW8Rhm9Z1S0QRti2sdPhJRUd8nmCeIQ 3nz8sdNk6BgUkY8f1F5JlMV1K0uL8nFfwxgu05ZF+h8mNRaCen+I8fHu2qwMEhXuoHxQ JTFVDgrFTd80wy7wECZ8QX6wcnuGl9kt13IUQGXxcIPJSeOsOY5kwp/AW1iyvLdjBvlE jfDbRMYRgpFMEECXiY7u070ca2FPFZbUC3+HpA7VTRRHbRF3eJzCfaBym6LyQzle5fXa WaSBCbwTh+MoUYuuOsfK7FkiK03/r7t6PaZbFWgBBPbVE14yW1uU1GbLQtr2syg0vJUc CNHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZOAwZaaZ/beDzvPjh4DfLLmuqS+BF1EdS0841cgpzLs=; b=iB2R1K7JXYlyT2k9TSrEiHIWv31cg2SFk9Fplt7alzw4/P8ChSTbzQA75brvk9ErSn PnOv6TtX5z4NhY93SfeEYo55a7ly55Ls4HVQV0xW1ZG2goEVnOZv15sllXJ4g7vo6/QL C9XNBTN0hXzjFiKPlMSI6RC4UdMEr4juLhAw2/Gq2aL1Q25KFULuWXIHmVtPYRAQMcn5 7q0dPJ2mhcI9lcnG8uKa/9JrC4nfEx9v+t3Xg1S71F+cVWuL9DLzUQMGTG5yGEQ1Oi64 0PjFlVI3ST5Sw5uYphgkLBHf0L4oXXX1By3SzF8Yya+niz8OBtjnLyCumzvkWRnUezGk 2Rpw== X-Gm-Message-State: AOAM530AO6RkDHjpSdp4iBjwlqTp6kM/Umw0TprW4tM0qn/Dvie65xdK Kq1FqsO+IzgUTzneUiPxHMLCtrW9bYcNrqtoa0Y= X-Google-Smtp-Source: ABdhPJwu3PAB+EK3ul320vHDvWKoXxQTAQwJyBX44XCUJZtWcWL6PCNBwIxZExqEpwyJy/GoRVJba0GldZXaq6LR/GQ= X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr4787948wmm.49.1603299549106; Wed, 21 Oct 2020 09:59:09 -0700 (PDT) MIME-Version: 1.0 References: <6e4110032f8711e8bb0acbeccfe66dec3b09d5c1.1598594714.git.viresh.kumar@linaro.org> <20201005062633.ejpehkpeuwksrx3e@vireshk-i7> <20201021072404.y43tjzd2ehclrejp@vireshk-i7> In-Reply-To: <20201021072404.y43tjzd2ehclrejp@vireshk-i7> From: Rob Clark Date: Wed, 21 Oct 2020 09:58:57 -0700 Message-ID: Subject: Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table() To: Viresh Kumar Cc: Rajendra Nayak , Sean Paul , Linux PM , Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Douglas Anderson , Naresh Kamboju , linux-arm-msm , dri-devel , freedreno , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Oct 21, 2020 at 12:24 AM Viresh Kumar wrote: > > On 05-10-20, 11:56, Viresh Kumar wrote: > > On 28-08-20, 11:37, Viresh Kumar wrote: > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > the device). And we can call dev_pm_opp_of_remove_table() > > > unconditionally here. > > > > > > While at it, also create a label to put clkname. > > > > > > Signed-off-by: Viresh Kumar > > > > Can someone please apply this and the other drm patch (2/8) ? > > Rob/Rajendra, can someone please have a look at these patches ? Oh, sorry I missed that, could someone re-send it and CC freedreno@lists.freedesktop.org so it shows up in patchworks.. that is more reliable counting on me to not overlook something in my mail BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BDE6C388F9 for ; Wed, 21 Oct 2020 16:59:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBD03223BF for ; Wed, 21 Oct 2020 16:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KrcsCvPH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBD03223BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0059B6EE1C; Wed, 21 Oct 2020 16:59:11 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CC446EE1C; Wed, 21 Oct 2020 16:59:10 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 13so2887135wmf.0; Wed, 21 Oct 2020 09:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZOAwZaaZ/beDzvPjh4DfLLmuqS+BF1EdS0841cgpzLs=; b=KrcsCvPHQglJCf7oeEF5m7FV7XdFHt9x7F3gW8Rhm9Z1S0QRti2sdPhJRUd8nmCeIQ 3nz8sdNk6BgUkY8f1F5JlMV1K0uL8nFfwxgu05ZF+h8mNRaCen+I8fHu2qwMEhXuoHxQ JTFVDgrFTd80wy7wECZ8QX6wcnuGl9kt13IUQGXxcIPJSeOsOY5kwp/AW1iyvLdjBvlE jfDbRMYRgpFMEECXiY7u070ca2FPFZbUC3+HpA7VTRRHbRF3eJzCfaBym6LyQzle5fXa WaSBCbwTh+MoUYuuOsfK7FkiK03/r7t6PaZbFWgBBPbVE14yW1uU1GbLQtr2syg0vJUc CNHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZOAwZaaZ/beDzvPjh4DfLLmuqS+BF1EdS0841cgpzLs=; b=I+yAPyKqck/xjdbo5N3tvtJA5cgClvIiEawGzj2pv0WNLgt7DJaNyGRIXzikbEyWmZ O7iyAfoT2V3FBH57bEEoFF7LBrC/hplLLFSFwUdzh5zGTeYPkQFjUgUZdx8H/c8NAUDi rapVKDmRx5+GJ50ix6AGhqsTBo3YL6I0GqK46nYIfIopBbEFOTkHyJUlnWEK+DZjf83M Ph2RfPrxY5HiiFLV1g1LTHKeo0br0pMWKGQQGfngrz23H/hq4lh973d0hE7UFw0ozxIe WT7xxHdOyWbZGn8Ik4QrSFd9pdByZgcc5Z9jbKG7KZYdAfPYw8ed1kH0LKp1NbHz5Xha bsSw== X-Gm-Message-State: AOAM53260uJLvkgOSCtlsWmBvxuFktNbmndA946033XZnNSztu451UW+ dhee+CRc7TThY7SkrLhV/uP3TaJSf795ahHF+OE= X-Google-Smtp-Source: ABdhPJwu3PAB+EK3ul320vHDvWKoXxQTAQwJyBX44XCUJZtWcWL6PCNBwIxZExqEpwyJy/GoRVJba0GldZXaq6LR/GQ= X-Received: by 2002:a05:600c:2241:: with SMTP id a1mr4787948wmm.49.1603299549106; Wed, 21 Oct 2020 09:59:09 -0700 (PDT) MIME-Version: 1.0 References: <6e4110032f8711e8bb0acbeccfe66dec3b09d5c1.1598594714.git.viresh.kumar@linaro.org> <20201005062633.ejpehkpeuwksrx3e@vireshk-i7> <20201021072404.y43tjzd2ehclrejp@vireshk-i7> In-Reply-To: <20201021072404.y43tjzd2ehclrejp@vireshk-i7> From: Rob Clark Date: Wed, 21 Oct 2020 09:58:57 -0700 Message-ID: Subject: Re: [PATCH V2 3/8] drm/msm: Unconditionally call dev_pm_opp_of_remove_table() To: Viresh Kumar X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , freedreno , Rajendra Nayak , Linux PM , Stephen Boyd , linux-arm-msm , Naresh Kamboju , Rafael Wysocki , Douglas Anderson , dri-devel , Linux Kernel Mailing List , Vincent Guittot , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 21, 2020 at 12:24 AM Viresh Kumar wrote: > > On 05-10-20, 11:56, Viresh Kumar wrote: > > On 28-08-20, 11:37, Viresh Kumar wrote: > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > the device). And we can call dev_pm_opp_of_remove_table() > > > unconditionally here. > > > > > > While at it, also create a label to put clkname. > > > > > > Signed-off-by: Viresh Kumar > > > > Can someone please apply this and the other drm patch (2/8) ? > > Rob/Rajendra, can someone please have a look at these patches ? Oh, sorry I missed that, could someone re-send it and CC freedreno@lists.freedesktop.org so it shows up in patchworks.. that is more reliable counting on me to not overlook something in my mail BR, -R _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel