From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 01/25] drm/omap: kill firstopen callback Date: Thu, 8 Aug 2013 10:04:22 -0400 Message-ID: References: <1375969295-18929-1-git-send-email-daniel.vetter@ffwll.ch> <1375969295-18929-2-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 922E0E633D for ; Thu, 8 Aug 2013 07:04:23 -0700 (PDT) Received: by mail-ie0-f172.google.com with SMTP id 17so323820iea.3 for ; Thu, 08 Aug 2013 07:04:23 -0700 (PDT) In-Reply-To: <1375969295-18929-2-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 8, 2013 at 9:41 AM, Daniel Vetter wrote: > KMS drivers really shouldn't need to do anything on firstopen, so kill > empty callbacks. > > Signed-off-by: Daniel Vetter Acked-by: Rob Clark > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c > index 2f9e22e..47e64f9 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -524,12 +524,6 @@ static int dev_open(struct drm_device *dev, struct drm_file *file) > return 0; > } > > -static int dev_firstopen(struct drm_device *dev) > -{ > - DBG("firstopen: dev=%p", dev); > - return 0; > -} > - > /** > * lastclose - clean up after all DRM clients have exited > * @dev: DRM device > @@ -609,7 +603,6 @@ static struct drm_driver omap_drm_driver = { > .load = dev_load, > .unload = dev_unload, > .open = dev_open, > - .firstopen = dev_firstopen, > .lastclose = dev_lastclose, > .preclose = dev_preclose, > .postclose = dev_postclose, > -- > 1.8.3.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel