From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32_t. Date: Wed, 4 Jun 2014 20:05:46 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Matwey V. Kornilov" Cc: linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , Bryan Huntsman , matwey.kornilov@gmail.com, Daniel Walker , David Brown List-Id: linux-arm-msm@vger.kernel.org On Wed, Jun 4, 2014 at 6:54 AM, Matwey V. Kornilov wrote: > From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 > From: "Matwey V. Kornilov" > Date: Mon, 2 Jun 2014 20:17:29 +0400 > Subject: [PATCH] Replace type of paddr to uint32_t. > > This patch helps to avoid the following build issue: > > drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of > 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] > msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); > ^ > In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: > drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but > argument is of type 'dma_addr_t *' > int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, > ^ > > Signed-off-by: Matwey V. Kornilov Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c > b/drivers/gpu/drm/msm/msm_fbdev.c > index a752ab8..5107fc4 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -59,7 +59,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, > struct drm_framebuffer *fb = NULL; > struct fb_info *fbi = NULL; > struct drm_mode_fb_cmd2 mode_cmd = {0}; > - dma_addr_t paddr; > + uint32_t paddr; > int ret, size; > > sizes->surface_bpp = 32; > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755813AbaFEAFt (ORCPT ); Wed, 4 Jun 2014 20:05:49 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:44788 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755797AbaFEAFs (ORCPT ); Wed, 4 Jun 2014 20:05:48 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 4 Jun 2014 20:05:46 -0400 Message-ID: Subject: Re: [PATCH] gpu: drm: msm: Replace type of paddr to uint32_t. From: Rob Clark To: "Matwey V. Kornilov" Cc: David Brown , Daniel Walker , Bryan Huntsman , David Airlie , linux-arm-msm@vger.kernel.org, "dri-devel@lists.freedesktop.org" , matwey.kornilov@gmail.com, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 4, 2014 at 6:54 AM, Matwey V. Kornilov wrote: > From e7147352639fd8f92b1cc85cff9bc5046c7a2130 Mon Sep 17 00:00:00 2001 > From: "Matwey V. Kornilov" > Date: Mon, 2 Jun 2014 20:17:29 +0400 > Subject: [PATCH] Replace type of paddr to uint32_t. > > This patch helps to avoid the following build issue: > > drivers/gpu/drm/msm/msm_fbdev.c:108:2: error: passing argument 3 of > 'msm_gem_get_iova_locked' from incompatible pointer type [-Werror] > msm_gem_get_iova_locked(fbdev->bo, 0, &paddr); > ^ > In file included from drivers/gpu/drm/msm/msm_fbdev.c:18:0: > drivers/gpu/drm/msm/msm_drv.h:153:5: note: expected 'uint32_t *' but > argument is of type 'dma_addr_t *' > int msm_gem_get_iova_locked(struct drm_gem_object *obj, int id, > ^ > > Signed-off-by: Matwey V. Kornilov Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_fbdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_fbdev.c > b/drivers/gpu/drm/msm/msm_fbdev.c > index a752ab8..5107fc4 100644 > --- a/drivers/gpu/drm/msm/msm_fbdev.c > +++ b/drivers/gpu/drm/msm/msm_fbdev.c > @@ -59,7 +59,7 @@ static int msm_fbdev_create(struct drm_fb_helper *helper, > struct drm_framebuffer *fb = NULL; > struct fb_info *fbi = NULL; > struct drm_mode_fb_cmd2 mode_cmd = {0}; > - dma_addr_t paddr; > + uint32_t paddr; > int ret, size; > > sizes->surface_bpp = 32; > -- > 1.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/