From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E12C433FE for ; Wed, 11 May 2022 20:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235722AbiEKUGj (ORCPT ); Wed, 11 May 2022 16:06:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231585AbiEKUGi (ORCPT ); Wed, 11 May 2022 16:06:38 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A988233363; Wed, 11 May 2022 13:06:37 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id m1so4430407wrb.8; Wed, 11 May 2022 13:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W6YNSoA5Dua0+s/FF7SpEIcKqn99xdL9v6a8e8wASjE=; b=huVs1irgBIkg9Eul0wYK5EYPJx3b0ncqN0x9QsTfJvBcQ2t5FOtXmqR45KnVbSBCt0 tRVR32t6absZdZ99QabYYfqRY9JvV5eBYNqMncuhU2tTBEa3Jx27JsNQ5Qk/8J/I1Rqd uiZxKXViZRvewgUcnsIcC3Lbrm8xA1GbN6EW0FjiDtQoz/UCGHm8rUNxBJguevCQ8bby hbqSts8HPIVGxqadiiBHoU5HXVcqmZGmu8SOnw+2/jhm12VXAimJtNgdng9UB3jfuSIq 6e1eUh5wALaSoHtArYquH1ViBA4Y+EuTOUaXV46Htl6nWhXkQD9cVPMgbXCnlOic3bq7 XXOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W6YNSoA5Dua0+s/FF7SpEIcKqn99xdL9v6a8e8wASjE=; b=jIbk90YdUXfXvJZ8ACJopqiFLW53MdJ1ZBNfinMfZzq1Q9dsnQc/MonA3T6WsAU7cO RVQKq2yvIyyM8DrG3mLon9itHq4PlxZgiTcG/hf+n1ee74HYm3h4KJsbEVgoVvxCrPsu cTzxpxs0RgpI3DgJX3FhgYrCmmuMALv9HQYwSDqRsCoRje6j34gus6G0J3/nnefiMrom bGQrAxDC/EJdkLqw1Lxr1+QQbg4zIebyGRExAUmQuvCCxn8rmENi4g0rLGeCAVoSm3xF ouA9g+/ip7jECnhJ3NNGm1cN7R43Y4qHc0A5kRjZ0NoP6Fyq48ZEoKaQubD2uVW+xHKa pDVw== X-Gm-Message-State: AOAM530RVgx+jmsPzKj9Oqa0FkGjdL/YX4TxAB1Cfd9+9WnKj1jEQ/xs ZBnySnD8853MWCBnco9Z96cN9YfzowL9mF6Tj4g39n6z X-Google-Smtp-Source: ABdhPJztZ9XbUj0FLLKnjaG49uOatzw5PqIll6Yx+Z6ecof8fZ/Xg+4CXVkwVcsz/BnqI+EDtAS88Q5dTYmp2/hyOH8= X-Received: by 2002:a05:6000:156e:b0:20c:5218:8907 with SMTP id 14-20020a056000156e00b0020c52188907mr24120425wrz.297.1652299596131; Wed, 11 May 2022 13:06:36 -0700 (PDT) MIME-Version: 1.0 References: <20220510070140.45407-1-tomeu.vizoso@collabora.com> <20220510141329.54414-1-tomeu.vizoso@collabora.com> In-Reply-To: From: Rob Clark Date: Wed, 11 May 2022 13:06:23 -0700 Message-ID: Subject: Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory To: Linus Torvalds Cc: Dave Airlie , Tomeu Vizoso , Greg Kroah-Hartman , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Daniel Vetter , Jonathan Corbet , Sean Paul , Abhinav Kumar , "open list:DOCUMENTATION" , linux-arm-msm , LKML , dri-devel , freedreno Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 11, 2022 at 12:08 PM Linus Torvalds wrote: > > On Wed, May 11, 2022 at 11:40 AM Rob Clark wrote: > > > > It is missing in this revision of the RFC, but the intention is to > > have the gitlab-ci.yml point to a specific commit SHA in the > > gfx-ci/drm-ci[1] tree, to solve the problem of keeping the results in > > sync with the expectations. Ie. a kernel commit would control moving > > to a new version of i-g-t (and eventually deqp and/or piglit), and at > > the same time make any necessary updates in the expectations files. > > Wouldn't it then be better to just have the expectation files in the > ci tree too? The main reason is that we would frequently have situations where both -next and -fixes pointing at the same ci tree commit, but with differing expectations. If we kept the expectations in the ci tree, we'd end up frequently updating the ci tree and then updating the kernel tree to point to the appropriate ci tree version. Additionally, on the mesa side, it has been useful to squash the expectations update into the commit that fixed a bug or added a feature. It provides a connection in git history between code and test results. BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06693C4332F for ; Wed, 11 May 2022 20:06:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BBB3112B5B; Wed, 11 May 2022 20:06:38 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF844112B58; Wed, 11 May 2022 20:06:37 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id a5so646477wrp.7; Wed, 11 May 2022 13:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W6YNSoA5Dua0+s/FF7SpEIcKqn99xdL9v6a8e8wASjE=; b=huVs1irgBIkg9Eul0wYK5EYPJx3b0ncqN0x9QsTfJvBcQ2t5FOtXmqR45KnVbSBCt0 tRVR32t6absZdZ99QabYYfqRY9JvV5eBYNqMncuhU2tTBEa3Jx27JsNQ5Qk/8J/I1Rqd uiZxKXViZRvewgUcnsIcC3Lbrm8xA1GbN6EW0FjiDtQoz/UCGHm8rUNxBJguevCQ8bby hbqSts8HPIVGxqadiiBHoU5HXVcqmZGmu8SOnw+2/jhm12VXAimJtNgdng9UB3jfuSIq 6e1eUh5wALaSoHtArYquH1ViBA4Y+EuTOUaXV46Htl6nWhXkQD9cVPMgbXCnlOic3bq7 XXOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W6YNSoA5Dua0+s/FF7SpEIcKqn99xdL9v6a8e8wASjE=; b=sUtepmhvnole91/OxWUnuxDi64P/pDwv2skjdaQdSmkDrzntediH+Q1BGh1FNcPlSV LNg7SVseejTfPJ6xUbDlMtox1x339nGXbk6g7o3VBv/QkNgCd4S6SgjZMaRhNloOa9SR hyCOTWnDvCCE2QuqxqUL50mRG/6Eq9Yw7/suMFaItncobTIOdb/fpvb23SaQlhwf6KIo XBWiRxMtgHTq/hOKp55pd84xaxKg13AL8k58SWWP6t10zeoQZjHgZuiOiTkg6cjPns2e zDh2uf6x1j9Q3nWpz0Vf35sMMPM43eVFtTucBX+n6WQ8nlJwnczPld5W10dTxZ92Carm LwZg== X-Gm-Message-State: AOAM533QjXFnWZY6JkqJ+s6Ux2ppoFh77MS3h9ebvtPvxQPHNi5bwJ34 jPe2AKRpow1hbnWNxnXXRavQrseFrG4/pIQW6fI= X-Google-Smtp-Source: ABdhPJztZ9XbUj0FLLKnjaG49uOatzw5PqIll6Yx+Z6ecof8fZ/Xg+4CXVkwVcsz/BnqI+EDtAS88Q5dTYmp2/hyOH8= X-Received: by 2002:a05:6000:156e:b0:20c:5218:8907 with SMTP id 14-20020a056000156e00b0020c52188907mr24120425wrz.297.1652299596131; Wed, 11 May 2022 13:06:36 -0700 (PDT) MIME-Version: 1.0 References: <20220510070140.45407-1-tomeu.vizoso@collabora.com> <20220510141329.54414-1-tomeu.vizoso@collabora.com> In-Reply-To: From: Rob Clark Date: Wed, 11 May 2022 13:06:23 -0700 Message-ID: Subject: Re: Adding CI results to the kernel tree was Re: [RFC v2] drm/msm: Add initial ci/ subdirectory To: Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , freedreno , Tomeu Vizoso , Jonathan Corbet , Greg Kroah-Hartman , "open list:DOCUMENTATION" , Abhinav Kumar , LKML , dri-devel , Thomas Zimmermann , linux-arm-msm Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, May 11, 2022 at 12:08 PM Linus Torvalds wrote: > > On Wed, May 11, 2022 at 11:40 AM Rob Clark wrote: > > > > It is missing in this revision of the RFC, but the intention is to > > have the gitlab-ci.yml point to a specific commit SHA in the > > gfx-ci/drm-ci[1] tree, to solve the problem of keeping the results in > > sync with the expectations. Ie. a kernel commit would control moving > > to a new version of i-g-t (and eventually deqp and/or piglit), and at > > the same time make any necessary updates in the expectations files. > > Wouldn't it then be better to just have the expectation files in the > ci tree too? The main reason is that we would frequently have situations where both -next and -fixes pointing at the same ci tree commit, but with differing expectations. If we kept the expectations in the ci tree, we'd end up frequently updating the ci tree and then updating the kernel tree to point to the appropriate ci tree version. Additionally, on the mesa side, it has been useful to squash the expectations update into the commit that fixed a bug or added a feature. It provides a connection in git history between code and test results. BR, -R