From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c Date: Tue, 3 Oct 2017 14:54:33 -0400 Message-ID: References: <20171003091155.7138-1-linus.walleij@linaro.org> <20171003091155.7138-2-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:46794 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbdJCSyf (ORCPT ); Tue, 3 Oct 2017 14:54:35 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Nicolas Dechesne Cc: Srinivas Kandagatla , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , Andy Gross , David Brown , Stephen Boyd , Bjorn Andersson , linux-soc@vger.kernel.org On Tue, Oct 3, 2017 at 1:49 PM, Nicolas Dechesne wrote: > On Tue, Oct 3, 2017 at 6:37 PM, Rob Clark wrote: >> On Tue, Oct 3, 2017 at 8:25 AM, Srinivas Kandagatla >> wrote: >>> >>> >>> On 03/10/17 10:11, Linus Walleij wrote: >>>> >>>> Naming the DragonBoard 410c "SBC" (I guess "single board computer") >>>> is not very helpful for users looking for their device tree in >>>> the kernel. Also the db820c is named properly. >>>> >>>> Rectify this, simply, do not change the compatible strings but name >>>> the DTS files in a consistent manner. >>>> >>>> Signed-off-by: Linus Walleij >>> >>> I did not like the sbc naming convention too, This was primarily done due to >>> some legacy build tools + bootloaders which have used sbc compatible to >>> identify boards from multiple dtb blobs. Now that we can append dtb to >>> kernel with new LK, this should not be a issue anymore. >> >> maybe it would be an idea to update skales/dbttool first to look for >> the new name, and then give people some time to upgrade, before >> changing this in the kernel. Otherwise I expect you'll cause some >> confusion.. > > iirc, skale is using the compatible name, not the filename. > ahh, yes, I think you are right.. u-boot is using a different filename. So in this case, no issue to pick a saner name :-) BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 From: robdclark@gmail.com (Rob Clark) Date: Tue, 3 Oct 2017 14:54:33 -0400 Subject: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c In-Reply-To: References: <20171003091155.7138-1-linus.walleij@linaro.org> <20171003091155.7138-2-linus.walleij@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 3, 2017 at 1:49 PM, Nicolas Dechesne wrote: > On Tue, Oct 3, 2017 at 6:37 PM, Rob Clark wrote: >> On Tue, Oct 3, 2017 at 8:25 AM, Srinivas Kandagatla >> wrote: >>> >>> >>> On 03/10/17 10:11, Linus Walleij wrote: >>>> >>>> Naming the DragonBoard 410c "SBC" (I guess "single board computer") >>>> is not very helpful for users looking for their device tree in >>>> the kernel. Also the db820c is named properly. >>>> >>>> Rectify this, simply, do not change the compatible strings but name >>>> the DTS files in a consistent manner. >>>> >>>> Signed-off-by: Linus Walleij >>> >>> I did not like the sbc naming convention too, This was primarily done due to >>> some legacy build tools + bootloaders which have used sbc compatible to >>> identify boards from multiple dtb blobs. Now that we can append dtb to >>> kernel with new LK, this should not be a issue anymore. >> >> maybe it would be an idea to update skales/dbttool first to look for >> the new name, and then give people some time to upgrade, before >> changing this in the kernel. Otherwise I expect you'll cause some >> confusion.. > > iirc, skale is using the compatible name, not the filename. > ahh, yes, I think you are right.. u-boot is using a different filename. So in this case, no issue to pick a saner name :-) BR, -R