From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA3CC433B4 for ; Sun, 9 May 2021 16:24:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06E4F613ED for ; Sun, 9 May 2021 16:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbhEIQ0A (ORCPT ); Sun, 9 May 2021 12:26:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbhEIQZ7 (ORCPT ); Sun, 9 May 2021 12:25:59 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F569C061573; Sun, 9 May 2021 09:24:55 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id p14-20020a05600c358eb029015c01f207d7so1782408wmq.5; Sun, 09 May 2021 09:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eDSzWlroomnQ5h3Y6dUDqkb1FsjYS2fbu1DIxKf7c3A=; b=cQozjKYypAyMo0LvueEtTElyTE89pbNeSyAoFIrXqpB1CpGFAdKfj7MVmVliTQj8q9 wbN9Nxi/zHWx8eZu4r9G59UNIuDM6+PtVjJiN1YBECdhW71T2vjY0vnnH5KpALtLXFek Xums8DkBafio8UuYgRN6YGcnQQRUZ7H6hxO6genyBZWTKwj++V9YdtZ3QHDHqaaghcw0 LrUxJkyi8UDEjjDd62HYANDeBdcI1/zO6AyKgtL7RqSbdhV6FOcfX+TDgbk/PyD7lON2 dFL9H5Ud8wOUsk18ENiOcnGSzTpQdTOdnKUTTVRdfeoCeApLMmQXb+hoG1ZkZIynMuzG IsVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eDSzWlroomnQ5h3Y6dUDqkb1FsjYS2fbu1DIxKf7c3A=; b=ipGKHVR38A3t+8ElbNtGS+CpQ2DmpUaLyJowlL5SRLc/IEquv5EAkHTW6KwnssRm/c uUZymeXKq50B9aOb7urbgSAyde4u5SOUsl6KQEEoNPZAyoJO1YBF5lZtMN1bo50A4D7Y zO2ds6Zd7bcjIgXPEqo5NVjapeFAVSzTs72TX0/Uhy3xWr4FDrZU/Cj2o3n7aF7Z5YaF f1pUiixPOx+3i0Teh1Cz0HRNYx3rdZjV4iEQ1eQmnwz6KYbuYDDouSlIWwZ8Mu3t1Za+ rQQpeAkuWEbMBNgHtwR876tDeYUl1aynLsuUVLCTNf5TjHlrvf2yFd5ElsYvZbgXql0P 6Gcg== X-Gm-Message-State: AOAM531A0P3QnlfimQLDofjCsXNQLK0StfNdJq9daVEuEaQMqo4CXwc5 2Fro1IhUvJJt0ni1ylQ4au7RJZGEgu7MrGG7ZQI= X-Google-Smtp-Source: ABdhPJxCTH5X6v8qARUz2sTxBc7o5z4ShukPhUKB3YkniYCZ9F1AhWzx8i6yLXakzqyxm36pS5Poti9A3Xxakw2v9vQ= X-Received: by 2002:a7b:c101:: with SMTP id w1mr33251557wmi.164.1620577493717; Sun, 09 May 2021 09:24:53 -0700 (PDT) MIME-Version: 1.0 References: <20210508195641.397198-1-robdclark@gmail.com> <20210508195641.397198-3-robdclark@gmail.com> In-Reply-To: <20210508195641.397198-3-robdclark@gmail.com> From: Rob Clark Date: Sun, 9 May 2021 09:28:35 -0700 Message-ID: Subject: Re: [PATCH 2/2] drm/msm/dpu: Wire up needs_dirtyfb To: dri-devel Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Abhinav Kumar , Stephen Boyd , Maxime Ripard , Kalyan Thota , Qinglang Miao , Hongbo Yao , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Ryan Houdek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat, May 8, 2021 at 12:53 PM Rob Clark wrote: > > From: Rob Clark > > Signed-off-by: Rob Clark >From Ryan (sending this for him because mailing list workflow is lame): I have tested this on my end and it resolves the 120hz problem. Tested-By: Ryan Houdek > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 5a74f93e29da..868ee6136438 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -143,6 +143,19 @@ static bool dpu_crtc_get_scanout_position(struct drm_crtc *crtc, > return true; > } > > +static bool dpu_crtc_needs_dirtyfb(struct drm_crtc *crtc) > +{ > + struct drm_encoder *encoder; > + > + drm_for_each_encoder_mask (encoder, crtc->dev, crtc->state->encoder_mask) { > + if (dpu_encoder_get_intf_mode(encoder) == INTF_MODE_CMD) { > + return true; > + } > + } > + > + return false; > +} > + > static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, > struct dpu_plane_state *pstate, struct dpu_format *format) > { > @@ -1343,6 +1356,7 @@ static const struct drm_crtc_helper_funcs dpu_crtc_helper_funcs = { > .atomic_begin = dpu_crtc_atomic_begin, > .atomic_flush = dpu_crtc_atomic_flush, > .get_scanout_position = dpu_crtc_get_scanout_position, > + .needs_dirtyfb = dpu_crtc_needs_dirtyfb, > }; > > /* initialize crtc */ > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 831A5C433ED for ; Sun, 9 May 2021 16:24:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3220D61400 for ; Sun, 9 May 2021 16:24:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3220D61400 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A06D89CBE; Sun, 9 May 2021 16:24:57 +0000 (UTC) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8188B89CBE; Sun, 9 May 2021 16:24:55 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id 82-20020a1c01550000b0290142562ff7c9so7505623wmb.3; Sun, 09 May 2021 09:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eDSzWlroomnQ5h3Y6dUDqkb1FsjYS2fbu1DIxKf7c3A=; b=cQozjKYypAyMo0LvueEtTElyTE89pbNeSyAoFIrXqpB1CpGFAdKfj7MVmVliTQj8q9 wbN9Nxi/zHWx8eZu4r9G59UNIuDM6+PtVjJiN1YBECdhW71T2vjY0vnnH5KpALtLXFek Xums8DkBafio8UuYgRN6YGcnQQRUZ7H6hxO6genyBZWTKwj++V9YdtZ3QHDHqaaghcw0 LrUxJkyi8UDEjjDd62HYANDeBdcI1/zO6AyKgtL7RqSbdhV6FOcfX+TDgbk/PyD7lON2 dFL9H5Ud8wOUsk18ENiOcnGSzTpQdTOdnKUTTVRdfeoCeApLMmQXb+hoG1ZkZIynMuzG IsVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eDSzWlroomnQ5h3Y6dUDqkb1FsjYS2fbu1DIxKf7c3A=; b=AzPQU24umP8QpCTGEYu7ERXRz1TosSzkP/klPeMcZFxFtUM3aTIMX6i6lepau2/nVS nBC2KyrIZztzgQ80u31GWPthSO8nEIK2NkXfOWZW2fQb3o+CgpbC6jFkIKQ3P7HfkYEX Fpopdq9FZDKWBKWlnVtlLlg7kL7F7GRE1f4HwlwqYcT26onER/24VHBZFSyT8jq1O+G2 ncwoHFwwZZvKT+ed9PAbVo/RLDEpl0H7Dq4Ihlp9lBcVZi2JqJKOlMhRCr7QKN/q7I97 yetjrGF9RJI33d/5bHQl2QgDXqVsPf3TdukYTtxp1vl1RD91mF+toAsccldpkGuwpBY2 SPpw== X-Gm-Message-State: AOAM530Uo+PituxY+tJeZaz4z576RUvr8TJsZceX689lPv/wyaJKX1bH 15HLKg6+q1Uf7RKb+r03iLzkb43gTlCs+HpaFwtYU7dTI/I= X-Google-Smtp-Source: ABdhPJxCTH5X6v8qARUz2sTxBc7o5z4ShukPhUKB3YkniYCZ9F1AhWzx8i6yLXakzqyxm36pS5Poti9A3Xxakw2v9vQ= X-Received: by 2002:a7b:c101:: with SMTP id w1mr33251557wmi.164.1620577493717; Sun, 09 May 2021 09:24:53 -0700 (PDT) MIME-Version: 1.0 References: <20210508195641.397198-1-robdclark@gmail.com> <20210508195641.397198-3-robdclark@gmail.com> In-Reply-To: <20210508195641.397198-3-robdclark@gmail.com> From: Rob Clark Date: Sun, 9 May 2021 09:28:35 -0700 Message-ID: Subject: Re: [PATCH 2/2] drm/msm/dpu: Wire up needs_dirtyfb To: dri-devel Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Ryan Houdek , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Hongbo Yao , open list , Abhinav Kumar , Stephen Boyd , Qinglang Miao , Maxime Ripard , Kalyan Thota , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, May 8, 2021 at 12:53 PM Rob Clark wrote: > > From: Rob Clark > > Signed-off-by: Rob Clark >From Ryan (sending this for him because mailing list workflow is lame): I have tested this on my end and it resolves the 120hz problem. Tested-By: Ryan Houdek > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 5a74f93e29da..868ee6136438 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -143,6 +143,19 @@ static bool dpu_crtc_get_scanout_position(struct drm_crtc *crtc, > return true; > } > > +static bool dpu_crtc_needs_dirtyfb(struct drm_crtc *crtc) > +{ > + struct drm_encoder *encoder; > + > + drm_for_each_encoder_mask (encoder, crtc->dev, crtc->state->encoder_mask) { > + if (dpu_encoder_get_intf_mode(encoder) == INTF_MODE_CMD) { > + return true; > + } > + } > + > + return false; > +} > + > static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, > struct dpu_plane_state *pstate, struct dpu_format *format) > { > @@ -1343,6 +1356,7 @@ static const struct drm_crtc_helper_funcs dpu_crtc_helper_funcs = { > .atomic_begin = dpu_crtc_atomic_begin, > .atomic_flush = dpu_crtc_atomic_flush, > .get_scanout_position = dpu_crtc_get_scanout_position, > + .needs_dirtyfb = dpu_crtc_needs_dirtyfb, > }; > > /* initialize crtc */ > -- > 2.30.2 >