From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BBCC4161D for ; Thu, 11 Oct 2018 12:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B5552077C for ; Thu, 11 Oct 2018 12:32:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O+y9CkC0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B5552077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728213AbeJKT7A (ORCPT ); Thu, 11 Oct 2018 15:59:00 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:54232 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbeJKT7A (ORCPT ); Thu, 11 Oct 2018 15:59:00 -0400 Received: by mail-it1-f193.google.com with SMTP id q70-v6so13124126itb.3; Thu, 11 Oct 2018 05:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e60FdofV9MbJnwMkfh2fikEoup8wf4R5ARPW9Bxb4bI=; b=O+y9CkC0V4XwePtsBRmRKwf1CmnW7ao/T+Frkbu7VunGvEZ6B5iKUOcKqqFgnSq7No QrmxRquhyLTePiCUYnLEgicvTE7GHHnuq3jZ3nxdTpIBf3zug0bsI1aAiM3KcsfOwz7H Fddkvj68skAIwN8CMevaBdlCcYcTEMZJj7rfY/lqYV4g0RpC93dfZ0ESU73qtDNZ6Qs5 UEWZnbyUtejnDrRR4AzbMjnd5XWA1nrQ4fK+uI5dEetcsYPp9e3RHE8H8UFR0UDbQn5M QkJcQKYgu166eq6LzfGkerVcTm6kWBk3UZBDDYC24+lMDVHNBY76hJpdhJMf4U9E2KzB 5y3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e60FdofV9MbJnwMkfh2fikEoup8wf4R5ARPW9Bxb4bI=; b=csjg1vxJScFxtbnzJeY8736LT41YXCS8lrSgM2M3RvX6F0Rw5WcnE8cQLcMsyAYCeK YMsn2zNIKZd1B8c2pW9R5WZDRmMXipsmz0f3XpeJcEL9hHBXkJ4gA1jCW4tKwEFIK7y8 OqaNgDlNDJotpM+/msez9bBxOjnJjLvWizaPSSHbqY2yeGrvsiZDaIHCOxMghbH+waXG /qmW6AWBOZSJ0NEn0YYR6zDt0YRuFE2/lYeP8Jc67g4NywFjO+y7VX7/lO46wIlNNhpJ JvVQ3/kpHCsl15iZGE0gKS6PnMFGdvtB6v5MPLJBKbmg7ntYcSuiN5pbCDS2ZUU/FcYC yu2A== X-Gm-Message-State: ABuFfohlylCFeTYTqDEIrZD4h1r2Mku3z6u0yubgZa1jdV4NhtN9rsEi rOX6xWBlU7bhWjaVVOcZBa8C3IolCcrizBcl3b4= X-Google-Smtp-Source: ACcGV60kuqDthSRoOjcmUzlTCzaoMBe+BhlAn9OVY4sINhDx7Vq28NVCO20tvES8vxHjllp+3TVMu7WtQ+h1GqQQygo= X-Received: by 2002:a24:9c86:: with SMTP id b128-v6mr1335182ite.104.1539261119251; Thu, 11 Oct 2018 05:31:59 -0700 (PDT) MIME-Version: 1.0 References: <20181010151801.21489-1-robdclark@gmail.com> In-Reply-To: From: Rob Clark Date: Thu, 11 Oct 2018 08:31:45 -0400 Message-ID: Subject: Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate To: Arnd Bergmann Cc: dri-devel , Linux Fbdev development list , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Simon Horman , Geert Uytterhoeven , Randy Dunlap , Ulf Magnusson , Hans de Goede , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 11, 2018 at 3:02 AM Arnd Bergmann wrote: > > On Thu, Oct 11, 2018 at 3:16 AM Rob Clark wrote: > > > > On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: > > > > > > On 10/10/18, Rob Clark wrote: > > > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > > > > FB_BACKLIGHT prevents it from being built as a module. There > > > > doesn't seem to be any particularly good reason for this, so > > > > switch FB_BACKLIGHT over to tristate. > > > > > > > > Signed-off-by: Rob Clark > > > > > > I don't see anything immediately wrong, but anything related to > > > BACKLIGHT_CLASS_DEVICE, BACKLIGHT_LCD_SUPPORT > > > and FB_BACKLIGHT is really fragile in Kconfig, because of the > > > way those interact with other options. > > > > > > I've applied your patch to my randconfig build tree for testing, > > > let's see what happens there before you apply it. > > > > > > > thanks.. tbh the fragility of backlight vs kconfig is why I've > > procrastinated on fixing this for a while.. in the end the solution > > seems not as bad as I feared (and after a iteration or two makes rhel > > kernel builds for various archs happy, at least).. but defn some > > randconfig build testing is in order. > > Ok, my overnight testing shows no regression, so please add > > Tested-by: Arnd Bergmann Thanks > > > PS. discovering that the thing you need to fix (a) never really worked > > as intended, and (b) involves backlight + fbdev.. is never a good way > > to start your day ;-) > > I still have a bunch of related fixes in my tree that address > randconfig builds that never worked. I think at one point > I got a few 'Reviewed-by' replies from DRM folks, but then > nobody picked it up and subsequently it stopped applying. > I need to go back and dig out all the dependent patches from > my randconfig tree and resend that. I assume those patches (and this one) would be picked up via fbdev tree? BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Date: Thu, 11 Oct 2018 12:31:45 +0000 Subject: Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate Message-Id: List-Id: References: <20181010151801.21489-1-robdclark@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann Cc: Linux Fbdev development list , Ulf Magnusson , Geert Uytterhoeven , Bartlomiej Zolnierkiewicz , Randy Dunlap , Linux Kernel Mailing List , dri-devel , Laurent Pinchart , Simon Horman , Hans de Goede On Thu, Oct 11, 2018 at 3:02 AM Arnd Bergmann wrote: > > On Thu, Oct 11, 2018 at 3:16 AM Rob Clark wrote: > > > > On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: > > > > > > On 10/10/18, Rob Clark wrote: > > > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > > > > FB_BACKLIGHT prevents it from being built as a module. There > > > > doesn't seem to be any particularly good reason for this, so > > > > switch FB_BACKLIGHT over to tristate. > > > > > > > > Signed-off-by: Rob Clark > > > > > > I don't see anything immediately wrong, but anything related to > > > BACKLIGHT_CLASS_DEVICE, BACKLIGHT_LCD_SUPPORT > > > and FB_BACKLIGHT is really fragile in Kconfig, because of the > > > way those interact with other options. > > > > > > I've applied your patch to my randconfig build tree for testing, > > > let's see what happens there before you apply it. > > > > > > > thanks.. tbh the fragility of backlight vs kconfig is why I've > > procrastinated on fixing this for a while.. in the end the solution > > seems not as bad as I feared (and after a iteration or two makes rhel > > kernel builds for various archs happy, at least).. but defn some > > randconfig build testing is in order. > > Ok, my overnight testing shows no regression, so please add > > Tested-by: Arnd Bergmann Thanks > > > PS. discovering that the thing you need to fix (a) never really worked > > as intended, and (b) involves backlight + fbdev.. is never a good way > > to start your day ;-) > > I still have a bunch of related fixes in my tree that address > randconfig builds that never worked. I think at one point > I got a few 'Reviewed-by' replies from DRM folks, but then > nobody picked it up and subsequently it stopped applying. > I need to go back and dig out all the dependent patches from > my randconfig tree and resend that. I assume those patches (and this one) would be picked up via fbdev tree? BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate Date: Thu, 11 Oct 2018 08:31:45 -0400 Message-ID: References: <20181010151801.21489-1-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19EC2891A6 for ; Thu, 11 Oct 2018 12:32:00 +0000 (UTC) Received: by mail-it1-x142.google.com with SMTP id 134-v6so13137906itz.2 for ; Thu, 11 Oct 2018 05:32:00 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: Linux Fbdev development list , Ulf Magnusson , Geert Uytterhoeven , Bartlomiej Zolnierkiewicz , Randy Dunlap , Linux Kernel Mailing List , dri-devel , Laurent Pinchart , Simon Horman , Hans de Goede List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMzowMiBBTSBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRi LmRlPiB3cm90ZToKPgo+IE9uIFRodSwgT2N0IDExLCAyMDE4IGF0IDM6MTYgQU0gUm9iIENsYXJr IDxyb2JkY2xhcmtAZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBXZWQsIE9jdCAxMCwgMjAx OCBhdCAxMTozNSBBTSBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPiB3cm90ZToKPiA+ID4K PiA+ID4gT24gMTAvMTAvMTgsIFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4gd3JvdGU6 Cj4gPiA+ID4gQkFDS0xJR0hUX0NMQVNTX0RFVklDRSBpcyBhbHJlYWR5IHRyaXN0YXRlLCBidXQg YSBkZXBlbmRlbmN5Cj4gPiA+ID4gRkJfQkFDS0xJR0hUIHByZXZlbnRzIGl0IGZyb20gYmVpbmcg YnVpbHQgYXMgYSBtb2R1bGUuICBUaGVyZQo+ID4gPiA+IGRvZXNuJ3Qgc2VlbSB0byBiZSBhbnkg cGFydGljdWxhcmx5IGdvb2QgcmVhc29uIGZvciB0aGlzLCBzbwo+ID4gPiA+IHN3aXRjaCBGQl9C QUNLTElHSFQgb3ZlciB0byB0cmlzdGF0ZS4KPiA+ID4gPgo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6 IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiA+ID4KPiA+ID4gSSBkb24ndCBzZWUg YW55dGhpbmcgaW1tZWRpYXRlbHkgd3JvbmcsIGJ1dCBhbnl0aGluZyByZWxhdGVkIHRvCj4gPiA+ IEJBQ0tMSUdIVF9DTEFTU19ERVZJQ0UsIEJBQ0tMSUdIVF9MQ0RfU1VQUE9SVAo+ID4gPiBhbmQg RkJfQkFDS0xJR0hUIGlzIHJlYWxseSBmcmFnaWxlIGluIEtjb25maWcsIGJlY2F1c2Ugb2YgdGhl Cj4gPiA+IHdheSB0aG9zZSBpbnRlcmFjdCB3aXRoIG90aGVyIG9wdGlvbnMuCj4gPiA+Cj4gPiA+ IEkndmUgYXBwbGllZCB5b3VyIHBhdGNoIHRvIG15IHJhbmRjb25maWcgYnVpbGQgdHJlZSBmb3Ig dGVzdGluZywKPiA+ID4gbGV0J3Mgc2VlIHdoYXQgaGFwcGVucyB0aGVyZSBiZWZvcmUgeW91IGFw cGx5IGl0Lgo+ID4gPgo+ID4KPiA+IHRoYW5rcy4uIHRiaCB0aGUgZnJhZ2lsaXR5IG9mIGJhY2ts aWdodCB2cyBrY29uZmlnIGlzIHdoeSBJJ3ZlCj4gPiBwcm9jcmFzdGluYXRlZCBvbiBmaXhpbmcg dGhpcyBmb3IgYSB3aGlsZS4uIGluIHRoZSBlbmQgdGhlIHNvbHV0aW9uCj4gPiBzZWVtcyBub3Qg YXMgYmFkIGFzIEkgZmVhcmVkIChhbmQgYWZ0ZXIgYSBpdGVyYXRpb24gb3IgdHdvIG1ha2VzIHJo ZWwKPiA+IGtlcm5lbCBidWlsZHMgZm9yIHZhcmlvdXMgYXJjaHMgaGFwcHksIGF0IGxlYXN0KS4u IGJ1dCBkZWZuIHNvbWUKPiA+IHJhbmRjb25maWcgYnVpbGQgdGVzdGluZyBpcyBpbiBvcmRlci4K Pgo+IE9rLCBteSBvdmVybmlnaHQgdGVzdGluZyBzaG93cyBubyByZWdyZXNzaW9uLCBzbyBwbGVh c2UgYWRkCj4KPiBUZXN0ZWQtYnk6IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+CgpUaGFu a3MKCj4KPiA+IFBTLiBkaXNjb3ZlcmluZyB0aGF0IHRoZSB0aGluZyB5b3UgbmVlZCB0byBmaXgg KGEpIG5ldmVyIHJlYWxseSB3b3JrZWQKPiA+IGFzIGludGVuZGVkLCBhbmQgKGIpIGludm9sdmVz IGJhY2tsaWdodCArIGZiZGV2Li4gaXMgbmV2ZXIgYSBnb29kIHdheQo+ID4gdG8gc3RhcnQgeW91 ciBkYXkgOy0pCj4KPiBJIHN0aWxsIGhhdmUgYSBidW5jaCBvZiByZWxhdGVkIGZpeGVzIGluIG15 IHRyZWUgdGhhdCBhZGRyZXNzCj4gcmFuZGNvbmZpZyBidWlsZHMgdGhhdCBuZXZlciB3b3JrZWQu IEkgdGhpbmsgYXQgb25lIHBvaW50Cj4gSSBnb3QgYSBmZXcgJ1Jldmlld2VkLWJ5JyByZXBsaWVz IGZyb20gRFJNIGZvbGtzLCBidXQgdGhlbgo+IG5vYm9keSBwaWNrZWQgaXQgdXAgYW5kIHN1YnNl cXVlbnRseSBpdCBzdG9wcGVkIGFwcGx5aW5nLgo+IEkgbmVlZCB0byBnbyBiYWNrIGFuZCBkaWcg b3V0IGFsbCB0aGUgZGVwZW5kZW50IHBhdGNoZXMgZnJvbQo+IG15IHJhbmRjb25maWcgdHJlZSBh bmQgcmVzZW5kIHRoYXQuCgpJIGFzc3VtZSB0aG9zZSBwYXRjaGVzIChhbmQgdGhpcyBvbmUpIHdv dWxkIGJlIHBpY2tlZCB1cCB2aWEgZmJkZXYgdHJlZT8KCkJSLAotUgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK