From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 5/6] freedreno: set automake options to include subdir-objects Date: Fri, 30 Aug 2013 11:19:10 -0400 Message-ID: References: <1377808314-30699-1-git-send-email-emil.l.velikov@gmail.com> <1377808314-30699-6-git-send-email-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by gabe.freedesktop.org (Postfix) with ESMTP id ABDAEE68EE for ; Fri, 30 Aug 2013 08:19:11 -0700 (PDT) Received: by mail-ie0-f170.google.com with SMTP id 16so3029392iea.1 for ; Fri, 30 Aug 2013 08:19:11 -0700 (PDT) In-Reply-To: <1377808314-30699-6-git-send-email-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Emil Velikov Cc: Rob Clark , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 29, 2013 at 4:31 PM, Emil Velikov wrote: > Handles automake complains about lack of forward-compatibility, due to the > source files in the kgsl and msm backends/folders. > > Cc: Rob Clark > Signed-off-by: Emil Velikov I've tested these two (this and 4/6).. they seem to work fine for me, although I won't claim to be an automake guru, so couldn't actually tell you if they are the "right" fixes. I wouldn't mind a reviewed-by from someone who does know automake better, but if no one speaks up and says otherwise, I will apply/push them. BR, -R > --- > > I'm suspecting that the warning is caused as Archlinux always keeps track > with latest releases, whereas other distributions prefer to use a more > tested software > > automake 1.14 > autoconf 2.69 > --- > > freedreno/Makefile.am | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/freedreno/Makefile.am b/freedreno/Makefile.am > index ec7e359..7903e5b 100644 > --- a/freedreno/Makefile.am > +++ b/freedreno/Makefile.am > @@ -1,3 +1,5 @@ > +AUTOMAKE_OPTIONS=subdir-objects > + > AM_CFLAGS = \ > $(WARN_CFLAGS) \ > -I$(top_srcdir) \ > -- > 1.8.4 >