From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CB5C433EF for ; Tue, 3 May 2022 14:14:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235685AbiECORq (ORCPT ); Tue, 3 May 2022 10:17:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236805AbiECORn (ORCPT ); Tue, 3 May 2022 10:17:43 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2094A193F1; Tue, 3 May 2022 07:14:11 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id e24so23536952wrc.9; Tue, 03 May 2022 07:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OpVFLxl9pFOrEMMRYurod/ib5CbjrjCpO741fI+XBvY=; b=ORZ5qamh0mtHiKUsp6Fsrqgs6cYzaoQsveccu4xwYWKnkIx69MGl6kFqs/vJuMNA7f 8F4kJHrlhCJ1BJHsmYT7q2d7ksTHVG0AElPCf9HOMpGKvj/x3FKDmq/8B6CjOYMNY6bR XjWo6uFJ3DLx5WRMfep4udC5lmGEB5aUJV1EIlrMx+BgFL3vFronlN3nn83fTJAjjoTz F0/WrfJEQwyEtfLgctGJnLXu5730T+IbV7kbAsy3cMUr4UMsZr84KgRnIGFKBmptwW4P lbQPnRg42BwPDILk0vcq0WY+nKGLo5NP0hpZPLNrXlT0maXHoEdzYzCk1DqXxrtsbfAa hdbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OpVFLxl9pFOrEMMRYurod/ib5CbjrjCpO741fI+XBvY=; b=E7m9qI9mey1spjHWJQG30rl7EKeckvFPoxOr5wyDAIjetW+qzVcYK/ai5mOtmfHTIA 96x67h/x1ygpRwHabQUcvm5pJkfqaawsMjxr8h2wUhxOTHhqEhzCEAS9hwmEvfwNSAyJ ikT00iiUP7WTedNnk68nIgd/BEhy6aMQ0J06WjEwScpkg4bnzwHtWYGwpjjIbdupl+Ql eAWLuVxGgls0L2Ec3dh5d88W+rfJZynlp8te5ojL7p42oWV6sPLM1daEVFhUv0MdR+YU s/LdZTdLm/mJcdDspZFf7jsuoKMZh/LrmIbk2ZMQItQ+1nGcNkhjQHjJLJYy6UVSSuMG TXEQ== X-Gm-Message-State: AOAM531gQiLr9VGSYmZ9Ok/+3MiWlMD0SR4yGUPo+pN09pcB+Hu35s12 +nl/VgloFjHBIcN2wusMVLUoJWbVl1D/c40/sDI= X-Google-Smtp-Source: ABdhPJxfCQsPR/EgO4+YAJav9yefxL/RYqx57TttjxZzGPlfPZF6XdSj2vXBbpV/r5m5E2PqVw7XTGqwYv3OdqLPtKU= X-Received: by 2002:adf:d1ec:0:b0:20c:6228:e2c8 with SMTP id g12-20020adfd1ec000000b0020c6228e2c8mr8026476wrd.328.1651587249457; Tue, 03 May 2022 07:14:09 -0700 (PDT) MIME-Version: 1.0 References: <20220502172908.3569799-1-robdclark@gmail.com> <86160889d7be260c5012044643b81d10098943fe.camel@pengutronix.de> In-Reply-To: <86160889d7be260c5012044643b81d10098943fe.camel@pengutronix.de> From: Rob Clark Date: Tue, 3 May 2022 07:13:55 -0700 Message-ID: Subject: Re: [PATCH] drm/msm: Limit command submission when no IOMMU To: Lucas Stach Cc: dri-devel , Rob Clark , David Airlie , linux-arm-msm , Abhinav Kumar , open list , Luca Weiss , Sean Paul , freedreno Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, May 3, 2022 at 5:12 AM Lucas Stach wrote: > > Am Montag, dem 02.05.2022 um 10:29 -0700 schrieb Rob Clark: > > From: Rob Clark > > > > Running the GPU without an IOMMU is not really a supported (or sane) > > configuration. Yet it can be useful during SoC bringup (ie. if the > > iommu driver doesn't work yet). > > > > Lets limit it to users who already have /dev/mem access, to avoid the > > chance that a user accidentially configures kernel without IOMMU > > support. > > I haven't followed MSM too closely, so ctx->aspace may also include the > GPU MMU, but if this really only includes the IOMMU (as the commit > message implies) then this breaks Freedreno on i.MX5. it includes the gpu mmu, so a2xx should be fine. BR, -R > Regards, > Lucas > > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > > index 23b68bc945f6..9cd8c8708990 100644 > > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > > @@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, > > if (args->pad) > > return -EINVAL; > > > > + if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) { > > + DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n"); > > + return -EPERM; > > + } > > + > > /* for now, we just have 3d pipe.. eventually this would need to > > * be more clever to dispatch to appropriate gpu module: > > */ > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E4C7C433EF for ; Tue, 3 May 2022 14:14:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6519D10F224; Tue, 3 May 2022 14:14:12 +0000 (UTC) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A8BB10F166; Tue, 3 May 2022 14:14:11 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id w4so23523885wrg.12; Tue, 03 May 2022 07:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OpVFLxl9pFOrEMMRYurod/ib5CbjrjCpO741fI+XBvY=; b=ORZ5qamh0mtHiKUsp6Fsrqgs6cYzaoQsveccu4xwYWKnkIx69MGl6kFqs/vJuMNA7f 8F4kJHrlhCJ1BJHsmYT7q2d7ksTHVG0AElPCf9HOMpGKvj/x3FKDmq/8B6CjOYMNY6bR XjWo6uFJ3DLx5WRMfep4udC5lmGEB5aUJV1EIlrMx+BgFL3vFronlN3nn83fTJAjjoTz F0/WrfJEQwyEtfLgctGJnLXu5730T+IbV7kbAsy3cMUr4UMsZr84KgRnIGFKBmptwW4P lbQPnRg42BwPDILk0vcq0WY+nKGLo5NP0hpZPLNrXlT0maXHoEdzYzCk1DqXxrtsbfAa hdbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OpVFLxl9pFOrEMMRYurod/ib5CbjrjCpO741fI+XBvY=; b=GfAUwXmHoMfap2OymMzg42jZaE4Lf09zA34YjwYV3mMfUgGvGUk5TNTgMbXYCtt8KJ AatdeX3wRYgQqKMQLKpJYaXDcL0Dx1Lcn2icYBUK8iEaWZgun84V7dNPnwFt2V+skfXv uisAczFYeeav9CtuZXRNgT4mr0h65Ec+JSz3ri8kz0lAkH3PLjQor3gcE1kwjZykKCwv MT4E1YwBviUOswZxG7bdOPTjPijDtkMUSIBFlmhWi7rIStkK1uojFtXqfqviFZWeW1pL +JTSYLzLO5I+cVUG9k/bYDyBszzitZwz/1jfLHZf5f04Txa4SeK7WOvi8UymqtFgrbfx Af+g== X-Gm-Message-State: AOAM530dZIz1gvf0UOAvjeX1hI6jQjNpKhuvywYpbXEPMW1KZLGa/mT3 Lef0aLjtpExxNahYGfbzcdeQXf48nbqvBOjjJmA= X-Google-Smtp-Source: ABdhPJxfCQsPR/EgO4+YAJav9yefxL/RYqx57TttjxZzGPlfPZF6XdSj2vXBbpV/r5m5E2PqVw7XTGqwYv3OdqLPtKU= X-Received: by 2002:adf:d1ec:0:b0:20c:6228:e2c8 with SMTP id g12-20020adfd1ec000000b0020c6228e2c8mr8026476wrd.328.1651587249457; Tue, 03 May 2022 07:14:09 -0700 (PDT) MIME-Version: 1.0 References: <20220502172908.3569799-1-robdclark@gmail.com> <86160889d7be260c5012044643b81d10098943fe.camel@pengutronix.de> In-Reply-To: <86160889d7be260c5012044643b81d10098943fe.camel@pengutronix.de> From: Rob Clark Date: Tue, 3 May 2022 07:13:55 -0700 Message-ID: Subject: Re: [PATCH] drm/msm: Limit command submission when no IOMMU To: Lucas Stach Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , freedreno , David Airlie , linux-arm-msm , open list , dri-devel , Abhinav Kumar , Luca Weiss , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 3, 2022 at 5:12 AM Lucas Stach wrote: > > Am Montag, dem 02.05.2022 um 10:29 -0700 schrieb Rob Clark: > > From: Rob Clark > > > > Running the GPU without an IOMMU is not really a supported (or sane) > > configuration. Yet it can be useful during SoC bringup (ie. if the > > iommu driver doesn't work yet). > > > > Lets limit it to users who already have /dev/mem access, to avoid the > > chance that a user accidentially configures kernel without IOMMU > > support. > > I haven't followed MSM too closely, so ctx->aspace may also include the > GPU MMU, but if this really only includes the IOMMU (as the commit > message implies) then this breaks Freedreno on i.MX5. it includes the gpu mmu, so a2xx should be fine. BR, -R > Regards, > Lucas > > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > > index 23b68bc945f6..9cd8c8708990 100644 > > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > > @@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, > > if (args->pad) > > return -EINVAL; > > > > + if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) { > > + DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n"); > > + return -EPERM; > > + } > > + > > /* for now, we just have 3d pipe.. eventually this would need to > > * be more clever to dispatch to appropriate gpu module: > > */ > >