From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Stephen Mallon <stephen.mallon@sydney.edu.au>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW_TSTAMP is enabled
Date: Mon, 29 Apr 2019 11:32:08 -0400 [thread overview]
Message-ID: <CAF=yD-+EdbxnSa1SUqPamdxeDN_oPd4-kXAEF6yV1o_Zwj+LUw@mail.gmail.com> (raw)
In-Reply-To: <20190429150242.vckwna4bt4xynzjo@localhost>
On Mon, Apr 29, 2019 at 11:02 AM Richard Cochran
<richardcochran@gmail.com> wrote:
>
> On Sun, Apr 28, 2019 at 10:57:57PM -0400, Willem de Bruijn wrote:
> > It is debatable whether this is a fix or a new feature. It extends
> > SOF_TIMESTAMPING_OPT_ID to hardware timestamps. I don't think this
> > would be a stable candidate.
>
> Was the original series advertised as SW timestamping only?
I did not intend to cover hardware timestamps at the time.
> If so, I missed that at the time. After seeing it not work, I meant
> to fix it, but never got around to it. So to me this is a known
> issue.
Understood. I certainly understand that view. I never use hw
timestamps, so it is a bit of a blind spot for me. If this is a safe
and predictable change, I don't care strongly about net vs net-next. I
don't think it meets the bar for stable, but that is not my call.
> > More importantly, note that __ip6_append_data has similar logic. For
> > consistency the two should be updated at the same time.
>
> +1
>
> Thanks,
> Richard
next prev parent reply other threads:[~2019-04-29 15:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 5:45 [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW_TSTAMP is enabled Stephen Mallon
2019-04-28 15:19 ` Richard Cochran
2019-04-29 2:57 ` Willem de Bruijn
2019-04-29 15:02 ` Richard Cochran
2019-04-29 15:32 ` Willem de Bruijn [this message]
2019-04-30 1:17 ` Stephen Mallon
2019-04-30 2:54 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-+EdbxnSa1SUqPamdxeDN_oPd4-kXAEF6yV1o_Zwj+LUw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=stephen.mallon@sydney.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.