From mboxrd@z Thu Jan  1 00:00:00 1970
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next 1/2] udp: msg_zerocopy
Date: Sat, 24 Nov 2018 21:13:08 -0500
Message-ID: <CAF=yD-+_pHR6S+JYxnJmRBgEWo3i1Pv-=Ku_Ni4ofShupMS6gA@mail.gmail.com>
References: <20181124192431.32037-1-willemdebruijn.kernel@gmail.com>
 <20181124192431.32037-2-willemdebruijn.kernel@gmail.com> <20181124.175826.1565485862310427469.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Network Development <netdev@vger.kernel.org>,
        Willem de Bruijn <willemb@google.com>
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ed1-f68.google.com ([209.85.208.68]:36628 "EHLO
        mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726722AbeKYNDm (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 25 Nov 2018 08:03:42 -0500
Received: by mail-ed1-f68.google.com with SMTP id f23so13054539edb.3
        for <netdev@vger.kernel.org>; Sat, 24 Nov 2018 18:13:46 -0800 (PST)
In-Reply-To: <20181124.175826.1565485862310427469.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, Nov 24, 2018 at 8:58 PM David Miller <davem@davemloft.net> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Date: Sat, 24 Nov 2018 14:24:30 -0500
>
> > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> > index c09219e7f230..2d1e4b67a1e8 100644
> > --- a/net/ipv4/ip_output.c
> > +++ b/net/ipv4/ip_output.c
> > @@ -868,6 +868,7 @@ static int __ip_append_data(struct sock *sk,
> >  {
> >       struct inet_sock *inet = inet_sk(sk);
> >       struct sk_buff *skb;
> > +     struct ubuf_info *uarg = NULL;
>
> Reverse christmas tree, please.

Oh right, sorry.

Will wait with v2 for a day or two, in case anyone else has comments.
Thanks for the quick review!