From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D53C43218 for ; Mon, 29 Apr 2019 03:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 49C8820675 for ; Mon, 29 Apr 2019 03:05:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HD0BN8ec" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727093AbfD2C6f (ORCPT ); Sun, 28 Apr 2019 22:58:35 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:42685 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbfD2C6e (ORCPT ); Sun, 28 Apr 2019 22:58:34 -0400 Received: by mail-ed1-f66.google.com with SMTP id l25so7790985eda.9 for ; Sun, 28 Apr 2019 19:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DB8W8g7vI+PLHuaHs4olgEMXQlsvHrhuCGy1sUFXTRs=; b=HD0BN8ecOB0cQi08FVXJw7u3TZ0LPuBf87MgOR6npScvbOvblMLBUKplBMUPKhMZCD iDYQ2kXO3ajc0fJN/Ue1MNexxlj6JPC9uauSFCA9IroJxSgOME3hr9/317w+ADngwGqC WOl2dV2IvkjokGu3dtVerj56X6vNPVlFj/oeZjA8XeeQUJeLV17Opcexy4ECOygiUSbf Ce5a/xVo5lU4kIwg9ahlFBNmyIc2wTQN4dMseIvLtikRXAtqRq6bSrUV0yl0YqxztWZo qWDX7LznRU8plxuEYW/CW8EeSMBydpWeu/NijbtJNXIxXwFyWVCy9car7b8liSAhGKwy QDww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DB8W8g7vI+PLHuaHs4olgEMXQlsvHrhuCGy1sUFXTRs=; b=BtBIKEMuI0KIPF/0nNGJtR52XeVHYGuh4jliRVi0cVx/49tUCrsG0lvgMO3WfaQvo0 RNeRVZO/utwwehLBGiM5CgHXIXdE1YxKUIx1crFK4HJg/ygaM/mggfMrMSMD7svq3XgO rOaV5dCyBuI4T99u31Owlm6R58Lf2R5LDiTS/PslCaa2sBt05UW2XkTOT1LVFQ27R66a aNUPuyun3vLcEWNpnCtq3VH2bSrVIlc6KQ9b9DZzrg7/IwJE1JIKSyERvB2MAaggkn0l Te8VlR3PVkypJvAJBbP5Yrba17USQTlD8qXbFWqUEsdp4OUlaf+6WIC+1CQu7PtkZnH3 SbbA== X-Gm-Message-State: APjAAAUQVm1C2qmEM3ZFwL7FpRqM2eMAIoR4Nj99VwTHLRqpbLRITK0L DL9mYlPb+VZiDdOhmxlYI1O/IbT149/mglTP9QQ= X-Google-Smtp-Source: APXvYqwVK/yH/VE3pk39dGBNcdPnf9hxG81cA47x3KwXYGqUi/yhD17A5GoGt5debbuSF/dj5m7PWMlGBcYNXVMj9xo= X-Received: by 2002:a17:906:f29a:: with SMTP id gu26mr7269731ejb.148.1556506713015; Sun, 28 Apr 2019 19:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20190428054521.GA14504@stephen-mallon> <20190428151938.njy3ip5szwj3vkda@localhost> In-Reply-To: <20190428151938.njy3ip5szwj3vkda@localhost> From: Willem de Bruijn Date: Sun, 28 Apr 2019 22:57:57 -0400 Message-ID: Subject: Re: [PATCH net] ipv4: Fix updating SOF_TIMESTAMPING_OPT_ID when SKBTX_HW_TSTAMP is enabled To: Richard Cochran Cc: Stephen Mallon , "David S. Miller" , Network Development Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Apr 28, 2019 at 11:22 AM Richard Cochran wrote: > > On Sun, Apr 28, 2019 at 03:45:21PM +1000, Stephen Mallon wrote: > > Ensure that the unique timestamp identifier is incremented for skb hardware > > timestamps, not just software timestamps. > > Thanks for fixing this. It has been at the back of my mind for a long > time, but since I don't use this feature... oh well. > > This patch would be a candidate for stable kernels. Can you please > add a Fixes: tag? It is debatable whether this is a fix or a new feature. It extends SOF_TIMESTAMPING_OPT_ID to hardware timestamps. I don't think this would be a stable candidate. More importantly, note that __ip6_append_data has similar logic. For consistency the two should be updated at the same time.