From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35868C433DB for ; Tue, 22 Dec 2020 14:44:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA6C0229C6 for ; Tue, 22 Dec 2020 14:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbgLVOos (ORCPT ); Tue, 22 Dec 2020 09:44:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727448AbgLVOor (ORCPT ); Tue, 22 Dec 2020 09:44:47 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DD59C0613D3 for ; Tue, 22 Dec 2020 06:44:07 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id j16so13174187edr.0 for ; Tue, 22 Dec 2020 06:44:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ccKih3qpozSFUW9gZuk9/wRr2X01uG5gam26BuXGogo=; b=q7sJzvB1wUOxXjIJHwo5OItGwECVzJQShaw5Aaug+JYTydzSbiaRFxLBW7b1up5k0d oFlNqTHHuxDgz/qhaH0bTC9/L0PXGqCMhY/pxbN/BLFl0mGdjJLNjfaryscntzh6Hray lsyB9x6FkEiSN702MkTQESijBv8Ta2ppiX3zIiKyg0c/m70NBTPeAaxskQviP45waaAS Ax2sXL4Ko/vPpEaXRAekrvAfWv8v4zbcy8+k8i/sBxpx9vHejg2136y7z5wrdRSZxSdT AfZsJZqGFcwbnHVY1oMtlOdLtM/vs9hMvz0MawHcG7hM86/SGwAxV0mOYhoX2OUtmx00 3hcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ccKih3qpozSFUW9gZuk9/wRr2X01uG5gam26BuXGogo=; b=Mh/F6QBggGGINjQdeSqppM2I5ZFR74d7PKcLR+Mb9TwbnAJVapC9KxtLq4xFEZQde1 ElFe5E/Kbj28i5MLCKT8drDWdkN/CotDQKhkmCCzx8+0UQ8/FYIZHLVLZpZuJL0kasnX hDIVtUZD1PjDTNJf0nqCx0ZZXIfyJ0oLlmuZTME93jEKlZyetDcMWPtZkFfwPkG67sXT BqIMchTYiL0p4j8xZ8JE3NfptGulSZW22ZFFN+Xs6Jb/tJp3FDzoK3L/BHYqjIveynoT AYjI11tNPApr23boTKLZbjdXyQak1CETQQuNq7bnTL4gxMJblGlBJdvTPR8mp5+QXfsj ahhg== X-Gm-Message-State: AOAM533r1eVpC8jhykH0gnq8knW+FgziFBKymM8c4/xmHFJiGcUUItJb leAiuGhN/8ANL5VFjzwXmGxlEAKDat1u06g43I0= X-Google-Smtp-Source: ABdhPJxreDQKnN2O5C5mJ5S+lPIjDlj2rDw9skS+xENC/OOOHgsKk9Qf692F6CE/ifYfNCvc75+V+HP4AL+zfdyeWfY= X-Received: by 2002:a50:9f4a:: with SMTP id b68mr20441975edf.296.1608648246141; Tue, 22 Dec 2020 06:44:06 -0800 (PST) MIME-Version: 1.0 References: <20201222000926.1054993-1-jonathan.lemon@gmail.com> <20201222000926.1054993-4-jonathan.lemon@gmail.com> In-Reply-To: <20201222000926.1054993-4-jonathan.lemon@gmail.com> From: Willem de Bruijn Date: Tue, 22 Dec 2020 09:43:30 -0500 Message-ID: Subject: Re: [PATCH 03/12 v2 RFC] skbuff: simplify sock_zerocopy_put To: Jonathan Lemon Cc: Network Development , Eric Dumazet , Kernel Team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon wrote: > > From: Jonathan Lemon > > All 'struct ubuf_info' users should have a callback defined. > Remove the dead code path to consume_skb(), which makes > unwarranted assumptions about how the structure was allocated. > > Signed-off-by: Jonathan Lemon Please link to the commit I shared that made the consume_skb path obsolete. Before that this would have been unsafe. should have a callback defined -> have a callback defined as of commit 0a4a060bb204 ("sock: fix zerocopy_success regression with msg_zerocopy"). With that explanation why this is correct Acked-by: Willem de Bruijn