From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Maxim Mikityanskiy <maximmi@mellanox.com>
Cc: Willem de Bruijn <willemb@google.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Eran Ben Elisha <eranbe@mellanox.com>,
Tariq Toukan <tariqt@mellanox.com>,
Jason Wang <jasowang@redhat.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH 0/7] AF_PACKET transport_offset fix
Date: Wed, 23 Jan 2019 09:12:43 -0500 [thread overview]
Message-ID: <CAF=yD-JkuTdHGGHs_kZsrP8R8FUtSXzLaLzWebZ75vwrYux-6g@mail.gmail.com> (raw)
In-Reply-To: <AM6PR05MB58795FBCEC44777DEDD5EB72D1990@AM6PR05MB5879.eurprd05.prod.outlook.com>
On Wed, Jan 23, 2019 at 5:19 AM Maxim Mikityanskiy <maximmi@mellanox.com> wrote:
>
> From my perspective, after the discussion we had with Willem, the
> current version of this series can be merged to net-next.
net-next has moved forward. The patchset as is no longer applies cleanly.
> Willem, do you approve it?
>
> Thanks for reviewing!
>
> > -----Original Message-----
> > From: Maxim Mikityanskiy
> > Sent: 14 January, 2019 15:19
> > To: David S. Miller <davem@davemloft.net>; Saeed Mahameed
> > <saeedm@mellanox.com>; Willem de Bruijn <willemb@google.com>; Jason Wang
> > <jasowang@redhat.com>; Eric Dumazet <edumazet@google.com>
> > Cc: netdev@vger.kernel.org; Eran Ben Elisha <eranbe@mellanox.com>; Tariq
> > Toukan <tariqt@mellanox.com>; Maxim Mikityanskiy <maximmi@mellanox.com>
> > Subject: [PATCH 0/7] AF_PACKET transport_offset fix
> >
> > This patch series contains the implementation of the RFC that was posted
> > on this mailing list previously:
> > https://www.spinics.net/lists/netdev/msg541709.html
> >
> > It fixes having incorrect skb->transport_header values in cases when
> > dissect fails. Having correct values set by the kernel fixes mlx5
> > operation and allows to remove some unnecessary code flows in mlx5.
> >
> > Maxim Mikityanskiy (7):
> > net: Don't set transport offset to invalid value
> > net: Introduce parse_protocol header_ops callback
> > net/ethernet: Add parse_protocol header_ops support
> > net/packet: Ask driver for protocol if not provided by user
> > net/packet: Remove redundant skb->protocol set
> > net/mlx5e: Remove the wrong assumption about transport offset
> > net/mlx5e: Trust kernel regarding transport offset
> >
> > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 15 ++---------
> > drivers/net/tap.c | 4 +--
> > drivers/net/tun.c | 4 +--
> > drivers/net/xen-netback/netback.c | 19 ++++++++------
> > include/linux/etherdevice.h | 1 +
> > include/linux/netdevice.h | 10 +++++++
> > include/linux/skbuff.h | 14 +++++-----
> > net/ethernet/eth.c | 13 ++++++++++
> > net/packet/af_packet.c | 26 +++++++++----------
> > 9 files changed, 60 insertions(+), 46 deletions(-)
> >
> > --
> > 2.19.1
>
prev parent reply other threads:[~2019-01-23 14:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 13:18 [PATCH 0/7] AF_PACKET transport_offset fix Maxim Mikityanskiy
2019-01-14 13:18 ` [PATCH 1/7] net: Don't set transport offset to invalid value Maxim Mikityanskiy
2019-01-14 16:49 ` Willem de Bruijn
2019-01-17 9:10 ` Maxim Mikityanskiy
2019-01-17 15:16 ` Willem de Bruijn
2019-01-23 10:16 ` Maxim Mikityanskiy
2019-01-23 14:11 ` Willem de Bruijn
2019-01-24 9:47 ` Maxim Mikityanskiy
2019-01-24 14:19 ` Willem de Bruijn
2019-01-14 13:18 ` [PATCH 2/7] net: Introduce parse_protocol header_ops callback Maxim Mikityanskiy
2019-01-14 13:19 ` [PATCH 3/7] net/ethernet: Add parse_protocol header_ops support Maxim Mikityanskiy
2019-01-23 14:14 ` Willem de Bruijn
2019-01-24 9:47 ` Maxim Mikityanskiy
2019-01-24 14:21 ` Willem de Bruijn
2019-01-25 8:51 ` Maxim Mikityanskiy
2019-01-25 13:52 ` Willem de Bruijn
2019-01-14 13:19 ` [PATCH 4/7] net/packet: Ask driver for protocol if not provided by user Maxim Mikityanskiy
2019-01-14 16:52 ` Willem de Bruijn
2019-01-15 16:32 ` Willem de Bruijn
2019-01-17 9:10 ` Maxim Mikityanskiy
2019-01-17 15:41 ` Willem de Bruijn
2019-01-14 13:19 ` [PATCH 5/7] net/packet: Remove redundant skb->protocol set Maxim Mikityanskiy
2019-01-14 13:19 ` [PATCH 6/7] net/mlx5e: Remove the wrong assumption about transport offset Maxim Mikityanskiy
2019-01-14 13:19 ` [PATCH 7/7] net/mlx5e: Trust kernel regarding " Maxim Mikityanskiy
2019-01-14 13:52 ` [PATCH 0/7] AF_PACKET transport_offset fix Maxim Mikityanskiy
2019-01-23 10:16 ` Maxim Mikityanskiy
2019-01-23 14:12 ` Willem de Bruijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF=yD-JkuTdHGGHs_kZsrP8R8FUtSXzLaLzWebZ75vwrYux-6g@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eranbe@mellanox.com \
--cc=jasowang@redhat.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.