From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36301C282C0 for ; Wed, 23 Jan 2019 14:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 015CE2184B for ; Wed, 23 Jan 2019 14:13:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y78oWL/9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726236AbfAWONW (ORCPT ); Wed, 23 Jan 2019 09:13:22 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:39546 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbfAWONV (ORCPT ); Wed, 23 Jan 2019 09:13:21 -0500 Received: by mail-ed1-f68.google.com with SMTP id b14so1804311edt.6 for ; Wed, 23 Jan 2019 06:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+3p6jTSMDVK0aR8nnTwCD7OMZLS5EKlcxsffCSSH/to=; b=Y78oWL/9ef3QqSXOpKsajpEfvUZ1tvAoud3r+oXtOF8pm+i7sibU4cSmhy8CnrdcQp JIebJJwbh/KtwEijlf9fFwlS1kyCKkX4kI3kV3nkwegi0p+JkeFS73NQAnWnhzE8Aaz+ VWcpheG0d4zjGk6ZhccO4cuIPlIX8nEPPquChc6/8nPx5y0iioznansFXxv1Yc9RsbQr 7RIGM+/tt6OQImMyPO59fb16dYGlGteCVXSRKu1WVuqRjKA3anV33jsuXetb3bz03dvh 4FjOl3Ca3t6ZKlY99rxgcXuQFqpHOBqsPVt+7DqNI9x7N5/C1ykiJAYUYu1+pptpUPPv dE5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+3p6jTSMDVK0aR8nnTwCD7OMZLS5EKlcxsffCSSH/to=; b=Xem2IHKu99w35Dx9xxgY4eO6wkQo+aeewPa2jd242oAWPAuYE3PSe5z0Ycz6gq12aB iB5qR8+r33l/+MeOk4sN7KGlvl/r4eu0QzHtArdKFxEx+3t8f4tmetSJ8KXRCoUeLVRB ZFk7HwG5HxvAJHG9EU5ciHyi4vXfOq5/lY3GszA0VvDroRjR6G/fFDN9ex/YzcTR7UCR eAPwdBMP/V0TJCX5W1ZEfc9U1AG+Eh2laVX+mg3lSOM8Aik1ExWytaWFPoAtoz3uUu0Z OVs11QrQm/BPUhf9SfmblvZGb7Adz3ywqKJImxBXqZTn/6sKCfnlIBMSq6ctLph61Rs1 Xoeg== X-Gm-Message-State: AJcUukc+Vir+8811vHk2e/AJXZvax/fjXLvomiFRtbtqx/yePWbdRHjt ryOEdAvdlI//mOrvmyVutkZsLhCTVxHToAvbZpJdAg== X-Google-Smtp-Source: ALg8bN5TUkbL2MigpdHoHxXV4qRRdFulDDKWb67o62H2YlWAeaUGEPRKGBsK14EgxZa5f1K6q6gltBMZtBGltabTQjc= X-Received: by 2002:a17:906:77c1:: with SMTP id m1-v6mr2476112ejn.233.1548252799685; Wed, 23 Jan 2019 06:13:19 -0800 (PST) MIME-Version: 1.0 References: <20190114131841.1932-1-maximmi@mellanox.com> In-Reply-To: From: Willem de Bruijn Date: Wed, 23 Jan 2019 09:12:43 -0500 Message-ID: Subject: Re: [PATCH 0/7] AF_PACKET transport_offset fix To: Maxim Mikityanskiy Cc: Willem de Bruijn , "David S. Miller" , "netdev@vger.kernel.org" , Saeed Mahameed , Eran Ben Elisha , Tariq Toukan , Jason Wang , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 23, 2019 at 5:19 AM Maxim Mikityanskiy wrote: > > From my perspective, after the discussion we had with Willem, the > current version of this series can be merged to net-next. net-next has moved forward. The patchset as is no longer applies cleanly. > Willem, do you approve it? > > Thanks for reviewing! > > > -----Original Message----- > > From: Maxim Mikityanskiy > > Sent: 14 January, 2019 15:19 > > To: David S. Miller ; Saeed Mahameed > > ; Willem de Bruijn ; Jason Wang > > ; Eric Dumazet > > Cc: netdev@vger.kernel.org; Eran Ben Elisha ; Tariq > > Toukan ; Maxim Mikityanskiy > > Subject: [PATCH 0/7] AF_PACKET transport_offset fix > > > > This patch series contains the implementation of the RFC that was posted > > on this mailing list previously: > > https://www.spinics.net/lists/netdev/msg541709.html > > > > It fixes having incorrect skb->transport_header values in cases when > > dissect fails. Having correct values set by the kernel fixes mlx5 > > operation and allows to remove some unnecessary code flows in mlx5. > > > > Maxim Mikityanskiy (7): > > net: Don't set transport offset to invalid value > > net: Introduce parse_protocol header_ops callback > > net/ethernet: Add parse_protocol header_ops support > > net/packet: Ask driver for protocol if not provided by user > > net/packet: Remove redundant skb->protocol set > > net/mlx5e: Remove the wrong assumption about transport offset > > net/mlx5e: Trust kernel regarding transport offset > > > > .../net/ethernet/mellanox/mlx5/core/en_tx.c | 15 ++--------- > > drivers/net/tap.c | 4 +-- > > drivers/net/tun.c | 4 +-- > > drivers/net/xen-netback/netback.c | 19 ++++++++------ > > include/linux/etherdevice.h | 1 + > > include/linux/netdevice.h | 10 +++++++ > > include/linux/skbuff.h | 14 +++++----- > > net/ethernet/eth.c | 13 ++++++++++ > > net/packet/af_packet.c | 26 +++++++++---------- > > 9 files changed, 60 insertions(+), 46 deletions(-) > > > > -- > > 2.19.1 >