From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B39AC43381 for ; Sat, 23 Mar 2019 16:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E782B20879 for ; Sat, 23 Mar 2019 16:04:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RtZ9wgpY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727693AbfCWQED (ORCPT ); Sat, 23 Mar 2019 12:04:03 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:37518 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727298AbfCWQED (ORCPT ); Sat, 23 Mar 2019 12:04:03 -0400 Received: by mail-ed1-f65.google.com with SMTP id v21so4141980edq.4 for ; Sat, 23 Mar 2019 09:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EVevKBW77O/fITVlIc9SrPVUW4l8Rn7dSbX/aL1JFCU=; b=RtZ9wgpYDb+XthIODw/u9E8N2SF+hQCazG7Lm6heGJIu/dYmJYoAn/4f9WLkmnpoYi 7XdPwtdbC58WaQ92dZosESsC7TwurMrth0tg8U+abB8+aVtCIQ79QI1smgGIN4dvXCHz J0PUIKL6zp0M56/U2UyO6ODg73vPd8LXkJzMzryO94ZHiD5orzRtBTctgBCvO8tlJe0B AUOuZqWrQPXN93QZ5G0mTehMWwB+1xUS2v+jdU7Msdb0ltjQeCMUXDQtyzwG8wZm0Flj adK4JJMBE/QyAO0qJVVWvR4jCJVwr19d/h+pv/7MPZtHFEBRsFoobXTsdjeDqhJmMyo+ Aahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EVevKBW77O/fITVlIc9SrPVUW4l8Rn7dSbX/aL1JFCU=; b=MrSxPAOnnDiv+fWBLoiWHg8xgq+Apjq9IvE7ljXdpqJ2T1CavyQThu/YEnHsuFjLRN 9PWqNPbfTwE98Mr2W/NZuFSc1aPBJanLBn2oeeApGsOnc6b2h2pdnEFTRhCUN8GG2Yh4 2N0p1TU1PSjp6HeVpNujGykTROEQPnYL1v01zcsT7M8YchBKoyrVfjexNCsa5yJjDJrl XDUvGPRMm9+1JLYjlVHq/Us0/V6vgKyx7DTqOUhouqlsMWmJcjIShiHqJeXv+/LiPI1u 5VMci+4AHZdCYWcL6CkH0byimd+nL2GupAeruljPeTaTGhXk37r1SIYb009uu2ZMMleQ uCyA== X-Gm-Message-State: APjAAAXwPypNQLyjtmx9DDknYMTKvN+NL+MEu0AuWbERBZaX9n8mZ9kx 6KtTDlZs/SV7z+nlQGfgKMzJ1eqzkg/CebmCiMFs8Gq5 X-Google-Smtp-Source: APXvYqzdcXJURRU/4m8YKH1tf+Xcx3RbWdlmVAuZgbcoUOTr/Ej8F177x3HpAnWMtgIEnDb4IItAlkOjnSl2aKKE3/Q= X-Received: by 2002:a17:906:c4f:: with SMTP id t15mr9073680ejf.132.1553357041468; Sat, 23 Mar 2019 09:04:01 -0700 (PDT) MIME-Version: 1.0 References: <20190322183300.196277-1-willemdebruijn.kernel@gmail.com> In-Reply-To: From: Willem de Bruijn Date: Sat, 23 Mar 2019 12:03:25 -0400 Message-ID: Subject: Re: [PATCH bpf-next v3 00/13] bpf tc tunneling To: Daniel Borkmann Cc: Network Development , Alexei Starovoitov , Stanislav Fomichev , Peter Oskolkov , Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 23, 2019 at 6:53 AM Daniel Borkmann wrote: > > Hey Willem, > > On 03/22/2019 07:32 PM, Willem de Bruijn wrote: > > From: Willem de Bruijn > > > > BPF allows for dynamic tunneling, choosing the tunnel destination and > > features on-demand. Extend bpf_skb_adjust_room to allow for efficient > > tunneling at the TC hooks. > > Patch 9 in this series caused the following warning, please take a look > for sending a follow-up fix, thanks. > > Report: > > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > branch HEAD: 7df5e3db8f6354125540dfa50affd2c02b7d2832 selftests: bpf: tc-bpf flow shaping with EDT > > Regressions in current branch: > > net/core/filter.c:3026:3: warning: 'mac_len' may be used uninitialized in this function [-Wmaybe-uninitialized] > net/core/filter.c:3027:3: warning: 'mac_len' may be used uninitialized in this function [-Wmaybe-uninitialized] That's surprising, sorry about that. Sent http://patchwork.ozlabs.org/patch/1062325/ .