From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D37EC282CB for ; Tue, 5 Feb 2019 20:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F04D12175B for ; Tue, 5 Feb 2019 20:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TYUpUfm9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729772AbfBEUTr (ORCPT ); Tue, 5 Feb 2019 15:19:47 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:37847 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729131AbfBEUTq (ORCPT ); Tue, 5 Feb 2019 15:19:46 -0500 Received: by mail-ed1-f68.google.com with SMTP id h15so4017506edb.4 for ; Tue, 05 Feb 2019 12:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xF6ucgAe6oTrVKDfCbsoxVY9btmo91JXS+8IsqCBfMU=; b=TYUpUfm9bqEzhJznwHOGC/CShQw0yq0JR+byrDSgjbLla1i/TavMtjsgg4YuLj6TlU fFXFZOU2C/RCjhG4ONg6dXyJU/bKwU5FiYb5uZx7G6R+3ch+vlTphu2Hv82UM5DkRnjX AIrVYI77rBxbk5gDpZMvTSVFNqnnlteU0O0Y3Iu5zYuGK/5TeZ2voejgSQUQnsQsMPT0 lNOJ3YlbkMJlewM5pHooZ6Dkog1Mb1E/fryEugsLsGA8sHVdbHgG+gpRUx22tzCO4KRu ErZUc/7gGfuBcnRUG53+9UW42Ri2EFazLONXJZJ7IPv6lwQpC3i+ogd6HQpmaBbkXK62 /epw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xF6ucgAe6oTrVKDfCbsoxVY9btmo91JXS+8IsqCBfMU=; b=KLVfcjxn821NdXzu7KaPd92ymWsWmnZnIQb/9xAbXBpTyG/o2ELvpTFiW7iBfmdo2S HpSTiUuosAZ0npBu0Mj7f4A1GETq4wakgkCEQpnLHk8U92oLt9K/uLsDeKmvOTD9HKNU iJMeNOtU87PV9S1ZuaghYZmRg9G3ZHJvEKmxsHOkmfgsimlVTNMWkir9+XdOAdp6MGrX q30KsGtYZj0WJ8Nas4xi3qybgDvGVrrw9qQCogITBVTatXNrSseqntuiWRI7AIZqhfA6 ExYXbV+1jcpnuCXujDg+QJxU9zD1Tatuym8Ky/bdQqji9L0AYcI3zr1qZYLtq7afyux/ MNNg== X-Gm-Message-State: AHQUAuatcNxKyEmDzQyNPinuYnpI7DNkitEyZzWFE4X8mlSn563n4KyW rjzvIAQiIWb9eW9gWh/Krai/sZksLir4sZni1Ik= X-Google-Smtp-Source: AHgI3IZajObpY8cZz7mNPpDA/Oj0OKjJ56IFw7ghz80gMzJYuOAgiCcn4ml7yIVqviCSrbh5ktEWyAB7dtiL2S7gmtI= X-Received: by 2002:a17:906:6cd:: with SMTP id v13mr4865451ejb.89.1549397985034; Tue, 05 Feb 2019 12:19:45 -0800 (PST) MIME-Version: 1.0 References: <20190205173629.160717-1-sdf@google.com> <20190205173629.160717-3-sdf@google.com> In-Reply-To: <20190205173629.160717-3-sdf@google.com> From: Willem de Bruijn Date: Tue, 5 Feb 2019 15:19:09 -0500 Message-ID: Subject: Re: [RFC bpf-next 2/7] net: introduce skb_net helper To: Stanislav Fomichev Cc: Network Development , David Miller , Alexei Starovoitov , Daniel Borkmann , simon.horman@netronome.com, Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 5, 2019 at 12:57 PM Stanislav Fomichev wrote: > > skb_net returns network namespace from the associated device or socket. > > This will be used in the next commit. > > Signed-off-by: Stanislav Fomichev > --- > include/linux/skbuff.h | 2 ++ > net/core/skbuff.c | 10 ++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > index ad883ab2762c..28723a86efdf 100644 > --- a/include/linux/skbuff.h > +++ b/include/linux/skbuff.h > @@ -4343,5 +4343,7 @@ static inline __wsum lco_csum(struct sk_buff *skb) > return csum_partial(l4_hdr, csum_start - l4_hdr, partial); > } > > +struct net *skb_net(const struct sk_buff *skb); > + > #endif /* __KERNEL__ */ > #endif /* _LINUX_SKBUFF_H */ > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index 23c9cf100bd4..016db13fa2b6 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -5585,6 +5585,16 @@ void skb_condense(struct sk_buff *skb) > skb->truesize = SKB_TRUESIZE(skb_end_offset(skb)); > } > > +struct net *skb_net(const struct sk_buff *skb) > +{ > + if (skb->dev) > + return dev_net(skb->dev); > + else if (skb->sk) > + return sock_net(skb->sk); > + return NULL; > +} > +EXPORT_SYMBOL(skb_net); If this needs a helper it is probably better static inline in the header.