All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	David Miller <davem@davemloft.net>
Subject: Re: [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment
Date: Mon, 7 May 2018 15:54:10 -0400	[thread overview]
Message-ID: <CAF=yD-KTkmx2jzGAeNVLGWmedCEBx8RQWjJBKZzERGCddEnKWw@mail.gmail.com> (raw)
In-Reply-To: <CAF=yD-JD=WCULdj_u0xjj3S9BDcbHhSCkWXCLHMx04U+Jgz55A@mail.gmail.com>

On Mon, May 7, 2018 at 2:57 PM, Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
> On Mon, May 7, 2018 at 2:08 PM, Alexander Duyck
> <alexander.duyck@gmail.com> wrote:
>> From: Alexander Duyck <alexander.h.duyck@intel.com>
>>
>> This patch allows us to take care of unrolling the first segment and the
>> last segment of the loop for processing the segmented skb. Part of the
>> motivation for this is that it makes it easier to process the fact that the
>> first fame and all of the frames in between should be mostly identical
>> in terms of header data, and the last frame has differences in the length
>> and partial checksum.
>>
>> In addition I am dropping the header length calculation since we don't
>> really need it for anything but the last frame and it can be easily
>> obtained by just pulling the data_len and offset of tail from the transport
>> header.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>
> I'm not a fan of the more complicated control flow, as I pointed out
> before. It only seems to save one assignment to uh from segs.
>
> Both follow-up patches are now more complex, because they need
> to add the same code in two locations.

With that said, if you feel strongly, I don't object.

The removal of hdrlen and simplification of arguments is definitely
an improvement.

  reply	other threads:[~2018-05-07 19:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 18:08 [net-next PATCH v3 0/6] Series short description Alexander Duyck
2018-05-07 18:08 ` [net-next PATCH v3 1/6] udp: Record gso_segs when supporting UDP segmentation offload Alexander Duyck
2018-05-07 18:08 ` [net-next PATCH v3 2/6] udp: Do not pass MSS as parameter to GSO segmentation Alexander Duyck
2018-05-07 18:08 ` [net-next PATCH v3 3/6] udp: Do not pass checksum as a " Alexander Duyck
2018-05-07 18:49   ` Willem de Bruijn
2018-05-07 18:08 ` [net-next PATCH v3 4/6] udp: Partially unroll handling of first segment and last segment Alexander Duyck
2018-05-07 18:27   ` Eric Dumazet
2018-05-07 18:57   ` Willem de Bruijn
2018-05-07 19:54     ` Willem de Bruijn [this message]
2018-05-07 19:59       ` Alexander Duyck
2018-05-07 20:10         ` Willem de Bruijn
2018-05-07 18:08 ` [net-next PATCH v3 5/6] udp: Add support for software checksum and GSO_PARTIAL with GSO offload Alexander Duyck
2018-05-07 18:43   ` Willem de Bruijn
2018-05-07 18:08 ` [net-next PATCH v3 6/6] udp: Do not copy destructor if one is not present Alexander Duyck
2018-05-07 18:25   ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF=yD-KTkmx2jzGAeNVLGWmedCEBx8RQWjJBKZzERGCddEnKWw@mail.gmail.com' \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.