From mboxrd@z Thu Jan 1 00:00:00 1970 From: Willem de Bruijn Subject: Re: [net-next PATCH v2 2/8] udp: Verify that pulling UDP header in GSO segmentation doesn't fail Date: Sat, 5 May 2018 10:12:15 +0200 Message-ID: References: <20180504182537.5194.72775.stgit@localhost.localdomain> <20180504182857.5194.45504.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Network Development , Willem de Bruijn , David Miller To: Alexander Duyck Return-path: Received: from mail-ua0-f170.google.com ([209.85.217.170]:32831 "EHLO mail-ua0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbeEEIM4 (ORCPT ); Sat, 5 May 2018 04:12:56 -0400 Received: by mail-ua0-f170.google.com with SMTP id i2so15512601uah.0 for ; Sat, 05 May 2018 01:12:56 -0700 (PDT) In-Reply-To: <20180504182857.5194.45504.stgit@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, May 4, 2018 at 8:29 PM, Alexander Duyck wrote: > From: Alexander Duyck > > We should verify that we can pull the UDP header before we attempt to do > so. Otherwise if this fails we have no way of knowing and GSO will not work > correctly. This already happened in the callers udp[46]_ufo_fragment