From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84304C282CB for ; Tue, 5 Feb 2019 20:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53CB52175B for ; Tue, 5 Feb 2019 20:20:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgG9xG1H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729846AbfBEUUb (ORCPT ); Tue, 5 Feb 2019 15:20:31 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:39450 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727280AbfBEUUb (ORCPT ); Tue, 5 Feb 2019 15:20:31 -0500 Received: by mail-ed1-f67.google.com with SMTP id b14so4008718edt.6 for ; Tue, 05 Feb 2019 12:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HgF4pr14Gf3CZLpPHjkki97Bv3ccIOcqrydC+8B2usY=; b=KgG9xG1H8FIYH92lsFjdXy3uat8vgk045yqyS9qUc5CbE5GBpjzDpNiUoA9JybCK6/ 0klZz60wECM0J9kiyoSk5FtpG5psrU/WLUu05qfGB2cYxY3vW+iccVtPbEsLUWiGxSdi cRx7Uq5T9zZfW+xycHlz819/t8Ctth/3NbWHOLkzBNEFV/noNQshe3gcV0EOg+a7ydaG wYtLsYZbcx0mkJ7EAnNdHLgDeBw18BPq6bkC4DkK5QPbggwUkoPgKe0MCnGaT9FffknZ IZym1OjwVvCOsS+QcZWP7lmKTFtfk2OGKlXoeCLy6VdYahsqyzNO+ej7SQhEwOBfdCbA quVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HgF4pr14Gf3CZLpPHjkki97Bv3ccIOcqrydC+8B2usY=; b=infXJjiuoaXJdTQ4ed8VN4teeys2yhbFEk5tYsB0lS0q0hLIeGgnM0nEomD1+kWvUx jZn4hF0tbDRlfI1CI1AvWv5+nAjoan+shhdlRhe2rNkwY5IkVC+GanlQARLRLP7cnYJH 3zxOfALvlt8aURPmubuXKpfoNgw8TkPGQwAAh57W7KmD1j2urW8JYD/3z+TCc1iW3hra zt9BTx3C+1qm62dE0mTuBFKAhP2tJV/7ojPMz/EuX2uS6cftb06dE4xF7vsKR6+bRK4X x8VB8zmpqohUNJblU648uTSfo4h/nc/uYrYf2WbHjWRB0If2sqSBFI4tcxbPJ/oPCIxz m8KQ== X-Gm-Message-State: AHQUAuaBgkwjTqha6VkcKvgowelUNTd9cuDgjUvBQ5bJVNp9gk+SD7uf Z3SuTPNNohxsh2uBEsvkcUYyq9oEU9U24D9eFdQ= X-Google-Smtp-Source: AHgI3Ib2i9FMcvct1E06NU9naCcvYZT4ylYzab/+ipoKNVGgi021ICBgBMxrlYcoOGlM++9OrzuToIIGpf4wY9yEKNs= X-Received: by 2002:a50:ca86:: with SMTP id x6mr5219320edh.287.1549398028898; Tue, 05 Feb 2019 12:20:28 -0800 (PST) MIME-Version: 1.0 References: <20190205173629.160717-1-sdf@google.com> <20190205173629.160717-6-sdf@google.com> In-Reply-To: <20190205173629.160717-6-sdf@google.com> From: Willem de Bruijn Date: Tue, 5 Feb 2019 15:19:52 -0500 Message-ID: Subject: Re: [RFC bpf-next 5/7] bpf: when doing BPF_PROG_TEST_RUN for flow dissector use no-skb mode To: Stanislav Fomichev Cc: Network Development , David Miller , Alexei Starovoitov , Daniel Borkmann , simon.horman@netronome.com, Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 5, 2019 at 12:58 PM Stanislav Fomichev wrote: > > Now that we have __flow_bpf_dissect which works on raw data (by > constructing temporary on-stack skb), use it when doing > BPF_PROG_TEST_RUN for flow dissector. > > This should help us catch any possible bugs due to missing shinfo on > the on-stack skb. > > Note that existing __skb_flow_bpf_dissect swallows L2 headers and returns > nhoff=0, we need to preserve the existing behavior. > > Signed-off-by: Stanislav Fomichev > --- > net/bpf/test_run.c | 52 +++++++++++++++------------------------------- > 1 file changed, 17 insertions(+), 35 deletions(-) > > ret = bpf_test_finish(kattr, uattr, &flow_keys, sizeof(flow_keys), > retval, duration); > - > - kfree_skb(skb); > - kfree(sk); > + kfree(data); > return ret; > + nit: unnecessary whitespace line > }