From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95D8FC282CC for ; Tue, 5 Feb 2019 20:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 561642073D for ; Tue, 5 Feb 2019 20:18:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZceuxZ+H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729736AbfBEUSu (ORCPT ); Tue, 5 Feb 2019 15:18:50 -0500 Received: from mail-ed1-f48.google.com ([209.85.208.48]:32859 "EHLO mail-ed1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726547AbfBEUSt (ORCPT ); Tue, 5 Feb 2019 15:18:49 -0500 Received: by mail-ed1-f48.google.com with SMTP id p6so4052075eds.0 for ; Tue, 05 Feb 2019 12:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=87Xyl33B4gZbTwoZWTSaoqRa+IW53tdzjKK5jzr1D44=; b=ZceuxZ+HLroWtuSIBswVs9qiswEGDAoEL1bqV6EGZ7aB3n+ENmrbY4yXDy+DYvxMtX GFi1vYxpi/YffHGTrY4ZoXZeqgKMwqbu+sCoW6X1c7B2uJgCGh3qH85SEL73PfE820Wm WJN+X911o/05d2a9dtmNJ3aLFByQ2F/UVdljoeOys8dK8SF97Fi5vQFWKW6DYxbeLcKi 7S523Q+jVtqDGP505wUhJA+yMHbrldZiHY6PXd3vZIwyq21kCtntN6dh+O+9HcrzKODr WJzhIfGKXKdOjLz9/PVP4yKLlhDGveBg3JoigpH6++ydfT96rZJ1K4r6MjyvvdljbwQ9 58Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=87Xyl33B4gZbTwoZWTSaoqRa+IW53tdzjKK5jzr1D44=; b=IyQjW2VYcT0KJKKd2/zRzx1RPPaOnVSoTmkwE+jKNflpioRBg2pR+eUrce9pyN6HAw jQZemUSlmrdmOBf6BTTyiWUIopcJEN/P1uzUsG8ejue6VfPnR2OCS7qO5tx5+EW41Q2C +ynX4yiX3CVM5eodWO7x9nX92t0Q2pSTiYcBenPdSxC9MPmUr7q0YklAwQUs7lh/lIc4 WlxKpZtKUjhCga4TnKl8+pA+DIKMZWxO5tKuKlr7T37dq+QRIP1qIW/T6FPM5EBZo+UN v+aq24Pz0wYeuzzbHCzc1aXPq4TSQ6GsVIM+dTNJXgL1O684fBlHsq6I3YZV4kMGYx9P lEjA== X-Gm-Message-State: AHQUAuZhqSHoR/bUVOcgdHBmfuysNXjw1MZZ+7gdfggzYy1b52w0Nt0o OCqNdOtXX+lAQQNm4GKzyLrpif9hXcZVp+0pN7I= X-Google-Smtp-Source: AHgI3IaxcXtuaVUckOCGMPROXvffLsNk9CLhceocco4AIuQBAjrK5rykKQEGkHgTFGIsWavO57RKgqXOOBm+98rUCRM= X-Received: by 2002:a50:8bcd:: with SMTP id n13mr4450319edn.260.1549397928274; Tue, 05 Feb 2019 12:18:48 -0800 (PST) MIME-Version: 1.0 References: <20190205173629.160717-1-sdf@google.com> <20190205173629.160717-2-sdf@google.com> In-Reply-To: <20190205173629.160717-2-sdf@google.com> From: Willem de Bruijn Date: Tue, 5 Feb 2019 15:18:12 -0500 Message-ID: Subject: Re: [RFC bpf-next 1/7] net: introduce __init_skb and __init_skb_shinfo helpers To: Stanislav Fomichev Cc: Network Development , David Miller , Alexei Starovoitov , Daniel Borkmann , simon.horman@netronome.com, Willem de Bruijn Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 5, 2019 at 12:57 PM Stanislav Fomichev wrote: > > __init_skb is essentially a version of __build_skb which accepts skb as > an argument (instead of doing kmem_cache_alloc to allocate it). > > __init_skb_shinfo initializes shinfo. > > No functional changes. > > Signed-off-by: Stanislav Fomichev Nice code deduplication :-)