All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@linaro.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] syscalls/tgkill01: add new test
Date: Fri, 15 Mar 2019 15:18:33 +0530	[thread overview]
Message-ID: <CAFA6WYM7FnqMVoWLMc1oOAS=xDYDnF6L8k+8Sg0STPYqrt+tjg@mail.gmail.com> (raw)
In-Reply-To: <20190314140400.GB2536@rei.lan>

On Thu, 14 Mar 2019 at 19:34, Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> > +static void run(void)
> > +{
> > +     int i;
> > +
> > +     for (i = 0; i < n_threads; i++)
> > +             threads[i].tid = -1;
> > +
> > +     test_running = 1;
> > +     for (i = 0; i < n_threads; i++)
> > +             start_thread(&threads[i]);
>
> Just a minor nit these threads should actully be started in the test
> setup() since we stop them in the test cleanup(), otherwise the test
> breaks with the looping -i option.
>

Makes sense, will fix it.

-Sumit

> --
> Cyril Hrubis
> chrubis@suse.cz

  reply	other threads:[~2019-03-15  9:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07  7:28 [LTP] [PATCH 0/3] syscalls: add tgkill test-cases Sumit Garg
2019-03-07  7:28 ` [LTP] [PATCH 1/3] syscalls/tgkill01: add new test Sumit Garg
2019-03-12 13:29   ` Li Wang
2019-03-12 13:49     ` Sumit Garg
2019-03-14 14:04   ` Cyril Hrubis
2019-03-15  9:48     ` Sumit Garg [this message]
2019-03-07  7:28 ` [LTP] [PATCH 2/3] syscalls/tgkill02: " Sumit Garg
2019-03-07  7:28 ` [LTP] [PATCH 3/3] syscalls/tgkill03: " Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFA6WYM7FnqMVoWLMc1oOAS=xDYDnF6L8k+8Sg0STPYqrt+tjg@mail.gmail.com' \
    --to=sumit.garg@linaro.org \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.