From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26D6AC636CD for ; Tue, 7 Feb 2023 10:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hzg92hSiVIZgNZwdzMjrORYIZFS4zYOCcm5wdKeyarI=; b=zkngTeOsIyu7Az IMMicm1VJxZmQCN6bZOj/ySN0R8Tx81jBb5BA1/D/2oO1se/ehjdshGSFcsbxaPMSPJnYnWHo2Oh0 LAhiVcOH9o667CO5TK/E6r9XtR5ns98KHvFYKPaxq8xfNicJ2urKOJ/qFflG3mQeZR8Hjkn2a18qN DHeXavqbpI1sZDKIC33Tq/Mj3z0G1095w5u7x1zoQlnmTDUJomY0BvHz7K4AIW8BtHmWaH3SehZvD 0hzRm8PQKJ5A7At0Y0EscQiECK6eFYmWXBqqyQYbkR03zQ29H4rwIXlsfvPz6TH07SxSjGMYCjzV3 D+PVK53MJieNYHbt016g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKlc-00BcN6-RE; Tue, 07 Feb 2023 10:00:00 +0000 Received: from mail-vs1-xe2d.google.com ([2607:f8b0:4864:20::e2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pPKlZ-00BcLt-TA for linux-arm-kernel@lists.infradead.org; Tue, 07 Feb 2023 09:59:59 +0000 Received: by mail-vs1-xe2d.google.com with SMTP id cz15so6046039vsb.6 for ; Tue, 07 Feb 2023 01:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=imMOAypeeJYion5hiSp9RS8CiVWyB5tI9arDNTtrtKE=; b=bxlHnoNqIlciOE1JCTm3MVDeUCQ+odxGZ9WUWJmVI02GC/nrDypx5EbtOjqqTjFeP+ OaYYotHLLLcEUUU0zn4eJQlcTTxj+3GeMa8HStWgjuOscbbeBkX438oZkJHMVhkor3fz +yWuy1/03Fr1cocf8172yQ0d6lBkb3OS/41a169ayFXaLwRvW7DLpbugozVWcAOzMxu3 +T9at9SRa49QwPFNuagAC1m5FynhbXO+T1cMcSQCL23yV1Qj5CPk1LJm+yhqGAQFSaBh qUkbKXMcgpgRSAgklisXAyjEdosnQoz2XnHTupuDWQmgQu++3U6gpodu0j3rNwqZulJ9 ssEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=imMOAypeeJYion5hiSp9RS8CiVWyB5tI9arDNTtrtKE=; b=ZwnUsakW51VrUv7OxUhzr0Zg9/HCFXygiEBSHzhk42B1yf1Or5a/K3D4THVNRoJpFV QmAYlPsnGFc9FvU3kfw6ymrklhb2Sw+DIEbis7zr1q3TT5DJROAKV8OKXOfhQeTGSaTl A+jl3jiWjHLQdluXzUyllPmBk9rcBK3LWEpfooKhNVzXQ586TJ9fOEC8Kav5L7Wh/+S8 rItQKHVc2q3qud0dXvPvP3klo57QhSTSXSy2jtLJ/jvWByQNVZqRbYmqvBpFzsRbTGZz RE8zfuwVaRA8CRdHOboSb5N+7WbhQ6s0/6HEgUwkH1jaQz1bREZ20yuyKyJ7LN0Zfeot AjIQ== X-Gm-Message-State: AO0yUKWNzNdWW109lI/mNJGjZ3hS6F/RFQnZSVZ1HMvcCCSDDCUuSMPE lOtUoBJ0zHXG9zw09vzHfHGymtsFcJogu+MNwWz2Bw== X-Google-Smtp-Source: AK7set9AvG0RtYsCd6ghvSYyXvZviioTJXnritNJvTa/2hxC/SJhSUn3k0EhwLpsHjprFQ0tHspCjAwoEsweFK2gU5c= X-Received: by 2002:a67:cd87:0:b0:411:9ff1:9747 with SMTP id r7-20020a67cd87000000b004119ff19747mr334794vsl.62.1675763996156; Tue, 07 Feb 2023 01:59:56 -0800 (PST) MIME-Version: 1.0 References: <20230130094157.1082712-1-etienne.carriere@linaro.org> <20230130094157.1082712-2-etienne.carriere@linaro.org> In-Reply-To: <20230130094157.1082712-2-etienne.carriere@linaro.org> From: Sumit Garg Date: Tue, 7 Feb 2023 15:29:44 +0530 Message-ID: Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander , Sudeep Holla , Cristian Marussi X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230207_015957_963558_7F5CD236 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 30 Jan 2023 at 15:12, Etienne Carriere wrote: > > Changes SCMI optee transport to enable sys_service capability of > its tee context to leverage provisioned system resources in OP-TEE > preventing possible deadlock. > > Such deadlock could happen when many Linux clients invoke OP-TEE are > are all suspended waiting for an OP-TEE RPC request access an SCMI > resource through the SCMI OP-TEE PTA service. > > Signed-off-by: Etienne Carriere > --- > drivers/firmware/arm_scmi/optee.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > index 2a7aeab40e54..91840345e946 100644 > --- a/drivers/firmware/arm_scmi/optee.c > +++ b/drivers/firmware/arm_scmi/optee.c > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > if (IS_ERR(tee_ctx)) > return -ENODEV; > > + /* SCMI agent can used TEE system service resources */ > + tee_ctx->sys_service = true; > + As per the other thread for patch #1, this feature will only be available with OP-TEE supporting TEE_GEN_CAP_REG_MEM. Can we add a corresponding conditional check here? -Sumit > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > if (!agent) { > ret = -ENOMEM; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0B6C636CC for ; Tue, 7 Feb 2023 10:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231910AbjBGKBB (ORCPT ); Tue, 7 Feb 2023 05:01:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231744AbjBGKAd (ORCPT ); Tue, 7 Feb 2023 05:00:33 -0500 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 094C8A4 for ; Tue, 7 Feb 2023 01:59:57 -0800 (PST) Received: by mail-vs1-xe35.google.com with SMTP id m1so13818453vst.7 for ; Tue, 07 Feb 2023 01:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=imMOAypeeJYion5hiSp9RS8CiVWyB5tI9arDNTtrtKE=; b=bxlHnoNqIlciOE1JCTm3MVDeUCQ+odxGZ9WUWJmVI02GC/nrDypx5EbtOjqqTjFeP+ OaYYotHLLLcEUUU0zn4eJQlcTTxj+3GeMa8HStWgjuOscbbeBkX438oZkJHMVhkor3fz +yWuy1/03Fr1cocf8172yQ0d6lBkb3OS/41a169ayFXaLwRvW7DLpbugozVWcAOzMxu3 +T9at9SRa49QwPFNuagAC1m5FynhbXO+T1cMcSQCL23yV1Qj5CPk1LJm+yhqGAQFSaBh qUkbKXMcgpgRSAgklisXAyjEdosnQoz2XnHTupuDWQmgQu++3U6gpodu0j3rNwqZulJ9 ssEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=imMOAypeeJYion5hiSp9RS8CiVWyB5tI9arDNTtrtKE=; b=e7gElUgoseiNLioGOIC5l9xAeksYaZeOiXk2WvM7W/S+WxzMnOhnKHbnlKnhU45+NI uZYs7d8PmVcj8dXUekcWRhzaJoRFjG7swRPousFtny7RUzCinm4eyRy/toEiDjVDmN4q n3pEeOLi5KPiOlbsR1JzGAasHYdzrwasQtiZW6sGXVOvgj2KA9yHDFDALPSDu+yMzKpO i2SUJo773fsnbUJf+S4hGEwiJU8TKwfld0l9aOPfHb7NV8rPNzTfZ8sLY2J+5fnNG7zs G9Us8AzgTAmy6SKroLjazSNyd6R5v1FoH2zuvl9rJbegSgFv0b/H9Onh+wHRi3Fj8+Iy qjng== X-Gm-Message-State: AO0yUKVmkgslA5RlFAp+/1mDJPA5carLmqWtfC1aA0lQRNNl8HLs7pB8 LgTJxgeX5PxXzeP7TQZciJtfEJAY/W1iU56RSqvDVBbU04nj6/xK X-Google-Smtp-Source: AK7set9AvG0RtYsCd6ghvSYyXvZviioTJXnritNJvTa/2hxC/SJhSUn3k0EhwLpsHjprFQ0tHspCjAwoEsweFK2gU5c= X-Received: by 2002:a67:cd87:0:b0:411:9ff1:9747 with SMTP id r7-20020a67cd87000000b004119ff19747mr334794vsl.62.1675763996156; Tue, 07 Feb 2023 01:59:56 -0800 (PST) MIME-Version: 1.0 References: <20230130094157.1082712-1-etienne.carriere@linaro.org> <20230130094157.1082712-2-etienne.carriere@linaro.org> In-Reply-To: <20230130094157.1082712-2-etienne.carriere@linaro.org> From: Sumit Garg Date: Tue, 7 Feb 2023 15:29:44 +0530 Message-ID: Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander , Sudeep Holla , Cristian Marussi Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jan 2023 at 15:12, Etienne Carriere wrote: > > Changes SCMI optee transport to enable sys_service capability of > its tee context to leverage provisioned system resources in OP-TEE > preventing possible deadlock. > > Such deadlock could happen when many Linux clients invoke OP-TEE are > are all suspended waiting for an OP-TEE RPC request access an SCMI > resource through the SCMI OP-TEE PTA service. > > Signed-off-by: Etienne Carriere > --- > drivers/firmware/arm_scmi/optee.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > index 2a7aeab40e54..91840345e946 100644 > --- a/drivers/firmware/arm_scmi/optee.c > +++ b/drivers/firmware/arm_scmi/optee.c > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > if (IS_ERR(tee_ctx)) > return -ENODEV; > > + /* SCMI agent can used TEE system service resources */ > + tee_ctx->sys_service = true; > + As per the other thread for patch #1, this feature will only be available with OP-TEE supporting TEE_GEN_CAP_REG_MEM. Can we add a corresponding conditional check here? -Sumit > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > if (!agent) { > ret = -ENOMEM; > -- > 2.25.1 >