From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34250C4338F for ; Thu, 29 Jul 2021 07:10:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12CE261077 for ; Thu, 29 Jul 2021 07:10:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234493AbhG2HKu (ORCPT ); Thu, 29 Jul 2021 03:10:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234448AbhG2HKs (ORCPT ); Thu, 29 Jul 2021 03:10:48 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 998B2C061757 for ; Thu, 29 Jul 2021 00:10:45 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id f18so9058873lfu.10 for ; Thu, 29 Jul 2021 00:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MoFw2S044+a87aIj+7FPIutyeW+kh1qZwjiCXtSKMLE=; b=e7KXs8ysXeshruLJUbQ2J+1tDH0JsuB/m95qY8LS9996gmbNKFNcX8L5dS9QsbTQQU ztxFZoyWEzTP6DkEQO3pcnbQqg17LB3CBuUMGWu+Hvwe6D7XdUJd0yiQvUuPXaCvYysW P9ciOF2WV1M7iuGUcUyzODsOKBoSHWv2ZeLgaoAd8BIx0cWgpS5ypwsWv44Cc6TrA17m wu9E+WHxwUCTRYc+23FQvvrL+zEWAANddxP3te427ncMlAF6S/H0oeDhBYUtn+E2Uu98 SNU62XTt9CBYkQCxjWuUQyz0Ld5s2a0WZa2cLHkXlNWuHisB/lInD9JzIi5oQxdEfFcS l3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MoFw2S044+a87aIj+7FPIutyeW+kh1qZwjiCXtSKMLE=; b=kk3rYLTNIWGGM8F7Vb/uShs1RrbHU0oH0WRUjEq/qD05E2FNP0YlctUc2B98U3vXq5 VTkq5567v4vvz55yJmtipoeq9rS9AF2CQGey5qq1iLbaFRxS50Oe+OrOVzxVqeyYouw5 KtUt/63Zsoic3P3uavdEyfveAsDOMD4dwINO7xzFks48IYYrXycgHJejEV0SCipI+avO jps6t0iUl7BFYZTXbQMCZZzsjqF7H1qBgA5Ia0lJAFg/oI5UolIo7/6A+i7KS3lCAMu1 /g0ltd27hZPU93adgMOs9uLslzxJJNmN3amzK5dUZ7PJvRJGoQyvekGyKfumuPZwqO5x Os+A== X-Gm-Message-State: AOAM531sD4SdF8wFeRKhM+F2pEEKXkjm5QqO6T25e9tP3HhGOLo2jdjp ma6PRN2s57nYL+LTAz6qwh45oriWfJRwbmF/zFLvHg== X-Google-Smtp-Source: ABdhPJwUcHHIbN9tpoHWa1g8Yf70sfTpSypy31K0iy9ajc6mvUdEsW0U+ZvCHV6P/AYwdz502O+bj+QubUZYq+SzFrw= X-Received: by 2002:a05:6512:511:: with SMTP id o17mr2695176lfb.396.1627542644007; Thu, 29 Jul 2021 00:10:44 -0700 (PDT) MIME-Version: 1.0 References: <20210722121757.1944658-1-jens.wiklander@linaro.org> <20210722121757.1944658-3-jens.wiklander@linaro.org> <20210729064359.GA3316601@jade> In-Reply-To: <20210729064359.GA3316601@jade> From: Sumit Garg Date: Thu, 29 Jul 2021 12:40:32 +0530 Message-ID: Subject: Re: [PATCH v3 2/5] optee: simplify optee_release() To: Jens Wiklander Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Sudeep Holla , Marc Bonnici , Jerome Forissier , Sughosh Ganu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jul 2021 at 12:14, Jens Wiklander wrote: > > On Wed, Jul 28, 2021 at 02:15:47PM +0530, Sumit Garg wrote: > > On Thu, 22 Jul 2021 at 17:48, Jens Wiklander wrote: > > > > > > Simplifies optee_release() with a new helper function, > > > optee_close_session_helper() which has been factored out from > > > optee_close_session(). > > > > > > > Simplification looks good to me. > > > > > A separate optee_release_supp() is added for the supplicant device. > > > > > > > On similar terms, can we have separate optee_open_supp() for better > > understanding? > > I'm not so keen on that. It wouldn't be much of a simplification since > we'd end up adding quite a few functions. optee_smc_open_supp(), > optee_ffa_open_supp(), optee_open_common(), and finally > optee_open_supp(). > Fair enough, FWIW: Reviewed-by: Sumit Garg -Sumit > Thanks, > Jens From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03603C4338F for ; Thu, 29 Jul 2021 07:12:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C13B460E09 for ; Thu, 29 Jul 2021 07:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C13B460E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xnBWaDBtIrRZJZNuk5yimLgYZV354lWtGFR0ZdbbeXc=; b=A9AYFUO2CwJC16 3K+0dA03qK3+C6Qg1TczZFLAxnBxil5Vysp7Wtl4K965sHdW/v0bugbj2+cLiQS4ib6PkcEYfJsfb xPZrCTPTDmZHyD3Ol+C8d6/W2zM9rCqAKmUR80nE4SYsQiC4rp7MOULoZDbQfRuMmbkRo2nBu1/NQ 1sKvEECBNfkxrLkQ8+Swd2js2DuTp926sOn8MxlU8dGMOPlZX7/oPQLSeF4bkiGPFjvwS/4BXgEFD z0j5vCOOhGcP5oU3O/BB1yUMo+S3RDKV+UzF/jUpo+jCyFrB20llvAPmfK0bXGXIKItSxMdrB2fvy vANBAVtyW0l4jrEb1a7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m90Bt-003LD6-2p; Thu, 29 Jul 2021 07:10:49 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m90Bp-003LCM-S5 for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 07:10:47 +0000 Received: by mail-lf1-x12a.google.com with SMTP id d17so9192658lfv.0 for ; Thu, 29 Jul 2021 00:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MoFw2S044+a87aIj+7FPIutyeW+kh1qZwjiCXtSKMLE=; b=e7KXs8ysXeshruLJUbQ2J+1tDH0JsuB/m95qY8LS9996gmbNKFNcX8L5dS9QsbTQQU ztxFZoyWEzTP6DkEQO3pcnbQqg17LB3CBuUMGWu+Hvwe6D7XdUJd0yiQvUuPXaCvYysW P9ciOF2WV1M7iuGUcUyzODsOKBoSHWv2ZeLgaoAd8BIx0cWgpS5ypwsWv44Cc6TrA17m wu9E+WHxwUCTRYc+23FQvvrL+zEWAANddxP3te427ncMlAF6S/H0oeDhBYUtn+E2Uu98 SNU62XTt9CBYkQCxjWuUQyz0Ld5s2a0WZa2cLHkXlNWuHisB/lInD9JzIi5oQxdEfFcS l3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MoFw2S044+a87aIj+7FPIutyeW+kh1qZwjiCXtSKMLE=; b=GPok6o4YYZPAJ4Vitaz6F/2+T2VqNEcwnidqmXAdLUiU1jSkXpjVUvIjKPyL+tgRno 66XEQk0BDUlqrEu8S6JwcmwvlD9zs7r5C6WomHVCAAg2OhiuvzSoIL5rZ+oTuXnB+Snv NKxFN9IjSzJVB/kqogG64SlZOcxM/yTNKeaWTRPOL+Fnp32FtVSON9vnGMw3tFaTFe4E 3WqNf0bGPMepTjoWHGysQe2K0RDGWllgy5x5z1Sj5lZS+tCcTV2iu/G6WyldSY8Zm+V7 mcdHAyOgR6BGpkvH3cMpIrI5EY2uo4i/cg6WY/pirXe0dhQ1Rk0cK1+2ElNsoP1cSXDx beaw== X-Gm-Message-State: AOAM530Z0/cJwbfFx2SXSWQ3LG/1FXBb39DtjIiRMCQwoa8KXAtNio+x A5jDif7jjtTcZasdTuwjkxzjbU1jg3Z5P2hhFCHTAA== X-Google-Smtp-Source: ABdhPJwUcHHIbN9tpoHWa1g8Yf70sfTpSypy31K0iy9ajc6mvUdEsW0U+ZvCHV6P/AYwdz502O+bj+QubUZYq+SzFrw= X-Received: by 2002:a05:6512:511:: with SMTP id o17mr2695176lfb.396.1627542644007; Thu, 29 Jul 2021 00:10:44 -0700 (PDT) MIME-Version: 1.0 References: <20210722121757.1944658-1-jens.wiklander@linaro.org> <20210722121757.1944658-3-jens.wiklander@linaro.org> <20210729064359.GA3316601@jade> In-Reply-To: <20210729064359.GA3316601@jade> From: Sumit Garg Date: Thu, 29 Jul 2021 12:40:32 +0530 Message-ID: Subject: Re: [PATCH v3 2/5] optee: simplify optee_release() To: Jens Wiklander Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Sudeep Holla , Marc Bonnici , Jerome Forissier , Sughosh Ganu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_001045_977265_C5B813DE X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jul 2021 at 12:14, Jens Wiklander wrote: > > On Wed, Jul 28, 2021 at 02:15:47PM +0530, Sumit Garg wrote: > > On Thu, 22 Jul 2021 at 17:48, Jens Wiklander wrote: > > > > > > Simplifies optee_release() with a new helper function, > > > optee_close_session_helper() which has been factored out from > > > optee_close_session(). > > > > > > > Simplification looks good to me. > > > > > A separate optee_release_supp() is added for the supplicant device. > > > > > > > On similar terms, can we have separate optee_open_supp() for better > > understanding? > > I'm not so keen on that. It wouldn't be much of a simplification since > we'd end up adding quite a few functions. optee_smc_open_supp(), > optee_ffa_open_supp(), optee_open_common(), and finally > optee_open_supp(). > Fair enough, FWIW: Reviewed-by: Sumit Garg -Sumit > Thanks, > Jens _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel