From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1023C43334 for ; Fri, 15 Jul 2022 10:24:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7253083666; Fri, 15 Jul 2022 12:24:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="f0JS/GKw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B0B583AD1; Fri, 15 Jul 2022 12:24:33 +0200 (CEST) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E3AF883660 for ; Fri, 15 Jul 2022 12:24:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sumit.garg@linaro.org Received: by mail-pf1-x435.google.com with SMTP id 70so4326454pfx.1 for ; Fri, 15 Jul 2022 03:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XyPBXSwwT5mAJv9G3wBJS1zeJStmWALsNI3iCAOLxDc=; b=f0JS/GKwG5Ikz2iO/IKCkaE8G3LhcOal8p3FVeZU7MUt6/5vA6G8iaa0eoKJemBaZL L4okQyhfAPhkIV79mhcX8YHLk1TdviMP+eeqyDyXzpbWJhURu2JzHDUMa9Do0XMdC8jq E0ESmkPzWQ7NpXXCURQ5rQ1qho6S6CAxZg5VMvE/EykTykGQcSThrtBCKMbQ5t+AU6Sn b2xdFaXvkhoIRLLebWA+qfEHQctWPN7LXs960a0Xe2aOa1gwvD6WJIUFmFm6Aj8ItnWr rxL0KN2wc/5TCgR9xnLLD/jSpI0A2T+De756gfu3g5IgvHxaaLdbEcBwABiV28Jop3rw TVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XyPBXSwwT5mAJv9G3wBJS1zeJStmWALsNI3iCAOLxDc=; b=aXqjqDvTENLRDvzDznyQZ7/WfgSPXywmyUisezJ3npjghHWL8IQfDIOW38x6dhNfpg /xnrbNkb7sfttca/cyUAhrA8shETULrhPNmYftkuGiQPZiswOuNPhLA00JfeyvZ7jHPI dvSLO+ytct7umc4kTMjnAboOZX7O1P/tCqt7LN/GKj/yew/D0ISCcv4XiWR39HPUXZLN z99dlabdGGMOUZsrWrMyWNhEX1N3QogUpPuvCH2ZavGboivQvsS7XahmezThfWZAbefy Qo6SNF+ZB+Z2iDwOI1A5E3TH2cFBEGXF+9dI97efUcHI4phzr16f+Ukc43X++OhM4Pty OvXw== X-Gm-Message-State: AJIora8r4Z8NgAFFfzJoMa+6EGA6dKe+YSeHo30BNMZ3WsUwyn7R5h+Z wAjrcxL6JC865z77tTK3NpT/6ifMbRRkIdwdDMXKrQ== X-Google-Smtp-Source: AGRyM1sohJHh9FcH/EjwC7/znVlYQ/hkWOubvWHRCVWzXhsatQ+rnvdue/Gu3UsmreoMGeZnL16W54WuZb4o6Stp75s= X-Received: by 2002:a63:5c42:0:b0:412:b2e9:97e4 with SMTP id n2-20020a635c42000000b00412b2e997e4mr12141908pgm.36.1657880668137; Fri, 15 Jul 2022 03:24:28 -0700 (PDT) MIME-Version: 1.0 References: <20220712071212.2188390-1-sumit.garg@linaro.org> <20220712071212.2188390-10-sumit.garg@linaro.org> In-Reply-To: From: Sumit Garg Date: Fri, 15 Jul 2022 15:54:17 +0530 Message-ID: Subject: Re: [PATCH v3 9/9] board: qualcomm: Add support for QCS404 EVB To: Stephan Gerhold Cc: u-boot@lists.denx.de, rfried.dev@gmail.com, peng.fan@nxp.com, jh80.chung@samsung.com, sjg@chromium.org, trini@konsulko.com, dsankouski@gmail.com, vinod.koul@linaro.org, nicolas.dechesne@linaro.org, mworsfold@impinj.com, daniel.thompson@linaro.org, pbrobinson@gmail.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thu, 14 Jul 2022 at 23:57, Stephan Gerhold wrote: > > On Thu, Jul 14, 2022 at 01:10:45PM +0530, Sumit Garg wrote: > > On Thu, 14 Jul 2022 at 01:02, Stephan Gerhold wrote: > > > Can you check how hard it would be to reuse the upstream QCS404 DT? > > > > > > > It turned out to be patch [1] on top of this patch-set. Please help me > > to test it on boards you have access to. > > > > [1] https://patchwork.ozlabs.org/project/uboot/patch/20220714073337.2298978-1-sumit.garg@linaro.org/ > > > > Thanks! Do you happen to have time to check the other custom bindings in > SDM845 as well? I see two other differences there in addition to the > pinctrl: > > 1. "qcom,msm-geni-uart": Linux has an additional "qcom,geni-se-qup" > node around that. > Yeah that is for a wrapper serial engine driver around UART, SPI, I2C, I3C, etc. Text from "drivers/soc/qcom/qcom-geni-se.c": /** * DOC: Software description * * GENI SE Wrapper driver is structured into 2 parts: * * geni_wrapper represents QUP Wrapper controller. This part of the driver * manages QUP Wrapper information such as hardware version, clock * performance table that is common to all the internal serial engines. * * geni_se represents serial engine. This part of the driver manages serial * engine information such as clocks, containing QUP Wrapper, etc. This part * of driver also supports operations (eg. initialize the concerned serial * engine, select between FIFO and DMA mode of operation etc.) that are * common to all the serial engines and are independent of serial interfaces. */ I am unsure if there really exists a use-case for that in u-boot but I guess we should be able to add a dummy driver just to satisfy the upstream Linux kernel DT binding. > 2. The "qcom,pm8998-pwrkey" should be in an additional > "qcom,pm8998-pon" container node and then called > "qcom,pm8941-pwrkey". > > Also, in U-Boot the keys are modelled as GPIOs which is a bit > strange (I don't think they can be set to output mode for example). > But it might be fine to keep that in the -u-boot.dtsi part for now. > Okay, I will try to look at these as follow up patches. > I would be happy to investigate and test the remaining DB410c-specific > parts (e.g. USB there). Cleaning up the DT differences has been on my > TODO list for quite some time but I never got to it, sadly... > No worries, it's a community effort which often takes a backseat on the TODO list. -Sumit > Thanks! > Stephan