All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@linaro.org>
To: ltp@lists.linux.it
Subject: [LTP] check_sync_file_range()
Date: Fri, 22 Mar 2019 10:12:18 +0530	[thread overview]
Message-ID: <CAFA6WYO5V9TaDvgNxSEHcq75KbsrUWf_OezqcY4oLq02akM0CQ@mail.gmail.com> (raw)
In-Reply-To: <2A02D5B5-F67F-43C4-BABA-B0C7EFF6C9F5@linaro.org>

Hi Rafael,

On Thu, 21 Mar 2019 at 01:34, Rafael David Tinoco
<rafael.tinoco@linaro.org> wrote:
>
> I believe check_sync_file_range() logic, from commit c0dc8876fb1486ee85f6dd43e36ec5b3d9d9a4ed, should use a different names since glibc seems to be implementing the syscall wrapper in recent versions and a conflict exists for me at least:
>
> gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -Wold-style-definition -D_FORTIFY_SOURCE=2 -I../../../../include -I../../../../include -I../../../../include/old/   -L../../../../lib  sync_file_range02.c   -lltp -o sync_file_range02
> In file included from sync_file_range02.c:21:
> ../../../../include/lapi/sync_file_range.h:24:20: error: conflicting types for ‘sync_file_range’
>  static inline long sync_file_range(int fd, off64_t offset, off64_t nbytes,
>                     ^~~~~~~~~~~~~~~
> In file included from /usr/include/x86_64-linux-gnu/bits/fcntl.h:61,
>                  from /usr/include/fcntl.h:35,
>                  from ../../../../include/tst_safe_macros.h:27,
>                  from ../../../../include/tst_test.h:90,
>                  from sync_file_range02.c:20:
> /usr/include/x86_64-linux-gnu/bits/fcntl-linux.h:397:12: note: previous declaration of ‘sync_file_range’ was here
>  extern int sync_file_range (int __fd, __off64_t __offset, __off64_t __count,
>             ^~~~~~~~~~~~~~~
>

Did you ran configure check before building the test-case? Actually
the commit you referred to adds functionality to use glibc syscall
wrapper if present or else fallback to api defined in
include/lapi/sync_file_range.h.

See: "m4/ltp-sync_file_range.m4", "configure.ac" for configure check.

-Sumit

  reply	other threads:[~2019-03-22  4:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 20:04 [LTP] check_sync_file_range() Rafael David Tinoco
2019-03-22  4:42 ` Sumit Garg [this message]
2019-03-22  9:25   ` Rafael Tinoco

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFA6WYO5V9TaDvgNxSEHcq75KbsrUWf_OezqcY4oLq02akM0CQ@mail.gmail.com \
    --to=sumit.garg@linaro.org \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.