All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sumit Garg" <sumit.garg@linaro.org>
To: Denys Dmytriyenko <denis@denix.org>
Cc: meta-arm@lists.yoctoproject.org, Denys Dmytriyenko <denys@ti.com>
Subject: Re: [meta-arm] [PATCH v3 5/5] tcmode-external-arm: fixup headers location in external toolchain SDK
Date: Tue, 23 Jun 2020 20:24:03 +0530	[thread overview]
Message-ID: <CAFA6WYOARUfMH-VNv00HupdyBfAiA=6g0-if1kgWvP+u8ah4_w@mail.gmail.com> (raw)
In-Reply-To: <1592526937-38479-6-git-send-email-denis@denix.org>

On Fri, 19 Jun 2020 at 06:06, Denys Dmytriyenko <denis@denix.org> wrote:
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> External toolchain compiler searches for some headers relative to the binary
> and regardless of the --sysroot value. Since headers are installed inside
> SDKTARGETSYSROOT, but the binary is inside SDKPATHNATIVE, symlink include
> directories between those two.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  .../conf/distro/include/tcmode-external-arm.inc               | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>

We can drop this hack once we package headers as part of
gcc-cross-canadian-${TRANSLATED_TARGET_ARCH} as well. For details,
refer to my comment on patch #4.

-Sumit

> diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> index 7d5aecc..2f101fc 100644
> --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> @@ -117,3 +117,14 @@ def populate_toolchain_links(d):
>              bb.fatal("Unable to populate toolchain binary symlink for %s: %s" % (newpath, exc))
>
>  require conf/distro/include/external-arm-toolchain-versions.inc
> +
> +SDK_POSTPROCESS_COMMAND_prepend = "external_arm_sdk_fixup; "
> +
> +external_arm_sdk_fixup () {
> +       tcpath="${SDK_OUTPUT}/${SDKPATHNATIVE}${prefix_nativesdk}/${EAT_TARGET_SYS}"
> +       if [ -d $tcpath ]; then
> +               pushd $tcpath
> +               ln -s ${SDKTARGETSYSROOT}/include include
> +               popd
> +       fi
> +}
> --
> 2.7.4
>
> 

      reply	other threads:[~2020-06-23 14:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19  0:35 [PATCH v3 0/5] external-arm-toolchain: Add prebuilt SDK support Denys Dmytriyenko
2020-06-19  0:35 ` [PATCH v3 1/5] external-arm-toolchain-versions: also collect binutils/bfd version Denys Dmytriyenko
2020-06-23 11:38   ` [meta-arm] " Sumit Garg
2020-08-14 13:44     ` Ross Burton
2020-08-14 14:02       ` Sumit Garg
2020-06-19  0:35 ` [PATCH v3 2/4] external-arm-toolchain-versions: set per-component toolchain licenses Denys Dmytriyenko
2020-06-23 11:39   ` [meta-arm] " Sumit Garg
2020-06-19  0:35 ` [PATCH v3 3/5] external-arm-toolchain: check for TCLIBC being glibc Denys Dmytriyenko
2020-06-23 11:42   ` [meta-arm] " Sumit Garg
2020-06-19  0:35 ` [PATCH v3 4/5] external-arm-sdk-toolchain: add recipe to package gcc/gdb/binutils cross binaries Denys Dmytriyenko
2020-06-23 14:50   ` [meta-arm] " Sumit Garg
2020-06-30  1:20     ` Denys Dmytriyenko
2020-06-19  0:35 ` [PATCH v3 5/5] tcmode-external-arm: fixup headers location in external toolchain SDK Denys Dmytriyenko
2020-06-23 14:54   ` Sumit Garg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFA6WYOARUfMH-VNv00HupdyBfAiA=6g0-if1kgWvP+u8ah4_w@mail.gmail.com' \
    --to=sumit.garg@linaro.org \
    --cc=denis@denix.org \
    --cc=denys@ti.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.