From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sumit Garg Date: Tue, 02 Jun 2020 08:52:37 +0000 Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> <20200602071407.GB16602@linux.intel.com> In-Reply-To: <20200602071407.GB16602@linux.intel.com> To: Jarkko Sakkinen Cc: "tee-dev @ lists . linaro . org" , Daniel Thompson , op-tee@lists.trustedfirmware.org, Jonathan Corbet , James Bottomley , Janne Karhunen , Linux Doc Mailing List , James Morris , Mimi Zohar , Linux Kernel Mailing List , dhowells@redhat.com, linux-security-module@vger.kernel.org, "open list:ASYMMETRIC KEYS" , Markus Wamser , Casey Schaufler , linux-integrity@vger.kernel.org, Jens Wiklander , linux-arm-kernel , "Serge E. Hallyn" On Tue, 2 Jun 2020 at 12:44, Jarkko Sakkinen wrote: > > On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > > > > The whole idea to have it dynamic was to have a common trusted keys > > module which could support both TPM and TEE implementation depending > > on hardware. I guess it may be useful in scenarios where a particular > > hardware supports a TPM chip while other doesn't but both need to run > > a common kernel image. > > For now it should only scale to what is needed. No problems refining > it later when there is something to enable. > Fair enough, will switch to compile time mode then. -Sumit > /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B641C433E1 for ; Tue, 2 Jun 2020 08:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C3D0206A2 for ; Tue, 2 Jun 2020 08:40:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DaRRRUXP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726580AbgFBIkv (ORCPT ); Tue, 2 Jun 2020 04:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgFBIku (ORCPT ); Tue, 2 Jun 2020 04:40:50 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 722E9C05BD43 for ; Tue, 2 Jun 2020 01:40:50 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id z9so892335ljh.13 for ; Tue, 02 Jun 2020 01:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ba7tS1EJd6J4rrFJlCgFQCMg5mXZk8lm0TUhKeqkFLg=; b=DaRRRUXPe+h4lT7HKYjlwOZPLtpKjj5wrJfc7A/FfABHr7pqA6sBVcDxFpYhyNGX2f mhQciVg9mJcl5lbwYvIUHYTLOz+H/JseFNTfhgEH1PUTCmGJfi2vmR2tmRbnXSyFTDE4 w4eCcHJwLE+Jelj9ifdDTlnu0lIKZx10kGWKP+LOH+aLlwER7WRXA5g20mnYOxnaNwWm 3M56FsBpyAAfxXgbKJti+9pbhLY8t86m4/VdbDv6kUVoyahF+iMYkTHJDo4u8M+83rUy MafhdMblZid34Foa6n+p2WuWVyEuwMjkPZdBGHlFOS0Ezjf8cSGe7D1etislzBDLC4++ g6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ba7tS1EJd6J4rrFJlCgFQCMg5mXZk8lm0TUhKeqkFLg=; b=h32XOkQSU8CnOQPzxDtW0s1706DyPliawd28/UnW1b4x3CN6C1ZRYkk5gHiGcrOVf+ JVKZe8kR1MP49oT/liYCZMSyLsUdOn3Y3EUlJs2QW9wTKQo9VsbROeQKGglkdGQkdhI8 PbnBF8XFhLKsQgBjSfC7Ry//qu6tYdkt/Zw3CjnU6zQidIC+J1f8Nee3DFLgrWyc41qN lypXhB7Ujpmbe336gUjdP8n3bUbjm/w4cvM6CZmaRKO6L5x2lOPp2EWKgUAiKvcv73Y7 eCeLH2z1Qx8peWNooK9C0aGTMZhzgQ7EgC1zFVTlfTLcL8q6R+Z7Pz2z5o/+TCG0R+Fu pgeA== X-Gm-Message-State: AOAM530pKORmaNay+PO4xExWN4gcR8rcbAJSim8ADTWpKORc2KQj3N/Z rA5KPW4qdgwuzQrBMGJPm/yY2Ak1vMHLCPLIzgVo6A== X-Google-Smtp-Source: ABdhPJxsrkSYKmMolrGDzGBzVUCmpV4Czal5MWGq3rA63F0c5cGNbbd8XSdXd5KOBCD+j1AK6KQkyAzoPLSK90Osl+U= X-Received: by 2002:a2e:81c5:: with SMTP id s5mr11803430ljg.372.1591087248899; Tue, 02 Jun 2020 01:40:48 -0700 (PDT) MIME-Version: 1.0 References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> <20200602071407.GB16602@linux.intel.com> In-Reply-To: <20200602071407.GB16602@linux.intel.com> From: Sumit Garg Date: Tue, 2 Jun 2020 14:10:37 +0530 Message-ID: Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework To: Jarkko Sakkinen Cc: Mimi Zohar , James Bottomley , dhowells@redhat.com, Jens Wiklander , Jonathan Corbet , James Morris , "Serge E. Hallyn" , Casey Schaufler , Janne Karhunen , Daniel Thompson , Markus Wamser , "open list:ASYMMETRIC KEYS" , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Linux Doc Mailing List , Linux Kernel Mailing List , linux-arm-kernel , op-tee@lists.trustedfirmware.org, "tee-dev @ lists . linaro . org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Jun 2020 at 12:44, Jarkko Sakkinen wrote: > > On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > > > > The whole idea to have it dynamic was to have a common trusted keys > > module which could support both TPM and TEE implementation depending > > on hardware. I guess it may be useful in scenarios where a particular > > hardware supports a TPM chip while other doesn't but both need to run > > a common kernel image. > > For now it should only scale to what is needed. No problems refining > it later when there is something to enable. > Fair enough, will switch to compile time mode then. -Sumit > /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731CAC433E0 for ; Tue, 2 Jun 2020 08:40:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C02720734 for ; Tue, 2 Jun 2020 08:40:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PtHMKR56"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DaRRRUXP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C02720734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=epXjDDyqavjtwHwDufiKn/76yYIj0zByCMGeGLKpOqI=; b=PtHMKR563+cUb9 xy0hpEVHWT9iIQ2dG4Cwp70uS4It3JG9LCH8xtpNtz2KsGjY8jshtLqz3S+IS1qKVX4AYkKg5fIyQ 4HMimRCoqPGgcBLxHq11qwb8yU8c9rcoi2F9dZQOttg31a072vQcgY0KKzTA0jjHfYqlSEbvDTw2g SlLJj0DWtTSmFU5N9nZ3/PwNWVgfpTpzwqufcPGFBx8DHmoxdc0CPEKEIkVJaONMPDcpa/b9FfxIs i/la6JQSEfSosQJTTk0eat+C+ddk+gUqpnhddWAtv8P9tlE9kGy2yvxrXUWN/5ffgbQry42K0cfM1 JRh7vCBc1X/On1R1tbWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg2Tc-0000WA-Us; Tue, 02 Jun 2020 08:40:52 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg2Ta-0000Vk-KB for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2020 08:40:51 +0000 Received: by mail-lj1-x241.google.com with SMTP id e4so11568669ljn.4 for ; Tue, 02 Jun 2020 01:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ba7tS1EJd6J4rrFJlCgFQCMg5mXZk8lm0TUhKeqkFLg=; b=DaRRRUXPe+h4lT7HKYjlwOZPLtpKjj5wrJfc7A/FfABHr7pqA6sBVcDxFpYhyNGX2f mhQciVg9mJcl5lbwYvIUHYTLOz+H/JseFNTfhgEH1PUTCmGJfi2vmR2tmRbnXSyFTDE4 w4eCcHJwLE+Jelj9ifdDTlnu0lIKZx10kGWKP+LOH+aLlwER7WRXA5g20mnYOxnaNwWm 3M56FsBpyAAfxXgbKJti+9pbhLY8t86m4/VdbDv6kUVoyahF+iMYkTHJDo4u8M+83rUy MafhdMblZid34Foa6n+p2WuWVyEuwMjkPZdBGHlFOS0Ezjf8cSGe7D1etislzBDLC4++ g6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ba7tS1EJd6J4rrFJlCgFQCMg5mXZk8lm0TUhKeqkFLg=; b=WpaInxyI4qHvBRA/AKoy5ESPDqRsusj5puyY0VHjHNI9Hbsj8G8IcHi+rHBwCErlvM 1SWuKQz8iGv29dBVhi/luINAuBHDGyztsuJs7CwdBOIrHNywF6TdQa19jR2GCITDZ2T+ qb6YPwCWQ5UJoBKue9j9VMuTBf8eEuAVS5X4Dfaw69QQzq4oI8ocgGHMqNiR0T0154Kw c0cznhQ6MKRQm/4cs+CXu6e5HF6VX2wpoOWH+RxCFAsUO//f4ijAKnWcAWu0cPQZCDpK l9L+EgeHA1j5Og0xPnRkVubrhmI3jS/wtaq9R/B9MdbXtzvcNRZ1s4rYkfY4UeFWB+R2 tcxA== X-Gm-Message-State: AOAM530T15H0QC21vkfYsh7WsQW7UjCrndSZHwB+ecB3YKQ15C+knjme 7BnmqkFfxOgTNPas3AjPnP6zHScAYO/j7ttQxpUtKw== X-Google-Smtp-Source: ABdhPJxsrkSYKmMolrGDzGBzVUCmpV4Czal5MWGq3rA63F0c5cGNbbd8XSdXd5KOBCD+j1AK6KQkyAzoPLSK90Osl+U= X-Received: by 2002:a2e:81c5:: with SMTP id s5mr11803430ljg.372.1591087248899; Tue, 02 Jun 2020 01:40:48 -0700 (PDT) MIME-Version: 1.0 References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> <20200602071407.GB16602@linux.intel.com> In-Reply-To: <20200602071407.GB16602@linux.intel.com> From: Sumit Garg Date: Tue, 2 Jun 2020 14:10:37 +0530 Message-ID: Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework To: Jarkko Sakkinen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_014050_664870_37D99112 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "tee-dev @ lists . linaro . org" , Daniel Thompson , op-tee@lists.trustedfirmware.org, Jonathan Corbet , James Bottomley , Janne Karhunen , Linux Doc Mailing List , James Morris , Mimi Zohar , Linux Kernel Mailing List , dhowells@redhat.com, linux-security-module@vger.kernel.org, "open list:ASYMMETRIC KEYS" , Markus Wamser , Casey Schaufler , linux-integrity@vger.kernel.org, Jens Wiklander , linux-arm-kernel , "Serge E. Hallyn" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2 Jun 2020 at 12:44, Jarkko Sakkinen wrote: > > On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > > > > The whole idea to have it dynamic was to have a common trusted keys > > module which could support both TPM and TEE implementation depending > > on hardware. I guess it may be useful in scenarios where a particular > > hardware supports a TPM chip while other doesn't but both need to run > > a common kernel image. > > For now it should only scale to what is needed. No problems refining > it later when there is something to enable. > Fair enough, will switch to compile time mode then. -Sumit > /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel