From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B859C433F5 for ; Wed, 13 Oct 2021 07:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 698F761027 for ; Wed, 13 Oct 2021 07:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238334AbhJMHMO (ORCPT ); Wed, 13 Oct 2021 03:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238371AbhJMHMH (ORCPT ); Wed, 13 Oct 2021 03:12:07 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8598DC061749 for ; Wed, 13 Oct 2021 00:10:04 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id u21so4207118lff.8 for ; Wed, 13 Oct 2021 00:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ogqZy3TAy6+qEHHl5cPKz54lxH4LD6O0Wc/FhOwWDsM=; b=CzXcO5tKFJUXWn4Q/+y2U8lDHv+2ksgjTxS0YhMwS18A8SagcBSfSzyDxu8luezXnR f4HGyqKMJiunW2SOGnVjO8Y0MFVpRzZzUCIAzdKgemhd6cKMaiQnwBCtSX0irmCCVbyO MJK4FWv3Qt1anRb3JTqnJRyK6gJX9w+J3CN+a8X6KXThrRONCAJ255acu5EYgxin2tYR U9CbjHag6jGRHfb32SZ4+lk/vaV3N/ckSvHWy/FSNnMy/Iu40zCE/0tx3rhBfIFLN6Xs lkdx1XMDPj3veTwSq4hmxx18NFewaTa10VxfikTAhZJts+0vU2XrZBlxBig3eB7U3nnu 6iNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ogqZy3TAy6+qEHHl5cPKz54lxH4LD6O0Wc/FhOwWDsM=; b=do+q5HY415MVDswyfZNNq3k8hanXhKERZ+6zCIv+d43pq5EZyN3cmVQ8UfQ0du0Bx2 hIsd+niIzHFoPlooiUX+JD700x2fWxLMvKZuc0XZ3dXtjl+R9PBGNQGj8kMFj4A8zDDj Le9S6NbVLjPYja/vRCUDT0qwR23yNheAGlD4niQlv/ljNrQezeTbXjWahaKN8Vh3/e3G RqQOwwDSZm8m7IUcXCdQ5uQfswPjqbDTAC9q1JR2GPmakHQcXIfyg+qfPZUn0kk7UeF+ QuH73gsnSW8tSfSOywVQkudRjP9+NLMgdmSxMEKCPJwYev20wB/64P7uC+41Mb7awljM wm3w== X-Gm-Message-State: AOAM530wMZPZQWeyZPshJzfkWYdfK5wqnKaMMdE5TGkoapeUsR6tOPF7 E2jRz7h6xWJldjO/zov9U02bAqSCQdZXFtQp0+3k7w== X-Google-Smtp-Source: ABdhPJzvXXAHtBA7ebI/i+rhF0WnBhxKgLdOphK36gqOInuyLSlVAJfRZbbODuQKKsAd+la0o9tvW3AmYpYVWwgjsOs= X-Received: by 2002:a2e:bd0b:: with SMTP id n11mr33501152ljq.71.1634109002881; Wed, 13 Oct 2021 00:10:02 -0700 (PDT) MIME-Version: 1.0 References: <20211006071546.2540920-1-jens.wiklander@linaro.org> <20211006071546.2540920-5-jens.wiklander@linaro.org> In-Reply-To: <20211006071546.2540920-5-jens.wiklander@linaro.org> From: Sumit Garg Date: Wed, 13 Oct 2021 12:39:51 +0530 Message-ID: Subject: Re: [PATCH v6 4/6] tee: export teedev_open() and teedev_close_context() To: Jens Wiklander Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Devicetree List , Linux Doc Mailing List , Jerome Forissier , Etienne Carriere , Vincent Guittot , Rob Herring , Jonathan Corbet , Ard Biesheuvel , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Oct 2021 at 12:46, Jens Wiklander wrote: > > Exports the two functions teedev_open() and teedev_close_context() in > order to make it easier to create a driver internal struct tee_context. > > Signed-off-by: Jens Wiklander > --- > drivers/tee/tee_core.c | 6 ++++-- > include/linux/tee_drv.h | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 85102d12d716..3fc426dad2df 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -43,7 +43,7 @@ static DEFINE_SPINLOCK(driver_lock); > static struct class *tee_class; > static dev_t tee_devt; > > -static struct tee_context *teedev_open(struct tee_device *teedev) > +struct tee_context *teedev_open(struct tee_device *teedev) > { > int rc; > struct tee_context *ctx; > @@ -70,6 +70,7 @@ static struct tee_context *teedev_open(struct tee_device *teedev) > return ERR_PTR(rc); > > } > +EXPORT_SYMBOL_GPL(teedev_open); > > void teedev_ctx_get(struct tee_context *ctx) > { > @@ -96,13 +97,14 @@ void teedev_ctx_put(struct tee_context *ctx) > kref_put(&ctx->refcount, teedev_ctx_release); > } > > -static void teedev_close_context(struct tee_context *ctx) > +void teedev_close_context(struct tee_context *ctx) > { > struct tee_device *teedev = ctx->teedev; > > teedev_ctx_put(ctx); > tee_device_put(teedev); > } > +EXPORT_SYMBOL_GPL(teedev_close_context); > > static int tee_open(struct inode *inode, struct file *filp) > { > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 3ebfea0781f1..26f42c4cd7a1 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -582,4 +582,18 @@ struct tee_client_driver { > #define to_tee_client_driver(d) \ > container_of(d, struct tee_client_driver, driver) > > +/** > + * teedev_open() - Open a struct tee_device > + * @teedev: Device to open > + * > + * @return a pointer to struct tee_context on success or an ERR_PTR on failure. > + */ > +struct tee_context *teedev_open(struct tee_device *teedev); > + > +/** > + * teedev_close_context() - closes a struct tee_context > + * @ctx: The struct tee_context to close > + */ > +void teedev_close_context(struct tee_context *ctx); > + > #endif /*__TEE_DRV_H*/ > -- > 2.31.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB853C433EF for ; Wed, 13 Oct 2021 08:41:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CD8461027 for ; Wed, 13 Oct 2021 08:41:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8CD8461027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WC0Maqzmx1xvHEcDryLrwQsRgJc/Lhkm+vdmXbYtEag=; b=l1ToGMg+GjftHZ Q1UpwP2GJt7bYzEJwakHn4AgkEVKG8gXF3Z2WjItLoEGekPxI6b5e9jf/FoAZGUBQV9wy1RjhXWKE stX/VVZvao0tXRQGyVziAmasMK/jU6p0IjkyhIeE+Q+OZ4B8i9OcVSSpMZtbim7yW5NeBKHIf/ZB+ j6RH67eBpUDuePWqhXqNBo/jUwFuYLlbgT2TTCN+Ro3Fqk3GguTxQ0lM41MCR/pqsQ12yGwVo04Tm Pq+wojA2X9uJguDuf919kzZxhFp5jPwmk7YsMcmpKZTIEiNHG/4bJxW6RgiXZiGZmf9eeZvuajS7I h/TMPM9Kjnotg4U/dcrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maZmR-00Fbdv-3e; Wed, 13 Oct 2021 08:38:35 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maYOq-00FHYZ-Nb for linux-arm-kernel@lists.infradead.org; Wed, 13 Oct 2021 07:10:06 +0000 Received: by mail-lf1-x12a.google.com with SMTP id j21so7706637lfe.0 for ; Wed, 13 Oct 2021 00:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ogqZy3TAy6+qEHHl5cPKz54lxH4LD6O0Wc/FhOwWDsM=; b=CzXcO5tKFJUXWn4Q/+y2U8lDHv+2ksgjTxS0YhMwS18A8SagcBSfSzyDxu8luezXnR f4HGyqKMJiunW2SOGnVjO8Y0MFVpRzZzUCIAzdKgemhd6cKMaiQnwBCtSX0irmCCVbyO MJK4FWv3Qt1anRb3JTqnJRyK6gJX9w+J3CN+a8X6KXThrRONCAJ255acu5EYgxin2tYR U9CbjHag6jGRHfb32SZ4+lk/vaV3N/ckSvHWy/FSNnMy/Iu40zCE/0tx3rhBfIFLN6Xs lkdx1XMDPj3veTwSq4hmxx18NFewaTa10VxfikTAhZJts+0vU2XrZBlxBig3eB7U3nnu 6iNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ogqZy3TAy6+qEHHl5cPKz54lxH4LD6O0Wc/FhOwWDsM=; b=VMfbLdg1n5EKyYe6O/+ouZ7Z1Gcd45L+AdVMewjJXWlJw0+bIkd2n1aEqZMOm6dW4p xd0CxwLYs4ay74yRzYTL9CTpR41wvpr4W3WO8DuJNOCIsJfU/sp4d1S7K6YLquQNjx5i pM2pd4s0pCjZnWK/j3DMnE3qByqqsQ8OEb+OSl71xWyP7X5oq84Ib5yICLWOs3t9nhse iouzthUUfJVtn3AesDQ75jVR6Aq0z8tDMCFB5UgAyFNW2LnrfxSHHnGxyaJCAeujIq9Z 2gphDO6E0WplKumoHuCgF8GctJdkw3BFjNQm+b0hXfyjjaYjOCPNvbKyCeSJDW9bpCK5 YO4Q== X-Gm-Message-State: AOAM530JHdDQXSWMhn3X6ENyqzvtzjQ6q8C/SBW+GnTOzHKj3NFGEstN Jh8lKqkj4FFaWqgWRUVNaUN2MAzKscf5rZYs55O8cBEpu0fTfKan X-Google-Smtp-Source: ABdhPJzvXXAHtBA7ebI/i+rhF0WnBhxKgLdOphK36gqOInuyLSlVAJfRZbbODuQKKsAd+la0o9tvW3AmYpYVWwgjsOs= X-Received: by 2002:a2e:bd0b:: with SMTP id n11mr33501152ljq.71.1634109002881; Wed, 13 Oct 2021 00:10:02 -0700 (PDT) MIME-Version: 1.0 References: <20211006071546.2540920-1-jens.wiklander@linaro.org> <20211006071546.2540920-5-jens.wiklander@linaro.org> In-Reply-To: <20211006071546.2540920-5-jens.wiklander@linaro.org> From: Sumit Garg Date: Wed, 13 Oct 2021 12:39:51 +0530 Message-ID: Subject: Re: [PATCH v6 4/6] tee: export teedev_open() and teedev_close_context() To: Jens Wiklander Cc: Linux Kernel Mailing List , linux-arm-kernel , OP-TEE TrustedFirmware , Devicetree List , Linux Doc Mailing List , Jerome Forissier , Etienne Carriere , Vincent Guittot , Rob Herring , Jonathan Corbet , Ard Biesheuvel , Marc Zyngier X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211013_001004_867487_0C289095 X-CRM114-Status: GOOD ( 21.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 6 Oct 2021 at 12:46, Jens Wiklander wrote: > > Exports the two functions teedev_open() and teedev_close_context() in > order to make it easier to create a driver internal struct tee_context. > > Signed-off-by: Jens Wiklander > --- > drivers/tee/tee_core.c | 6 ++++-- > include/linux/tee_drv.h | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 85102d12d716..3fc426dad2df 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -43,7 +43,7 @@ static DEFINE_SPINLOCK(driver_lock); > static struct class *tee_class; > static dev_t tee_devt; > > -static struct tee_context *teedev_open(struct tee_device *teedev) > +struct tee_context *teedev_open(struct tee_device *teedev) > { > int rc; > struct tee_context *ctx; > @@ -70,6 +70,7 @@ static struct tee_context *teedev_open(struct tee_device *teedev) > return ERR_PTR(rc); > > } > +EXPORT_SYMBOL_GPL(teedev_open); > > void teedev_ctx_get(struct tee_context *ctx) > { > @@ -96,13 +97,14 @@ void teedev_ctx_put(struct tee_context *ctx) > kref_put(&ctx->refcount, teedev_ctx_release); > } > > -static void teedev_close_context(struct tee_context *ctx) > +void teedev_close_context(struct tee_context *ctx) > { > struct tee_device *teedev = ctx->teedev; > > teedev_ctx_put(ctx); > tee_device_put(teedev); > } > +EXPORT_SYMBOL_GPL(teedev_close_context); > > static int tee_open(struct inode *inode, struct file *filp) > { > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 3ebfea0781f1..26f42c4cd7a1 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -582,4 +582,18 @@ struct tee_client_driver { > #define to_tee_client_driver(d) \ > container_of(d, struct tee_client_driver, driver) > > +/** > + * teedev_open() - Open a struct tee_device > + * @teedev: Device to open > + * > + * @return a pointer to struct tee_context on success or an ERR_PTR on failure. > + */ > +struct tee_context *teedev_open(struct tee_device *teedev); > + > +/** > + * teedev_close_context() - closes a struct tee_context > + * @ctx: The struct tee_context to close > + */ > +void teedev_close_context(struct tee_context *ctx); > + > #endif /*__TEE_DRV_H*/ > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel