From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 060E3C43334 for ; Thu, 14 Jul 2022 07:41:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C9DD68402C; Thu, 14 Jul 2022 09:41:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="cuP9HRnM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C1B0F8402C; Thu, 14 Jul 2022 09:41:01 +0200 (CEST) Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B2451839C3 for ; Thu, 14 Jul 2022 09:40:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sumit.garg@linaro.org Received: by mail-pj1-x1034.google.com with SMTP id o31-20020a17090a0a2200b001ef7bd037bbso2126771pjo.0 for ; Thu, 14 Jul 2022 00:40:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T/519nmYK4xbPl7vJ7U5b1+fcRU19Gvv4GdTQcAceAI=; b=cuP9HRnMLpVG4XgGyG0g/9pXxVyCXe6b+Rgy0d7z4b3oo1wIs1IvwvUH0IYLlduJjy 67vXMG0z1xT1GX2k+RCQqpvi7DuGsAoeV8APtyr10xi1Ol90qC/XyJXI5iUrzEwvtsbS mg9n3C9GFLgSNRs8NvajLXP8vo0PBB75Z7Zb+XI8wAnmL8y5h7FT5UaMmXTjM/vRsVsz jGN4CpNk6Kuam5obKZ9s525LQeuIkjdFkjJcRFf8pLZZ4u7y0BQQEh30PuUc3OENpMeP FKQecc/7FqB8qv6dSCY90HhD+t2gjp3S/ONeWmlaqrOkv28ruJppHTr/u5vMDBGbz3An 7Kbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T/519nmYK4xbPl7vJ7U5b1+fcRU19Gvv4GdTQcAceAI=; b=YaA4qrbTReCcLUFv7IEPoBQfE6EaXofv7gfWmvlrOYE5tIGYUL6YEkdFceN+I3wAZb scx28C9munIwREtMk6/nP5j7Vmsowxc5X5urMoYAIuQwrx43T/x8I+MqsRWUOQZVa8jz k0VsUORpJ03IGvKx/73s5aVg2KtlhgHD2Msola5P+HQZJ5368beJ3Px8bGtQ8sgyARhU XVr95usGNX64ksM4yEP4Iork7V6tG2R0p7GN7ADHK2e+zHbihWD1ILXCInV+87oJqbqx WSABBbmfT5jUBHJGCCfeiY8ZYwUzBfxrgFGnaODqr6EGYiyX2TNi9MOgNxJZ6iYT55ss HhRg== X-Gm-Message-State: AJIora9WN17bayXzhQ/nSc5M5FHY0CH/u7D2mr5YoGMM5jPY6igQPh2G Ynkj0AN6WNliaCgtZLHJHzQEg6oGpeqbCnmhzV45Uw== X-Google-Smtp-Source: AGRyM1tNpwwgbGsnAlcScI19ep3du5Xg3AaFXz7iq/zEzYro1z3qAAiKHzItecbLMyfv2vXEnCZoHba7FVTQXysknDI= X-Received: by 2002:a17:903:189:b0:16c:39b2:c217 with SMTP id z9-20020a170903018900b0016c39b2c217mr7678235plg.113.1657784455825; Thu, 14 Jul 2022 00:40:55 -0700 (PDT) MIME-Version: 1.0 References: <20220712071212.2188390-1-sumit.garg@linaro.org> <20220712071212.2188390-10-sumit.garg@linaro.org> In-Reply-To: From: Sumit Garg Date: Thu, 14 Jul 2022 13:10:45 +0530 Message-ID: Subject: Re: [PATCH v3 9/9] board: qualcomm: Add support for QCS404 EVB To: Stephan Gerhold Cc: u-boot@lists.denx.de, rfried.dev@gmail.com, peng.fan@nxp.com, jh80.chung@samsung.com, sjg@chromium.org, trini@konsulko.com, dsankouski@gmail.com, vinod.koul@linaro.org, nicolas.dechesne@linaro.org, mworsfold@impinj.com, daniel.thompson@linaro.org, pbrobinson@gmail.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Stephan, On Thu, 14 Jul 2022 at 01:02, Stephan Gerhold wrote: > > Hi Sumit, > > On Tue, Jul 12, 2022 at 12:42:12PM +0530, Sumit Garg wrote: > > Add support for Qualcomm QCS404 SoC based evaluation board. > > > > Features: > > - Qualcomm Snapdragon QCS404 SoC > > - 1GiB RAM > > - 8GiB eMMC, uSD slot > > > > U-boot is chain loaded by ABL in 64-bit mode as part of boot.img. > > For detailed build and boot instructions, refer to > > doc/board/qualcomm/qcs404.rst. > > > > Signed-off-by: Sumit Garg > > --- > > arch/arm/dts/Makefile | 1 + > > arch/arm/dts/qcs404-evb-uboot.dtsi | 24 +++++++ > > arch/arm/dts/qcs404-evb.dts | 81 ++++++++++++++++++++++++ > > arch/arm/mach-snapdragon/Kconfig | 11 ++++ > > arch/arm/mach-snapdragon/Makefile | 2 + > > arch/arm/mach-snapdragon/sysmap-qcs404.c | 31 +++++++++ > > board/qualcomm/qcs404-evb/Kconfig | 15 +++++ > > board/qualcomm/qcs404-evb/MAINTAINERS | 6 ++ > > board/qualcomm/qcs404-evb/Makefile | 6 ++ > > board/qualcomm/qcs404-evb/qcs404-evb.c | 33 ++++++++++ > > board/qualcomm/qcs404-evb/qcs404-evb.its | 64 +++++++++++++++++++ > > configs/qcs404evb_defconfig | 39 ++++++++++++ > > doc/board/qualcomm/index.rst | 1 + > > doc/board/qualcomm/qcs404.rst | 79 +++++++++++++++++++++++ > > include/configs/qcs404-evb.h | 27 ++++++++ > > 15 files changed, 420 insertions(+) > > create mode 100644 arch/arm/dts/qcs404-evb-uboot.dtsi > > create mode 100644 arch/arm/dts/qcs404-evb.dts > > create mode 100644 arch/arm/mach-snapdragon/sysmap-qcs404.c > > create mode 100644 board/qualcomm/qcs404-evb/Kconfig > > create mode 100644 board/qualcomm/qcs404-evb/MAINTAINERS > > create mode 100644 board/qualcomm/qcs404-evb/Makefile > > create mode 100644 board/qualcomm/qcs404-evb/qcs404-evb.c > > create mode 100644 board/qualcomm/qcs404-evb/qcs404-evb.its > > create mode 100644 configs/qcs404evb_defconfig > > create mode 100644 doc/board/qualcomm/qcs404.rst > > create mode 100644 include/configs/qcs404-evb.h > > > > [...] > > diff --git a/arch/arm/dts/qcs404-evb.dts b/arch/arm/dts/qcs404-evb.dts > > new file mode 100644 > > index 0000000000..4f0ae20bdb > > --- /dev/null > > +++ b/arch/arm/dts/qcs404-evb.dts > > @@ -0,0 +1,81 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Qualcomm QCS404 based evaluation board device tree source > > + * > > + * (C) Copyright 2022 Sumit Garg > > + */ > > + > > +/dts-v1/; > > + > > +#include "skeleton64.dtsi" > > +#include > > +#include > > +#include > > + > > +/ { > > + model = "Qualcomm Technologies, Inc. QCS404 EVB"; > > + compatible = "qcom,qcs404-evb", "qcom,qcs404"; > > + #address-cells = <0x2>; > > + #size-cells = <0x2>; > > + > > + chosen { > > + stdout-path = "serial0:115200n8"; > > + }; > > + > > + aliases { > > + serial0 = &debug_uart; > > + }; > > + > > + memory { > > + device_type = "memory"; > > + reg = <0 0x80000000 0 0x40000000>; > > + }; > > + > > + soc { > > + #address-cells = <0x1>; > > + #size-cells = <0x1>; > > + ranges = <0x0 0x0 0x0 0xffffffff>; > > + compatible = "simple-bus"; > > + > > + pinctrl_north@1300000 { > > + compatible = "qcom,tlmm-qcs404"; > > + reg = <0x1300000 0x200000>; > > + > > + blsp1_uart2: uart { > > + pins = "GPIO_17", "GPIO_18"; > > + function = "blsp_uart2"; > > + }; > > + }; > > + > > I know you're just following the example of the existing Qualcomm boards > here but I think we should really avoid adding any more custom device > trees that are inconsistent with the official (upstream) Linux bindings. > > Many other boards in U-Boot have moved to using the upstream Linux DTs > as-is (with some additions in -u-boot.dtsi) and I think we should do the > same for the Qualcomm boards. Judging from Tom's comments on other > patches (e.g. [1]), this might even be a requirement now? > I overall agree with this and you can already see patches #2 and #3 in this patch-set following this guideline. > The SPMI fix I just sent for DB410c/DB820c [2] is a good example why it > is important to have bindings consistent with Linux. Looking at your > patch reminded me that I never sent this fix (thanks!). > Makes sense and I can echo with this while adding new boards support its difficult to cope up with different DT expectations from Linux and u-boot drivers. > Can you check how hard it would be to reuse the upstream QCS404 DT? > It turned out to be patch [1] on top of this patch-set. Please help me to test it on boards you have access to. [1] https://patchwork.ozlabs.org/project/uboot/patch/20220714073337.2298978-1-sumit.garg@linaro.org/ -Sumit > Thanks! > Stephan > > [1]: https://lore.kernel.org/u-boot/20220601152800.GJ25375@bill-the-cat/ > [2]: https://lore.kernel.org/u-boot/20220713191711.4155-1-stephan@gerhold.net/