From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sumit Garg Date: Fri, 09 Aug 2019 05:48:24 +0000 Subject: Re: [Tee-dev] [RFC v2 2/6] tee: enable support to register kernel memory Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <1564489420-677-1-git-send-email-sumit.garg@linaro.org> <1564489420-677-3-git-send-email-sumit.garg@linaro.org> <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> In-Reply-To: <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> To: Stuart Yoder Cc: dhowells@redhat.com, Daniel Thompson , Jonathan Corbet , jejb@linux.ibm.com, Ard Biesheuvel , Linux Doc Mailing List , Linux Kernel Mailing List , Mimi Zohar , "tee-dev @ lists . linaro . org" , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Jarkko Sakkinen , Casey Schaufler , linux-integrity@vger.kernel.org, linux-arm-kernel , "Serge E. Hallyn" On Fri, 9 Aug 2019 at 03:57, Stuart Yoder wrote: > > > > On 7/30/19 7:23 AM, Sumit Garg wrote: > > > @@ -264,7 +266,17 @@ struct tee_shm *tee_shm_register(struct tee_context *ctx, unsigned long addr, > > goto err; > > } > > > > - rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, shm->pages); > > + if (flags & TEE_SHM_USER_MAPPED) { > > + rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, > > + shm->pages); > > + } else { > > + const struct kvec kiov = { > > + .iov_base = (void *)start, > > + .iov_len = PAGE_SIZE > > + }; > > + > > + rc = get_kernel_pages(&kiov, num_pages, 0, shm->pages); > > Passing a single kvec struct is temporary I assume? Because as currently > written this will only work with num_pages=1. > Ah, thanks Stuart for pointing this out. It should rather be an array of kvec struct. Will fix it in next version. -Sumit > Stuart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4777EC433FF for ; Fri, 9 Aug 2019 05:36:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C3A42173E for ; Fri, 9 Aug 2019 05:36:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="atU7IHWX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405534AbfHIFgi (ORCPT ); Fri, 9 Aug 2019 01:36:38 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:45865 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbfHIFgi (ORCPT ); Fri, 9 Aug 2019 01:36:38 -0400 Received: by mail-lj1-f196.google.com with SMTP id t3so2444853ljj.12 for ; Thu, 08 Aug 2019 22:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tkESspP4zbr99ojw52v1cXFMI0dDrn0lXHnV6ilVC5Q=; b=atU7IHWXmtnksMrbQ1k8BhvgynR/4zyE9OG6rt3PbzKxYem2YQ+LktsQVrdVxU9YLC 6YS80Puii0arAAtUnabMIGV3zOeVA3ApszU4i/8p8wffKinEejM0dX7NX0PIEsTgMwvO TLzlf48b35qwzLFYgJMSx7ys1Tf0RN+OG8QBquU8whFJhPaB1FkUd42OD9c0OyIJsSHJ KiLi5JgnoeFZjOcc1P0sXibjDkKRUkLk7IMYnOeem0uchFACJ8+T4ZID/+da8ANX2BVu Ko5uHliRhM4w0sAseDx2oJ+M853EwbV2INgH2yf6WehmFBIkH027WuZ/eSEYYm1W4a3G FllQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tkESspP4zbr99ojw52v1cXFMI0dDrn0lXHnV6ilVC5Q=; b=XAmxeeCWywhktelEk+PEIARN9VV5yYCAxrf0BNu+pX43GaqDo1YNJmNPcl7NFCW5kr 5aWQAO8fNvJvwXLvuvzMeX7xzmY0hwBDpk0ryFA+65hF+GPS4MmgCwmA0nE3jX5Qb7ww I8czIRXhuJksQ3T5300+YHf9w3IxLdlmi7TLqLHXrtAQ0ZwUyX+fF/QstMt6NPIbQdsA i6+zwhdcYN75ZwJ8xbH8a+6036TOH/nmZOowOlZPuTbEOX/qQLfu9ABLOUBKPTAPPUAE 7a83K60rHC+MPOW+Z/xN7TBHfBTD6iWQMnEZ9yqUlzT1lh14alTwK/8bQ2nNT3IbW2pT gBzw== X-Gm-Message-State: APjAAAWfb6/ukMdSKK4MxHVXuYvYi+cq8ta67FQ+5F1/dCPnCCmeaEj3 MWEkg72igiE3je9jOCNeO5RrtBE82DCqKxVwsOY1Jw== X-Google-Smtp-Source: APXvYqxxy1TTV6QUfZHgTqMprUtqV1APmZ3PZFtZk65sg1r/cmrL6x9y1rC58d2HxqSp7BbfYHFxOnFanGeQ7Y6xGlk= X-Received: by 2002:a2e:301a:: with SMTP id w26mr10098807ljw.76.1565328996305; Thu, 08 Aug 2019 22:36:36 -0700 (PDT) MIME-Version: 1.0 References: <1564489420-677-1-git-send-email-sumit.garg@linaro.org> <1564489420-677-3-git-send-email-sumit.garg@linaro.org> <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> In-Reply-To: <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> From: Sumit Garg Date: Fri, 9 Aug 2019 11:06:24 +0530 Message-ID: Subject: Re: [Tee-dev] [RFC v2 2/6] tee: enable support to register kernel memory To: Stuart Yoder Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, "tee-dev @ lists . linaro . org" , Daniel Thompson , Jonathan Corbet , jejb@linux.ibm.com, Ard Biesheuvel , Linux Doc Mailing List , Mimi Zohar , Linux Kernel Mailing List , dhowells@redhat.com, Jarkko Sakkinen , Casey Schaufler , linux-arm-kernel , "Serge E. Hallyn" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Aug 2019 at 03:57, Stuart Yoder wrote: > > > > On 7/30/19 7:23 AM, Sumit Garg wrote: > > > @@ -264,7 +266,17 @@ struct tee_shm *tee_shm_register(struct tee_context *ctx, unsigned long addr, > > goto err; > > } > > > > - rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, shm->pages); > > + if (flags & TEE_SHM_USER_MAPPED) { > > + rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, > > + shm->pages); > > + } else { > > + const struct kvec kiov = { > > + .iov_base = (void *)start, > > + .iov_len = PAGE_SIZE > > + }; > > + > > + rc = get_kernel_pages(&kiov, num_pages, 0, shm->pages); > > Passing a single kvec struct is temporary I assume? Because as currently > written this will only work with num_pages==1. > Ah, thanks Stuart for pointing this out. It should rather be an array of kvec struct. Will fix it in next version. -Sumit > Stuart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACDF3C31E40 for ; Fri, 9 Aug 2019 05:36:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77694208C3 for ; Fri, 9 Aug 2019 05:36:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dZ1SHDPy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="atU7IHWX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77694208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HmK73SY/qkgbVsSBvb+ZGkjPB4/xdo+FiXujc6d1yIg=; b=dZ1SHDPyfoy0tM d3ppwpPLKnPR6xypv6Qleljqxt0YithgQwl4ZIT7Jcy+4bRc5vGhg3W9WIPI2GZLkdxilhcw+DRkm zyTiMNKSeJfw0n7bxhb94jUK3NRbzrciK0SFcIPKzNIswtLHQCvPD+GQuSmGsN4mD020J9SRuxQNt 9wIbh9FS+jM9f33+j5oMj+7FcDq5ZDHBGtnvg46RUrg9Xs9JtVafhvZeihFaQSP5NRhNnJQe3eSKq grnFXEvyfUVdHnWr7uv8CoFPFzK/Tw+L8FmWEq8SIqcZXuQCVw5h1WoOvyxBOvH9YoAl1bhA8vLuV Sqcob4ICEQ9v952eENrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvxZz-00032g-Oq; Fri, 09 Aug 2019 05:36:43 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvxZv-00031o-PO for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 05:36:41 +0000 Received: by mail-lj1-x243.google.com with SMTP id t28so90984551lje.9 for ; Thu, 08 Aug 2019 22:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tkESspP4zbr99ojw52v1cXFMI0dDrn0lXHnV6ilVC5Q=; b=atU7IHWXmtnksMrbQ1k8BhvgynR/4zyE9OG6rt3PbzKxYem2YQ+LktsQVrdVxU9YLC 6YS80Puii0arAAtUnabMIGV3zOeVA3ApszU4i/8p8wffKinEejM0dX7NX0PIEsTgMwvO TLzlf48b35qwzLFYgJMSx7ys1Tf0RN+OG8QBquU8whFJhPaB1FkUd42OD9c0OyIJsSHJ KiLi5JgnoeFZjOcc1P0sXibjDkKRUkLk7IMYnOeem0uchFACJ8+T4ZID/+da8ANX2BVu Ko5uHliRhM4w0sAseDx2oJ+M853EwbV2INgH2yf6WehmFBIkH027WuZ/eSEYYm1W4a3G FllQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tkESspP4zbr99ojw52v1cXFMI0dDrn0lXHnV6ilVC5Q=; b=c15O4odq7dY8bAQtob3VR9mWw9Uy2TR4L3SwMdLaqenpX4oOjna3zhJbdpigMIX9NI VM6Mk/rG4Ydwr/rIou5PNqJX73miC0QpfdKRMIkLYNmRKYB0QonR0poOsGfgObrUMQ2N kKndR/uTivpcZjf2KotW/DOh3pgoHgVQTgbnd3fU7+tnTA4B8AvX2BWvpMY8UZRbZK4p RkbPkuRBMok/EPvqJwx/p5MJLtafWuwUEC/1DWV4F14uubFmXZPCFd5cbdkEgcvAiX8w AN8hFYlu275nv2JLR22FPCvRA0jU88XOUe4W200U/UcBqtGzdAQwomETv46o/lD4Z/n0 hyUA== X-Gm-Message-State: APjAAAVcLuEDKrx9Ct9vBU8+08ptZyXHaitsTvP0Eja1kxlrEaWjm4Db m/VIVxabsWgXf4HIs6atxI9Rg4NIhakZv36ofTqtdA== X-Google-Smtp-Source: APXvYqxxy1TTV6QUfZHgTqMprUtqV1APmZ3PZFtZk65sg1r/cmrL6x9y1rC58d2HxqSp7BbfYHFxOnFanGeQ7Y6xGlk= X-Received: by 2002:a2e:301a:: with SMTP id w26mr10098807ljw.76.1565328996305; Thu, 08 Aug 2019 22:36:36 -0700 (PDT) MIME-Version: 1.0 References: <1564489420-677-1-git-send-email-sumit.garg@linaro.org> <1564489420-677-3-git-send-email-sumit.garg@linaro.org> <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> In-Reply-To: <99777010-db74-096a-ce1a-da30539d6fb5@arm.com> From: Sumit Garg Date: Fri, 9 Aug 2019 11:06:24 +0530 Message-ID: Subject: Re: [Tee-dev] [RFC v2 2/6] tee: enable support to register kernel memory To: Stuart Yoder X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_223639_891729_29CF34E9 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dhowells@redhat.com, Daniel Thompson , Jonathan Corbet , jejb@linux.ibm.com, Ard Biesheuvel , Linux Doc Mailing List , Linux Kernel Mailing List , Mimi Zohar , "tee-dev @ lists . linaro . org" , linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, Jarkko Sakkinen , Casey Schaufler , linux-integrity@vger.kernel.org, linux-arm-kernel , "Serge E. Hallyn" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 9 Aug 2019 at 03:57, Stuart Yoder wrote: > > > > On 7/30/19 7:23 AM, Sumit Garg wrote: > > > @@ -264,7 +266,17 @@ struct tee_shm *tee_shm_register(struct tee_context *ctx, unsigned long addr, > > goto err; > > } > > > > - rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, shm->pages); > > + if (flags & TEE_SHM_USER_MAPPED) { > > + rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, > > + shm->pages); > > + } else { > > + const struct kvec kiov = { > > + .iov_base = (void *)start, > > + .iov_len = PAGE_SIZE > > + }; > > + > > + rc = get_kernel_pages(&kiov, num_pages, 0, shm->pages); > > Passing a single kvec struct is temporary I assume? Because as currently > written this will only work with num_pages==1. > Ah, thanks Stuart for pointing this out. It should rather be an array of kvec struct. Will fix it in next version. -Sumit > Stuart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel