From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Lovenberg Subject: Re: [PATCH 1/1] cifs: potential memory leaks when parsing mnt opts Date: Sat, 21 Mar 2015 21:10:46 -0500 Message-ID: References: <1426979310-31201-1-git-send-email-tsgatesv@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org" , linux-cifs , samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, LKML , taesoo-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org, changwoo-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org, sanidhya-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org, blee-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org, csong84-/4noJB3qBVQ3uPMLIKxrzw@public.gmane.org To: Taesoo Kim Return-path: In-Reply-To: <1426979310-31201-1-git-send-email-tsgatesv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Sat, Mar 21, 2015 at 6:08 PM, Taesoo Kim wrote: > Althouhg mkfs.cifs in userspace performs a bit of sanitization > (e.g., forcing one user option), current implementation is not > robust. Other options such as iocharset and domainanme are similary > vulnerable. > I assume you mean mount.cifs? :-) Anyways, good catch. -- Peace and Blessings, -Scott. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751687AbbCVCKt (ORCPT ); Sat, 21 Mar 2015 22:10:49 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:33530 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbbCVCKs (ORCPT ); Sat, 21 Mar 2015 22:10:48 -0400 MIME-Version: 1.0 In-Reply-To: <1426979310-31201-1-git-send-email-tsgatesv@gmail.com> References: <1426979310-31201-1-git-send-email-tsgatesv@gmail.com> Date: Sat, 21 Mar 2015 21:10:46 -0500 Message-ID: Subject: Re: [PATCH 1/1] cifs: potential memory leaks when parsing mnt opts From: Scott Lovenberg To: Taesoo Kim Cc: "sfrench@samba.org" , linux-cifs , samba-technical@lists.samba.org, LKML , taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 6:08 PM, Taesoo Kim wrote: > Althouhg mkfs.cifs in userspace performs a bit of sanitization > (e.g., forcing one user option), current implementation is not > robust. Other options such as iocharset and domainanme are similary > vulnerable. > I assume you mean mount.cifs? :-) Anyways, good catch. -- Peace and Blessings, -Scott.