From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80BF1C433EF for ; Mon, 20 Sep 2021 20:25:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 481A2610A0 for ; Mon, 20 Sep 2021 20:25:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 481A2610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sUbLkfuBD0p6QZvWOeKBLP/6EAE7Glr+4+7HZvy1zpU=; b=o0WXsc8mHzJ+d/ MNXNCzvwYnEcmPqRMQRU6u69b6haJfB0IWSNCta0RXihlJlNsZ/02W2z6IZAPUFBtASHey2n53owl V2pZI5b3Vm64kuyIyHAF26CrL/0LpgibHPFTWZkkhlXRIS5eugJBoQXbpHbnLyAGy5w3QXw4vhwm7 orBpNK1vvI2xhpyP5zv010ckmeCn95S5wVJyESw4UWl4NXn/hU1lRYhNI2Ss69cE0tIGDiKsqFmmv wUvfh3ZFc722c89ITAuuSmKQ2D/WOoJHKnKPlEzil7q1bvErRaPaiEg0e5aqKogTSRtUexJHngaFR cVORhrbtr44t+ALdLJbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSPqc-00328s-3W; Mon, 20 Sep 2021 20:25:06 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSPqZ-00327n-VN; Mon, 20 Sep 2021 20:25:05 +0000 Received: by mail-ed1-x536.google.com with SMTP id t6so65703869edi.9; Mon, 20 Sep 2021 13:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AewO3aO3+z4hlxCwFUZ9p0OHCR2EQKSX+iYFMao6nc0=; b=WlFs5oPPaUXTN+8fM3tZZ4yFpm8r8IgTSFP1cJLfWFwUQqjOYBaREpxJ5wY1VgC+Jc Dh7y5DzfBQ7pEYF3w51CtovgkKI68ReEkdlCSOK/dgJag7xi9DrC/MC4rVEnq8fQ0ivB wPKWiqB1+UGDojR6HGuMEiJOhdNGv7/2wpZ/Tcn+l9WojxeOx2ZzxKOapLN7aEWKm9LZ Q8hCNZzkkpAY9pF+37I9UTj4esgXe3fjAf9sVG7VnMOEpEoRDuMCLHW96wgqpSIxKzpC 8G9DgMDfr3zUZi9SwzFqT5MtiCUmXwgSIPS1258EfUig6QeLWqMfMsduf/yqypk2dgUO YLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AewO3aO3+z4hlxCwFUZ9p0OHCR2EQKSX+iYFMao6nc0=; b=DT8Re5rHuvDK25csbCs+iRyCnWKlNo++grU5zYdEoTPHI6k40jhjvmCp1ytycNFKWz qDHNdeuQQ5sJ3UVPHU5YcL4OE1AE5mbzrte38oSoyDgq1O9/1sUxn9UpPDLQOXlCO/rZ dR2GKe/eYssTIXFu1IwxiiEtsT7TFjcuyqbQtwwEYHc4xfe5z9/96pyA3XBRlwn+l2Gs /ZabQgg+xLEUa/F9UkPNzBfUMMwMzI7vFK6guYCPim98NGRtLP1Dpkj1eyjr8sZE4y/D KLtd1QCN+1GTm09rkAzhJJeCvk+sI9XJAseDPUQETQV697ZDqDuILxqCZkq/UD9KJ8aw oS8w== X-Gm-Message-State: AOAM530TXivbp1ssK+Ot4+S7P8wQIo4Q9CRj752GGbMb9QNsI3d36A9i 26iHChU6NrL+4D8hrb6ziqJgcJzkQeZOEgOpiVM= X-Google-Smtp-Source: ABdhPJwkUmyH5gYMjWJ2V2eDW+BhQLLZjiG5GzSZPFfz145M9TBUTN1XRqXTHJlhfKSmof0VVXdttq5fa/CP+dW00Hg= X-Received: by 2002:a17:906:9747:: with SMTP id o7mr30754181ejy.486.1632169500694; Mon, 20 Sep 2021 13:25:00 -0700 (PDT) MIME-Version: 1.0 References: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de> From: Martin Blumenstingl Date: Mon, 20 Sep 2021 22:24:49 +0200 Message-ID: Subject: Re: [PATCH v2] hwrng: meson - Improve error handling for core clock To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Matt Mackall , Herbert Xu , Neil Armstrong , Kevin Hilman , linux-crypto@vger.kernel.org, kernel@pengutronix.de, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_132504_066973_E7D0CACB X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMjAsIDIwMjEgYXQgOTo0NCBBTSBVd2UgS2xlaW5lLUvDtm5pZwo8dS5rbGVp bmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKPgo+IC1FTk9FTlQgKGllLiAidGhlcmUg aXMgbm8gY2xvY2siKSBpcyBmaW5lIHRvIGlnbm9yZSBmb3IgYW4gb3B0aW9uYWwKPiBjbG9jaywg b3RoZXIgdmFsdWVzIGFyZSBub3Qgc3VwcG9zZWQgdG8gYmUgaWdub3JlZCBhbmQgc2hvdWxkIGJl Cj4gZXNjYWxhdGVkIHRvIHRoZSBjYWxsZXIgKGUuZy4gLUVQUk9CRV9ERUZFUikuIElnbm9yZSAt RU5PRU5UIGJ5IHVzaW5nCj4gZGV2bV9jbGtfZ2V0X29wdGlvbmFsKCkuCj4KPiBXaGlsZSB0b3Vj aGluZyB0aGlzIGNvZGUgYWxzbyBhZGQgYW4gZXJyb3IgbWVzc2FnZSBmb3IgdGhlIGZhdGFsIGVy cm9ycy4KPgo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2Vu aWdAcGVuZ3V0cm9uaXguZGU+ClJldmlld2VkLWJ5OiBNYXJ0aW4gQmx1bWVuc3RpbmdsIDxtYXJ0 aW4uYmx1bWVuc3RpbmdsQGdvb2dsZW1haWwuY29tPgphcyB3ZWxsIGFzOgpUZXN0ZWQtYnk6IE1h cnRpbiBCbHVtZW5zdGluZ2wgPG1hcnRpbi5ibHVtZW5zdGluZ2xAZ29vZ2xlbWFpbC5jb20+ICMK b24gT2Ryb2lkLUMxCgpUaGFuayB5b3UgVXdlIQoKCkJlc3QgcmVnYXJkcywKTWFydGluCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2lj IG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B857CC433F5 for ; Mon, 20 Sep 2021 20:26:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FC9A610A0 for ; Mon, 20 Sep 2021 20:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7FC9A610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hfjmNWFZ3pWVoTe024nYNGWEW5wAxhyUBTAtoEzB9QA=; b=1qIayoPxPjL5Vz 6uOCYs+z2f2ykRVDsKVO/b6gKJ8EGIrD6MXRpqtnpW8qTWf6X7yosshnMnV1ASTurccMxcEOEviTx Zt84+bRIJol2qyWkpoSTiu4nqxrQ3DUswJZYh4u0a4jjPVX8GHYsXoEiQS6egkAzRGJAw4gyI1HDx kkfUrzXWQzUcV3tk5HwVczpOveffabl2EiY/yVTPBwTbzUkN69fdyiTodCfIhSTzjz64Jx1OjoMmH XNHfCFBMpJeSUH++fka+5S97MeAwmxh81iWM6iQkXxfe2iNFyCl3tLBsaWcMHku4OOa5J1NZjTzLX OCCZNormpfDbKoc+jkKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSPqd-00328z-Pf; Mon, 20 Sep 2021 20:25:07 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSPqZ-00327n-VN; Mon, 20 Sep 2021 20:25:05 +0000 Received: by mail-ed1-x536.google.com with SMTP id t6so65703869edi.9; Mon, 20 Sep 2021 13:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AewO3aO3+z4hlxCwFUZ9p0OHCR2EQKSX+iYFMao6nc0=; b=WlFs5oPPaUXTN+8fM3tZZ4yFpm8r8IgTSFP1cJLfWFwUQqjOYBaREpxJ5wY1VgC+Jc Dh7y5DzfBQ7pEYF3w51CtovgkKI68ReEkdlCSOK/dgJag7xi9DrC/MC4rVEnq8fQ0ivB wPKWiqB1+UGDojR6HGuMEiJOhdNGv7/2wpZ/Tcn+l9WojxeOx2ZzxKOapLN7aEWKm9LZ Q8hCNZzkkpAY9pF+37I9UTj4esgXe3fjAf9sVG7VnMOEpEoRDuMCLHW96wgqpSIxKzpC 8G9DgMDfr3zUZi9SwzFqT5MtiCUmXwgSIPS1258EfUig6QeLWqMfMsduf/yqypk2dgUO YLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AewO3aO3+z4hlxCwFUZ9p0OHCR2EQKSX+iYFMao6nc0=; b=DT8Re5rHuvDK25csbCs+iRyCnWKlNo++grU5zYdEoTPHI6k40jhjvmCp1ytycNFKWz qDHNdeuQQ5sJ3UVPHU5YcL4OE1AE5mbzrte38oSoyDgq1O9/1sUxn9UpPDLQOXlCO/rZ dR2GKe/eYssTIXFu1IwxiiEtsT7TFjcuyqbQtwwEYHc4xfe5z9/96pyA3XBRlwn+l2Gs /ZabQgg+xLEUa/F9UkPNzBfUMMwMzI7vFK6guYCPim98NGRtLP1Dpkj1eyjr8sZE4y/D KLtd1QCN+1GTm09rkAzhJJeCvk+sI9XJAseDPUQETQV697ZDqDuILxqCZkq/UD9KJ8aw oS8w== X-Gm-Message-State: AOAM530TXivbp1ssK+Ot4+S7P8wQIo4Q9CRj752GGbMb9QNsI3d36A9i 26iHChU6NrL+4D8hrb6ziqJgcJzkQeZOEgOpiVM= X-Google-Smtp-Source: ABdhPJwkUmyH5gYMjWJ2V2eDW+BhQLLZjiG5GzSZPFfz145M9TBUTN1XRqXTHJlhfKSmof0VVXdttq5fa/CP+dW00Hg= X-Received: by 2002:a17:906:9747:: with SMTP id o7mr30754181ejy.486.1632169500694; Mon, 20 Sep 2021 13:25:00 -0700 (PDT) MIME-Version: 1.0 References: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de> From: Martin Blumenstingl Date: Mon, 20 Sep 2021 22:24:49 +0200 Message-ID: Subject: Re: [PATCH v2] hwrng: meson - Improve error handling for core clock To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Matt Mackall , Herbert Xu , Neil Armstrong , Kevin Hilman , linux-crypto@vger.kernel.org, kernel@pengutronix.de, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_132504_066973_E7D0CACB X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMjAsIDIwMjEgYXQgOTo0NCBBTSBVd2UgS2xlaW5lLUvDtm5pZwo8dS5rbGVp bmUta29lbmlnQHBlbmd1dHJvbml4LmRlPiB3cm90ZToKPgo+IC1FTk9FTlQgKGllLiAidGhlcmUg aXMgbm8gY2xvY2siKSBpcyBmaW5lIHRvIGlnbm9yZSBmb3IgYW4gb3B0aW9uYWwKPiBjbG9jaywg b3RoZXIgdmFsdWVzIGFyZSBub3Qgc3VwcG9zZWQgdG8gYmUgaWdub3JlZCBhbmQgc2hvdWxkIGJl Cj4gZXNjYWxhdGVkIHRvIHRoZSBjYWxsZXIgKGUuZy4gLUVQUk9CRV9ERUZFUikuIElnbm9yZSAt RU5PRU5UIGJ5IHVzaW5nCj4gZGV2bV9jbGtfZ2V0X29wdGlvbmFsKCkuCj4KPiBXaGlsZSB0b3Vj aGluZyB0aGlzIGNvZGUgYWxzbyBhZGQgYW4gZXJyb3IgbWVzc2FnZSBmb3IgdGhlIGZhdGFsIGVy cm9ycy4KPgo+IFNpZ25lZC1vZmYtYnk6IFV3ZSBLbGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2Vu aWdAcGVuZ3V0cm9uaXguZGU+ClJldmlld2VkLWJ5OiBNYXJ0aW4gQmx1bWVuc3RpbmdsIDxtYXJ0 aW4uYmx1bWVuc3RpbmdsQGdvb2dsZW1haWwuY29tPgphcyB3ZWxsIGFzOgpUZXN0ZWQtYnk6IE1h cnRpbiBCbHVtZW5zdGluZ2wgPG1hcnRpbi5ibHVtZW5zdGluZ2xAZ29vZ2xlbWFpbC5jb20+ICMK b24gT2Ryb2lkLUMxCgpUaGFuayB5b3UgVXdlIQoKCkJlc3QgcmVnYXJkcywKTWFydGluCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F9C4C433F5 for ; Tue, 21 Sep 2021 03:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F25561100 for ; Tue, 21 Sep 2021 03:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231474AbhIUDWL (ORCPT ); Mon, 20 Sep 2021 23:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240611AbhIUCcZ (ORCPT ); Mon, 20 Sep 2021 22:32:25 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33F88C04F345 for ; Mon, 20 Sep 2021 13:25:02 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id dj4so10195821edb.5 for ; Mon, 20 Sep 2021 13:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AewO3aO3+z4hlxCwFUZ9p0OHCR2EQKSX+iYFMao6nc0=; b=WlFs5oPPaUXTN+8fM3tZZ4yFpm8r8IgTSFP1cJLfWFwUQqjOYBaREpxJ5wY1VgC+Jc Dh7y5DzfBQ7pEYF3w51CtovgkKI68ReEkdlCSOK/dgJag7xi9DrC/MC4rVEnq8fQ0ivB wPKWiqB1+UGDojR6HGuMEiJOhdNGv7/2wpZ/Tcn+l9WojxeOx2ZzxKOapLN7aEWKm9LZ Q8hCNZzkkpAY9pF+37I9UTj4esgXe3fjAf9sVG7VnMOEpEoRDuMCLHW96wgqpSIxKzpC 8G9DgMDfr3zUZi9SwzFqT5MtiCUmXwgSIPS1258EfUig6QeLWqMfMsduf/yqypk2dgUO YLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AewO3aO3+z4hlxCwFUZ9p0OHCR2EQKSX+iYFMao6nc0=; b=A2LYKyCGGa+8EXS9V0+CtCm2ZPlEMv5Q5zTuz5CW2KNbUcHCef7U2srcELv9+/rNyP m8hygWP3/tPdH0lrQFN5GZLhNHYxR/j8YrXXB56sCjZYtVkPfA4M+DMkymtbQvFNNcAC M0Qg2qDLZakmoSR6F4Odeo9vymuwc/x2WQq/LOw1bPf66FwAqXf8QUJ9pTnxZXFzeWZo qqY+kF6kXwDIdMCD4aJ9zhJWzWV0fVWOaDpOxhEnfFZ55QLuqDq9e0YxR8apAWc7whBc r/9OxZ3kGu1Qn+ANLkJWmC7OX7ysfRKaF6QvNagwHEv59/McEkegPfo8DoBAvvlDE2Mk hxlA== X-Gm-Message-State: AOAM532FEMEJacrw94qCWQUatc3m1HJeoQ1/MWJQZL6Za3mmm42HO+oP x1TiAPSw2Qde6VFiui/PFqNIJkYhRO4Wsd4giu4= X-Google-Smtp-Source: ABdhPJwkUmyH5gYMjWJ2V2eDW+BhQLLZjiG5GzSZPFfz145M9TBUTN1XRqXTHJlhfKSmof0VVXdttq5fa/CP+dW00Hg= X-Received: by 2002:a17:906:9747:: with SMTP id o7mr30754181ejy.486.1632169500694; Mon, 20 Sep 2021 13:25:00 -0700 (PDT) MIME-Version: 1.0 References: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210920074405.252477-1-u.kleine-koenig@pengutronix.de> From: Martin Blumenstingl Date: Mon, 20 Sep 2021 22:24:49 +0200 Message-ID: Subject: Re: [PATCH v2] hwrng: meson - Improve error handling for core clock To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Matt Mackall , Herbert Xu , Neil Armstrong , Kevin Hilman , linux-crypto@vger.kernel.org, kernel@pengutronix.de, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Sep 20, 2021 at 9:44 AM Uwe Kleine-K=C3=B6nig wrote: > > -ENOENT (ie. "there is no clock") is fine to ignore for an optional > clock, other values are not supposed to be ignored and should be > escalated to the caller (e.g. -EPROBE_DEFER). Ignore -ENOENT by using > devm_clk_get_optional(). > > While touching this code also add an error message for the fatal errors. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Martin Blumenstingl as well as: Tested-by: Martin Blumenstingl # on Odroid-C1 Thank you Uwe! Best regards, Martin