From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28490C43219 for ; Sat, 12 Nov 2022 22:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235091AbiKLW5v (ORCPT ); Sat, 12 Nov 2022 17:57:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbiKLW5t (ORCPT ); Sat, 12 Nov 2022 17:57:49 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D3A15FE8; Sat, 12 Nov 2022 14:57:47 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id n12so20146723eja.11; Sat, 12 Nov 2022 14:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aces7d3gh1cNZ1+1J7wsg1lJ0vNlC5CU2OQmcL8yCkw=; b=gfw+fakuaAtqewolwJkRZapmehXpcSd8l/JmGIId64ZI/VruTHo7XGGyPg6PbMbhRM lwHrB5JAJwJB2grGQ88zeS8g4jjqNwVznoiG/vsyYtcnSRlHUyER8YJ8OwnST3WqifIs 2SqeMr40gzLjARJ6Fgq5aiQs5CoySgHV/qoWBxoWnhUKEdSc76uAgaezwO8JUffiks2I 2etRqJzrp9IxwHH4qdf6jKZdUDq8ZeM5j/lvtq0zrhbtzmT0l6ywhuHtvm4mHwAcMP0A X2O90q7XE2BT1KF/dchGlhk+5miuVkXDlgxRwlTe4FNcZp8Sb+qykZeUFCsbYfdB7p34 1CnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aces7d3gh1cNZ1+1J7wsg1lJ0vNlC5CU2OQmcL8yCkw=; b=sa5EAlsXGqwI76LJngEhPgv/xTxip+WkbLqa+pgyyvj5kQtmicUrmzcMKgmc5cSBmz 7YbJuWTVarw0q2cLjCnTL6yHMRUVZ+ZlGgISVFqGgFj/ipChdJ3bYChX3mPSPc4DFpLO XlRD0pq+O0GPxuLJbSqCQXTcTmZuG0L5Btt9JPJVxCOruZ68LMnqyAfxXHGUoikY3YrE xJS0vVWXKbAa1BKE1wrhDc0gUTaSLTFohUOwFNif/rdDwQqI06sRYNXUKiOk/31L41c4 a6utBtRQfPAE1qb0x4aKHImZVuyCue/bBCmLGplpwMq6AjMaTbeXfYmZ/TUUemuGAJZX soDg== X-Gm-Message-State: ANoB5pkmBMDGdxKP/u8sEHRRSag/CONye5H0qCQSi/jWTlB3LgKdJVFT l4eM1BiYKJliO+x6eZTg3k83z+IWFEtfEdEbyidd8ymCvc0= X-Google-Smtp-Source: AA0mqf5t2EnEEHg3FiYq5ObDCWWH3FWyQ2f6sbmAwIpOq3JsEuJMFGlEqg5Gx/0fUxcJmvofAN9+ffcQTWi3Q6KAwN4= X-Received: by 2002:a17:906:e246:b0:7aa:ffd0:b738 with SMTP id gq6-20020a170906e24600b007aaffd0b738mr6454936ejb.122.1668293866048; Sat, 12 Nov 2022 14:57:46 -0800 (PST) MIME-Version: 1.0 References: <20221110150035.2824580-1-adeep@lexina.in> <20221110150035.2824580-2-adeep@lexina.in> In-Reply-To: <20221110150035.2824580-2-adeep@lexina.in> From: Martin Blumenstingl Date: Sat, 12 Nov 2022 23:57:35 +0100 Message-ID: Subject: Re: [PATCH 1/4] arm64: amlogic: mmc: meson-gx: Add core, tx, rx eMMC/SD/SDIO phase clock settings from devicetree data To: Vyacheslav Bocharov Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:01 PM Vyacheslav Bocharov wrote: > > The mmc driver has the same phase values for all meson platforms. However, > some platforms (and even some boards) require different values. Could you please elaborate which phases are per platform and which are per board? In this series you're only managing the core phase differently for all AXG boards. IMO this can be achieved by extending struct meson_mmc_data with the desired core clock phase Best regards, Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 874ABC433FE for ; Sat, 12 Nov 2022 22:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IgcBWYd+d8X7ygh6BJLiNXc2ptTNr4r8+jIVGZeWjzM=; b=fADljZgpldPjlw ashc2jmtWrJUxyxGru9ce4bMJOqzV3zEMAwWsxNmcCXiKa/3xIroAaTibwFAJY7Gu1lXVyAsXrgmZ 6/LIb7uwANxPr39kIpLzm1Iq4cbhG0ApJGqSwO2/W0kqdq5aXPeGx6b7uLGoSdrsqDsHIdCQ5M51o QS3T+xXPKK04HmFhlm02U/kgAeaF1gCn8RIE75tAuW8Sg6R0NJVqQpTiYeVvHsgYLDf2lrjGwVLi9 8DZMDjLqb8O4q7r4eqsbaUMblerl8OdmvPngtAn5nzCXcGqCMNcxLcjguZwg1CgDmdi7W3z+8TLZ6 FK2FW/MC13P2omc4Z3/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otzRo-008IUy-6n; Sat, 12 Nov 2022 22:58:00 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otzRd-008ITG-Fl; Sat, 12 Nov 2022 22:57:50 +0000 Received: by mail-ej1-x633.google.com with SMTP id q9so20359799ejd.0; Sat, 12 Nov 2022 14:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aces7d3gh1cNZ1+1J7wsg1lJ0vNlC5CU2OQmcL8yCkw=; b=gfw+fakuaAtqewolwJkRZapmehXpcSd8l/JmGIId64ZI/VruTHo7XGGyPg6PbMbhRM lwHrB5JAJwJB2grGQ88zeS8g4jjqNwVznoiG/vsyYtcnSRlHUyER8YJ8OwnST3WqifIs 2SqeMr40gzLjARJ6Fgq5aiQs5CoySgHV/qoWBxoWnhUKEdSc76uAgaezwO8JUffiks2I 2etRqJzrp9IxwHH4qdf6jKZdUDq8ZeM5j/lvtq0zrhbtzmT0l6ywhuHtvm4mHwAcMP0A X2O90q7XE2BT1KF/dchGlhk+5miuVkXDlgxRwlTe4FNcZp8Sb+qykZeUFCsbYfdB7p34 1CnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aces7d3gh1cNZ1+1J7wsg1lJ0vNlC5CU2OQmcL8yCkw=; b=XmIocR3Y2Z7+Xti+P1jfvDGJxzGu2YCDLTTTHOlczaHPdOlF5ITPQGqpITrPq42gdA 3mwmMLe5lytU2BLShZG70DODFq4m5EUlu0H5JKLfGdXurFEK2t1y6QKHOIlrPqFuy5ZO oonggl18Oy3PV/FNsLDMmg8x/zJrbfm1vL9oT6pxapMlHJCM489xgapYDrE8p8a/nXGC GTTps1MBOKQfa9uaSuYjDrsLUA0v6diwZXHMcHCqWHxg1jySQIL98a9uh6OlpRvN9GXJ o2qQ+qsjlwT61WxvX7VxBLzDk98RTRle6nwEF/X/sKI4MYl8BFORRQiVVUkWgX0MUGqa sLaA== X-Gm-Message-State: ANoB5pnRGL1R8Vy8wSDlQBIrfF/bEyQKgfIKcHmABaeu40Buvk0ZeEhO 1dgwoXzPlhMUMg7FyJO5hGCLCJMlf9+4xIm/j9M= X-Google-Smtp-Source: AA0mqf5t2EnEEHg3FiYq5ObDCWWH3FWyQ2f6sbmAwIpOq3JsEuJMFGlEqg5Gx/0fUxcJmvofAN9+ffcQTWi3Q6KAwN4= X-Received: by 2002:a17:906:e246:b0:7aa:ffd0:b738 with SMTP id gq6-20020a170906e24600b007aaffd0b738mr6454936ejb.122.1668293866048; Sat, 12 Nov 2022 14:57:46 -0800 (PST) MIME-Version: 1.0 References: <20221110150035.2824580-1-adeep@lexina.in> <20221110150035.2824580-2-adeep@lexina.in> In-Reply-To: <20221110150035.2824580-2-adeep@lexina.in> From: Martin Blumenstingl Date: Sat, 12 Nov 2022 23:57:35 +0100 Message-ID: Subject: Re: [PATCH 1/4] arm64: amlogic: mmc: meson-gx: Add core, tx, rx eMMC/SD/SDIO phase clock settings from devicetree data To: Vyacheslav Bocharov Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221112_145749_559178_6129E1B9 X-CRM114-Status: UNSURE ( 6.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:01 PM Vyacheslav Bocharov wrote: > > The mmc driver has the same phase values for all meson platforms. However, > some platforms (and even some boards) require different values. Could you please elaborate which phases are per platform and which are per board? In this series you're only managing the core phase differently for all AXG boards. IMO this can be achieved by extending struct meson_mmc_data with the desired core clock phase Best regards, Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F012C433FE for ; Sat, 12 Nov 2022 22:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uh54oDlYmBKmeBDiHTYzBA/NbzwZEhUlEhsvk4MzXzE=; b=pQJRR4nO0c8wrj L+UGa6F/AYwHBh7tkbumxUUcvH/qW4ILgxFGAptjMxjXM+pAtnnq7A77KQ8mjNeHmdf7EJfxKS98N 9x1shnTxKrHGTsEgux5T6zLRowL1hFm+E7LnQ5Jdl8gzqE4xqfPqe4GF7pYgKIorZyZ38O1rFG4sK fRn5YWlX2d/3GNBo2UTyG1N5I1Ap+B3Cu+LO+8C56qcWwBPbpcxtCryhpnkDixT7bpnhsIVMOItyn JH/xsnzHSU5O9bAyorIREP/X/EzZjt0q4vMfRdizSi0Myib/mr2Zookl0fdOmX5/9JLPdHihfE1bI D7FMhvtZkGoja1bQnvow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1otzRg-008ITz-5r; Sat, 12 Nov 2022 22:57:52 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1otzRd-008ITG-Fl; Sat, 12 Nov 2022 22:57:50 +0000 Received: by mail-ej1-x633.google.com with SMTP id q9so20359799ejd.0; Sat, 12 Nov 2022 14:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aces7d3gh1cNZ1+1J7wsg1lJ0vNlC5CU2OQmcL8yCkw=; b=gfw+fakuaAtqewolwJkRZapmehXpcSd8l/JmGIId64ZI/VruTHo7XGGyPg6PbMbhRM lwHrB5JAJwJB2grGQ88zeS8g4jjqNwVznoiG/vsyYtcnSRlHUyER8YJ8OwnST3WqifIs 2SqeMr40gzLjARJ6Fgq5aiQs5CoySgHV/qoWBxoWnhUKEdSc76uAgaezwO8JUffiks2I 2etRqJzrp9IxwHH4qdf6jKZdUDq8ZeM5j/lvtq0zrhbtzmT0l6ywhuHtvm4mHwAcMP0A X2O90q7XE2BT1KF/dchGlhk+5miuVkXDlgxRwlTe4FNcZp8Sb+qykZeUFCsbYfdB7p34 1CnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aces7d3gh1cNZ1+1J7wsg1lJ0vNlC5CU2OQmcL8yCkw=; b=XmIocR3Y2Z7+Xti+P1jfvDGJxzGu2YCDLTTTHOlczaHPdOlF5ITPQGqpITrPq42gdA 3mwmMLe5lytU2BLShZG70DODFq4m5EUlu0H5JKLfGdXurFEK2t1y6QKHOIlrPqFuy5ZO oonggl18Oy3PV/FNsLDMmg8x/zJrbfm1vL9oT6pxapMlHJCM489xgapYDrE8p8a/nXGC GTTps1MBOKQfa9uaSuYjDrsLUA0v6diwZXHMcHCqWHxg1jySQIL98a9uh6OlpRvN9GXJ o2qQ+qsjlwT61WxvX7VxBLzDk98RTRle6nwEF/X/sKI4MYl8BFORRQiVVUkWgX0MUGqa sLaA== X-Gm-Message-State: ANoB5pnRGL1R8Vy8wSDlQBIrfF/bEyQKgfIKcHmABaeu40Buvk0ZeEhO 1dgwoXzPlhMUMg7FyJO5hGCLCJMlf9+4xIm/j9M= X-Google-Smtp-Source: AA0mqf5t2EnEEHg3FiYq5ObDCWWH3FWyQ2f6sbmAwIpOq3JsEuJMFGlEqg5Gx/0fUxcJmvofAN9+ffcQTWi3Q6KAwN4= X-Received: by 2002:a17:906:e246:b0:7aa:ffd0:b738 with SMTP id gq6-20020a170906e24600b007aaffd0b738mr6454936ejb.122.1668293866048; Sat, 12 Nov 2022 14:57:46 -0800 (PST) MIME-Version: 1.0 References: <20221110150035.2824580-1-adeep@lexina.in> <20221110150035.2824580-2-adeep@lexina.in> In-Reply-To: <20221110150035.2824580-2-adeep@lexina.in> From: Martin Blumenstingl Date: Sat, 12 Nov 2022 23:57:35 +0100 Message-ID: Subject: Re: [PATCH 1/4] arm64: amlogic: mmc: meson-gx: Add core, tx, rx eMMC/SD/SDIO phase clock settings from devicetree data To: Vyacheslav Bocharov Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221112_145749_559178_6129E1B9 X-CRM114-Status: UNSURE ( 6.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:01 PM Vyacheslav Bocharov wrote: > > The mmc driver has the same phase values for all meson platforms. However, > some platforms (and even some boards) require different values. Could you please elaborate which phases are per platform and which are per board? In this series you're only managing the core phase differently for all AXG boards. IMO this can be achieved by extending struct meson_mmc_data with the desired core clock phase Best regards, Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel