From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE7C9C3A5A8 for ; Wed, 4 Sep 2019 16:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 827FB22CEA for ; Wed, 4 Sep 2019 16:36:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="OSJ8FAFn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731926AbfIDQgy (ORCPT ); Wed, 4 Sep 2019 12:36:54 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:39184 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731520AbfIDQgy (ORCPT ); Wed, 4 Sep 2019 12:36:54 -0400 Received: by mail-ot1-f66.google.com with SMTP id n7so13844032otk.6; Wed, 04 Sep 2019 09:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9VcLNSQo/FpdNp3KI0MMID9sL1HTgtVBFdNj0rcgjWQ=; b=OSJ8FAFn7PHtQnI6r5/8bF6vcGMsBLIq2P1OEk9r1Cby0dXAi0TRm/YXbZ1WElFTSM OwxDHhlBX8TsCy12cYtdufDLUX6/fxQHGqsuTv03rEf+R2Zw2mvJD+ifztkzcAexyFJK xOeSf0cM+k20diCmK/WAiN8eDj1HV3GZQk5eHxrdw3eQfBAp1IHECv3cmB7rSqAAQOrB IZgRVwTZT9SHWPUlEZiXn6NsjP211pqbSkIKPBN2hG73Iq/S2f/oTgUCVe9iYkXjbVjl Dmx9CoeErSplTi/ZYZ93aEYLYwYUxwuA4GOtTSNZWAnJoHLRoMbH3dOWaPQANTDCyfI+ YiVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9VcLNSQo/FpdNp3KI0MMID9sL1HTgtVBFdNj0rcgjWQ=; b=XknCuE9hr+h8cM9jAS5D2sLXsHwW9jip5VIDoS3PVYsO54aYFr34SxEtSjiRprJAtn biLWT6iOWZICjamr/TtH9no66mm9I8CxxjqYL9U1KI906oZ8hS2SyUEz5NzGzwEwvaN/ T27uLJ0oLKK848Axafq3cvFXFJmiqjOblgIv5cHAOh+23PPGw0LbXze0+p6pbxCUT67V 54gttYMzxMBlaWs6wSUII26I8oufui9cSDqYh2opszr2Vm5AcaxMoEhpYCXUR11twWJG z7w5cqgL0lZRygwQDlhuEBa5nU8Ck2fpfZuFXwsn0irpyuGUckqwTB0cClJrgmryFels AFrw== X-Gm-Message-State: APjAAAXLV/e4wObSHOLjMqEU8ZgLMTgDxCUqubRWjJ49Yfeh85IWKmjX R6pjzWgLuT/R3thEiixPEZM6eZ+hVxuFvTB/tV7XxpAw X-Google-Smtp-Source: APXvYqxVwdwlZkT1M7Z+FTlrgM/3cXgKH32gOCFlO1BhA8Z5xZViduosC/Nigzkht2IeSZZMalE9o+m1sgYNm/UGDhM= X-Received: by 2002:a05:6830:1e5a:: with SMTP id e26mr7631053otj.96.1567615012911; Wed, 04 Sep 2019 09:36:52 -0700 (PDT) MIME-Version: 1.0 References: <20190904114014.124099-1-weiyongjun1@huawei.com> In-Reply-To: <20190904114014.124099-1-weiyongjun1@huawei.com> From: Martin Blumenstingl Date: Wed, 4 Sep 2019 18:36:41 +0200 Message-ID: Subject: Re: [PATCH -next] phy: lantiq: vrx200-pcie: fix error return code in ltq_vrx200_pcie_phy_power_on() To: Wei Yongjun Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 4, 2019 at 1:23 PM Wei Yongjun wrote: > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: e52a632195bf ("phy: lantiq: vrx200-pcie: add a driver for the Lantiq VRX200 PCIe PHY") > Signed-off-by: Wei Yongjun Reviewed-by: Martin Blumenstingl thank you for spotting and fixing this issue! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Date: Wed, 04 Sep 2019 16:36:41 +0000 Subject: Re: [PATCH -next] phy: lantiq: vrx200-pcie: fix error return code in ltq_vrx200_pcie_phy_power_on() Message-Id: List-Id: References: <20190904114014.124099-1-weiyongjun1@huawei.com> In-Reply-To: <20190904114014.124099-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, Sep 4, 2019 at 1:23 PM Wei Yongjun wrote: > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: e52a632195bf ("phy: lantiq: vrx200-pcie: add a driver for the Lantiq VRX200 PCIe PHY") > Signed-off-by: Wei Yongjun Reviewed-by: Martin Blumenstingl thank you for spotting and fixing this issue!