From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A803DC43381 for ; Sun, 24 Feb 2019 19:52:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B1C420663 for ; Sun, 24 Feb 2019 19:52:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="s4q6dvmV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728170AbfBXTwx (ORCPT ); Sun, 24 Feb 2019 14:52:53 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:39412 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbfBXTwx (ORCPT ); Sun, 24 Feb 2019 14:52:53 -0500 Received: by mail-oi1-f194.google.com with SMTP id b4so5647648oif.6; Sun, 24 Feb 2019 11:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MYQcmmvOWPoSOeQLQkGxZasGkeWzPpVbLTX8A4pezEg=; b=s4q6dvmV8vzyo06grp4cC+jC04xPsR8+JpkdIPVXUy45VgdXNnGRcaFxBKuURWkBUb p6ddlpeIaURXH91qcCtIpHOiUmVD40NLv0LSb70q48NMh76kJN2Wo2gxhAVec670W47K 28uZyPp1Shy73IVAlvqvGGQ+HIJQ6WTGqvXdLczF/p4YhxpDHYV++DtYdU6RdP2ZQv2t uoWynKM/57sKPB592SsOLBeByczmtqnsHCeh1hYh7tZCrHIcS8mRZ7SLQfBvaiZKxWL/ zLsvaB+7A4IXljqaoQrEHDKEMfMfmg54USMV1rBVp1mxyYAuoxw4lGrUrw/a8U+uJioj SUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MYQcmmvOWPoSOeQLQkGxZasGkeWzPpVbLTX8A4pezEg=; b=lRuluHNdFcVy0okYgUEHPej6kzedBVEei4DVsZNxklmP6vC0DWgNWZhcsnqs9LPfwK X2yCyLKz+QdJURIq9CBro7iNTJ9++HuLdNE7t88fyMX2wh2XZvgYCdLwqNLFkyJ0fLs1 /NilVLYgbM4B3T63Ti1zoC4vH+q/kCIPxLNGsFcZj0wYbM1cWrOptVHyEwHkvtkJGzkn uDoGF5v3oiZMMEe5V1uhTrfJFTFqwp35yiXXpnpCqxBdGYoEDz8Auod1oR3LrDxdOBMI 7CBPB2QTohokX5XNjnAWO0QYUDwIWFOSQuice3KLq8w1lvE3kSJWvIa65mmHiF05RmbE lxXQ== X-Gm-Message-State: AHQUAuYW6wrbawrQTnv4/fmsDeb/I8dt2SNbpZZzhnCoULGq+ui2MM5T ptypas/e4KpAnm1tmUvCcsqcpZJSe+iSgdIqP4k= X-Google-Smtp-Source: AHgI3IbIeKx3wATaNvdtt2nNjW6v0A+ktUiVw6Fniny1gw2+4boGchyewPpYn/tjfrbZtpEjSJl6SsL2In8Jigb70hE= X-Received: by 2002:aca:5d87:: with SMTP id r129mr9232994oib.39.1551037971667; Sun, 24 Feb 2019 11:52:51 -0800 (PST) MIME-Version: 1.0 References: <20190212151413.24632-1-narmstrong@baylibre.com> <20190212151413.24632-5-narmstrong@baylibre.com> In-Reply-To: <20190212151413.24632-5-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Sun, 24 Feb 2019 20:52:40 +0100 Message-ID: Subject: Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Neil Armstrong Cc: gregkh@linuxfoundation.org, hminas@synopsys.com, balbi@kernel.org, kishon@ti.com, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong wrote: [...] > + > +Example device nodes: > + usb: usb@ffe09000 { > + compatible = "amlogic,meson-g12a-usb-ctrl"; > + reg = <0x0 0xffe09000 0x0 0xa0>; > + interrupts = ; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + clocks = <&clkc CLKID_USB>; > + clock-names = "usb"; > + resets = <&reset RESET_USB>; > + reset-names = "usb"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* USB2 Port 0 */ > + usb20: port@0 { > + reg = <0>; > + phys = <&usb2_phy0>; > + }; > + > + /* USB2 Port 1 */ > + usb21: port@1 { > + reg = <1>; > + phys = <&usb2_phy1>; > + }; > + > + /* USB3 Port 0 */ > + usb3: port@4 { > + reg = <4>; > + phys = <&usb3_pcie_phy PHY_TYPE_USB3>; > + }; > + }; > + > + dwc2: usb@ff400000 { > + compatible = "amlogic,meson-g12a-usb", "snps,dwc2"; > + reg = <0x0 0xff400000 0x0 0x40000>; > + interrupts = ; > + clocks = <&clkc CLKID_USB1_DDR_BRIDGE>; > + clock-names = "ddr"; > + dr_mode = "peripheral"; > + g-rx-fifo-size = <192>; > + g-np-tx-fifo-size = <128>; > + g-tx-fifo-size = <128 128 16 16 16>; > + }; you suggested (off-list) that the OTG capable PHY should be passed to the dwc2 instance I'm aware that this is an example - could you please still add it for consistency? > + > + dwc3: dwc3@ff500000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0xff500000 0x0 0x100000>; > + interrupts = ; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment; > + }; maybe the phys should also be passed to the dwc3 instance? Regards Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings From: Martin Blumenstingl Message-Id: Date: Sun, 24 Feb 2019 20:52:40 +0100 To: Neil Armstrong Cc: gregkh@linuxfoundation.org, hminas@synopsys.com, balbi@kernel.org, kishon@ti.com, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-ID: SGkgTmVpbCwKCk9uIFR1ZSwgRmViIDEyLCAyMDE5IGF0IDQ6MTUgUE0gTmVpbCBBcm1zdHJvbmcg PG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPiB3cm90ZToKWy4uLl0KPiArCj4gK0V4YW1wbGUgZGV2 aWNlIG5vZGVzOgo+ICsgICAgICAgdXNiOiB1c2JAZmZlMDkwMDAgewo+ICsgICAgICAgICAgICAg ICAgICAgICAgIGNvbXBhdGlibGUgPSAiYW1sb2dpYyxtZXNvbi1nMTJhLXVzYi1jdHJsIjsKPiAr ICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHgwIDB4ZmZlMDkwMDAgMHgwIDB4YTA+Owo+ ICsgICAgICAgICAgICAgICAgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAxNiBJUlFfVFlQ RV9MRVZFTF9ISUdIPjsKPiArICAgICAgICAgICAgICAgICAgICAgICAjYWRkcmVzcy1jZWxscyA9 IDwyPjsKPiArICAgICAgICAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwyPjsKPiArICAg ICAgICAgICAgICAgICAgICAgICByYW5nZXM7Cj4gKwo+ICsgICAgICAgICAgICAgICAgICAgICAg IGNsb2NrcyA9IDwmY2xrYyBDTEtJRF9VU0I+Owo+ICsgICAgICAgICAgICAgICAgICAgICAgIGNs b2NrLW5hbWVzID0gInVzYiI7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmVzZXRzID0gPCZy ZXNldCBSRVNFVF9VU0I+Owo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJlc2V0LW5hbWVzID0g InVzYiI7Cj4gKwo+ICsgICAgICAgICAgICAgICAgICAgICAgIHBvcnRzIHsKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgI3NpemUtY2VsbHMgPSA8MD47Cj4gKwo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLyogVVNCMiBQb3J0IDAgKi8KPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVzYjIwOiBwb3J0QDAgewo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZWcgPSA8MD47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBoeXMgPSA8JnVzYjJfcGh5MD47Cj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB9Owo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8qIFVT QjIgUG9ydCAxICovCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1c2IyMTogcG9y dEAxIHsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDE+ Owo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwaHlzID0gPCZ1c2Iy X3BoeTE+Owo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiArCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBVU0IzIFBvcnQgMCAqLwo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdXNiMzogcG9ydEA0IHsKPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmVnID0gPDQ+Owo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBwaHlzID0gPCZ1c2IzX3BjaWVfcGh5IFBIWV9UWVBFX1VTQjM+Owo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfTsKPiArICAgICAgICAgICAgICAgICAg ICAgICB9Owo+ICsKPiArICAgICAgICAgICAgICAgICAgICAgICBkd2MyOiB1c2JAZmY0MDAwMDAg ewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJhbWxvZ2lj LG1lc29uLWcxMmEtdXNiIiwgInNucHMsZHdjMiI7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICByZWcgPSA8MHgwIDB4ZmY0MDAwMDAgMHgwIDB4NDAwMDA+Owo+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW50ZXJydXB0cyA9IDxHSUNfU1BJIDMxIElSUV9UWVBFX0xF VkVMX0hJR0g+Owo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tzID0gPCZj bGtjIENMS0lEX1VTQjFfRERSX0JSSURHRT47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjbG9jay1uYW1lcyA9ICJkZHIiOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZHJfbW9kZSA9ICJwZXJpcGhlcmFsIjsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGctcngtZmlmby1zaXplID0gPDE5Mj47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBnLW5wLXR4LWZpZm8tc2l6ZSA9IDwxMjg+Owo+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZy10eC1maWZvLXNpemUgPSA8MTI4IDEyOCAxNiAxNiAxNj47Cj4gKyAgICAgICAg ICAgICAgICAgICAgICAgfTsKeW91IHN1Z2dlc3RlZCAob2ZmLWxpc3QpIHRoYXQgdGhlIE9URyBj YXBhYmxlIFBIWSBzaG91bGQgYmUgcGFzc2VkIHRvCnRoZSBkd2MyIGluc3RhbmNlCkknbSBhd2Fy ZSB0aGF0IHRoaXMgaXMgYW4gZXhhbXBsZSAtIGNvdWxkIHlvdSBwbGVhc2Ugc3RpbGwgYWRkIGl0 IGZvcgpjb25zaXN0ZW5jeT8KCj4gKwo+ICsgICAgICAgICAgICAgICAgICAgICAgIGR3YzM6IGR3 YzNAZmY1MDAwMDAgewo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJs ZSA9ICJzbnBzLGR3YzMiOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVnID0g PDB4MCAweGZmNTAwMDAwIDB4MCAweDEwMDAwMD47Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMzAgSVJRX1RZUEVfTEVWRUxfSElHSD47Cj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkcl9tb2RlID0gImhvc3QiOwo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgc25wcyxkaXNfdTJfc3VzcGh5X3F1aXJrOwo+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc25wcyxxdWlyay1mcmFtZS1sZW5ndGgtYWRq dXN0bWVudDsKPiArICAgICAgICAgICAgICAgICAgICAgICB9OwptYXliZSB0aGUgcGh5cyBzaG91 bGQgYWxzbyBiZSBwYXNzZWQgdG8gdGhlIGR3YzMgaW5zdGFuY2U/CgoKUmVnYXJkcwpNYXJ0aW4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01751C00319 for ; Sun, 24 Feb 2019 19:53:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4C2D20663 for ; Sun, 24 Feb 2019 19:53:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ia/28hRO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="s4q6dvmV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4C2D20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lH8NTj7JkBusNm7iwbrf5D299OTMQN2JY8aBQsk8mTI=; b=Ia/28hRO4U6oUi FAQdOA6PZo2tnQsjdE9ODj4yJWZhUu6y25Q5EwP5IQhPmf0QxBXEG4pPdIloE6vGACUnPZgRbt1fj GMVAUtNBLC2md6+D/M+MdqSRo2TM5B61hxf8Mx6/qsQ5TtiTs3zzGVYPUe3jjuGFval1iIt9RA3ad HY7eazXDBp+y3txnvdwDV5pCQ2vjnqiaWdBCu0W8DR9zJlaL3/ipFS5HrPw4ZjfSbCnt8xhEnYHAE xLrVzq9s/5gCbMjkDfyKqWryr/4gsUXrlJNY6a+jktnF7OJOUOPjsR7TCnkAuzkAQ1v54fudU8A8z sMKv0qwHwbRkYjBFO+0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxzpZ-0001fe-BI; Sun, 24 Feb 2019 19:52:57 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxzpV-0001eU-35; Sun, 24 Feb 2019 19:52:54 +0000 Received: by mail-oi1-x243.google.com with SMTP id u128so5658327oie.2; Sun, 24 Feb 2019 11:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MYQcmmvOWPoSOeQLQkGxZasGkeWzPpVbLTX8A4pezEg=; b=s4q6dvmV8vzyo06grp4cC+jC04xPsR8+JpkdIPVXUy45VgdXNnGRcaFxBKuURWkBUb p6ddlpeIaURXH91qcCtIpHOiUmVD40NLv0LSb70q48NMh76kJN2Wo2gxhAVec670W47K 28uZyPp1Shy73IVAlvqvGGQ+HIJQ6WTGqvXdLczF/p4YhxpDHYV++DtYdU6RdP2ZQv2t uoWynKM/57sKPB592SsOLBeByczmtqnsHCeh1hYh7tZCrHIcS8mRZ7SLQfBvaiZKxWL/ zLsvaB+7A4IXljqaoQrEHDKEMfMfmg54USMV1rBVp1mxyYAuoxw4lGrUrw/a8U+uJioj SUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MYQcmmvOWPoSOeQLQkGxZasGkeWzPpVbLTX8A4pezEg=; b=erxl3/Uvf9O0B5t6GF8uwuKBPV+7OWbxyB+11iGb/aS0sMOsNul0pR6jNI4cScxHrl AA1aDD1dBW1q2T2XFJQxI6IhN4vbkscaLTNgPaRRH16zPZMYKnS+xw1wrGv4xxEobgvP v3ixcAuFMMUdLBvfQOgIpeVRG9d7mthCnV8ZoyLFISDEm9+mSA/tdEW2xAhlUF0ZR3Kg fDawdvrKfX+sgd7k1bjF8o3cBEfefb+W4yUt9ElPrqOqgudpvAIUvsGhz/hMakMSiSNN X1T4Nmd+qPZn9qd3QiURcMcpAdyMfdLAJjWdAhV7BuBAneZkQ6bRSwh6mfq2N7WkJiRS Yf9g== X-Gm-Message-State: AHQUAuZt0BthRsDFMntaajAubuUMl5WCCkk36fmiobU5pxuiw/k9Gh2D +FxibrTA4NMXN/5tHc3gLAxwnvBQoBmDtAK6USo= X-Google-Smtp-Source: AHgI3IbIeKx3wATaNvdtt2nNjW6v0A+ktUiVw6Fniny1gw2+4boGchyewPpYn/tjfrbZtpEjSJl6SsL2In8Jigb70hE= X-Received: by 2002:aca:5d87:: with SMTP id r129mr9232994oib.39.1551037971667; Sun, 24 Feb 2019 11:52:51 -0800 (PST) MIME-Version: 1.0 References: <20190212151413.24632-1-narmstrong@baylibre.com> <20190212151413.24632-5-narmstrong@baylibre.com> In-Reply-To: <20190212151413.24632-5-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Sun, 24 Feb 2019 20:52:40 +0100 Message-ID: Subject: Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190224_115253_159167_8210C666 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Neil, On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong wrote: [...] > + > +Example device nodes: > + usb: usb@ffe09000 { > + compatible = "amlogic,meson-g12a-usb-ctrl"; > + reg = <0x0 0xffe09000 0x0 0xa0>; > + interrupts = ; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + clocks = <&clkc CLKID_USB>; > + clock-names = "usb"; > + resets = <&reset RESET_USB>; > + reset-names = "usb"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* USB2 Port 0 */ > + usb20: port@0 { > + reg = <0>; > + phys = <&usb2_phy0>; > + }; > + > + /* USB2 Port 1 */ > + usb21: port@1 { > + reg = <1>; > + phys = <&usb2_phy1>; > + }; > + > + /* USB3 Port 0 */ > + usb3: port@4 { > + reg = <4>; > + phys = <&usb3_pcie_phy PHY_TYPE_USB3>; > + }; > + }; > + > + dwc2: usb@ff400000 { > + compatible = "amlogic,meson-g12a-usb", "snps,dwc2"; > + reg = <0x0 0xff400000 0x0 0x40000>; > + interrupts = ; > + clocks = <&clkc CLKID_USB1_DDR_BRIDGE>; > + clock-names = "ddr"; > + dr_mode = "peripheral"; > + g-rx-fifo-size = <192>; > + g-np-tx-fifo-size = <128>; > + g-tx-fifo-size = <128 128 16 16 16>; > + }; you suggested (off-list) that the OTG capable PHY should be passed to the dwc2 instance I'm aware that this is an example - could you please still add it for consistency? > + > + dwc3: dwc3@ff500000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0xff500000 0x0 0x100000>; > + interrupts = ; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment; > + }; maybe the phys should also be passed to the dwc3 instance? Regards Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA867C43381 for ; Sun, 24 Feb 2019 19:53:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A55620663 for ; Sun, 24 Feb 2019 19:53:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IvXoc/YS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="s4q6dvmV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A55620663 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oE+/9icOhnDSTAyArDK2xZE78jxuQ6rXiSCSqrus1vw=; b=IvXoc/YSqwsPSN sPRvJb069jpvUV617iFw2YdkV/Kk70SVVHt+zQV3c54nbFxDdq07+XP43XKEP15o+/02/vWCzS1Ag XreFPf2dBuWakunSxCoHDuDWBq4AZoCdKUL89ZIQB1mMyiHOLBZmrMGmxj/3P0tmqY6XYoJg/NgyO ZGCrz4frf3vHkIl0B7VacOk42tll1FC/K9ym9hVYebB1bmlMFgAJNgzBVclE7aHF9rheRi1lcFPq0 j/sd9f4QOnkqQDWCF8WgGp8jJoFbkqjCcRsIF2SdgofUsM9sFfptr/dZxcHs6fU0ZosYn4tl9OSYH WNk4wzE3vLSzJYInY1ww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxzpY-0001ez-4g; Sun, 24 Feb 2019 19:52:56 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gxzpV-0001eU-35; Sun, 24 Feb 2019 19:52:54 +0000 Received: by mail-oi1-x243.google.com with SMTP id u128so5658327oie.2; Sun, 24 Feb 2019 11:52:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MYQcmmvOWPoSOeQLQkGxZasGkeWzPpVbLTX8A4pezEg=; b=s4q6dvmV8vzyo06grp4cC+jC04xPsR8+JpkdIPVXUy45VgdXNnGRcaFxBKuURWkBUb p6ddlpeIaURXH91qcCtIpHOiUmVD40NLv0LSb70q48NMh76kJN2Wo2gxhAVec670W47K 28uZyPp1Shy73IVAlvqvGGQ+HIJQ6WTGqvXdLczF/p4YhxpDHYV++DtYdU6RdP2ZQv2t uoWynKM/57sKPB592SsOLBeByczmtqnsHCeh1hYh7tZCrHIcS8mRZ7SLQfBvaiZKxWL/ zLsvaB+7A4IXljqaoQrEHDKEMfMfmg54USMV1rBVp1mxyYAuoxw4lGrUrw/a8U+uJioj SUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MYQcmmvOWPoSOeQLQkGxZasGkeWzPpVbLTX8A4pezEg=; b=erxl3/Uvf9O0B5t6GF8uwuKBPV+7OWbxyB+11iGb/aS0sMOsNul0pR6jNI4cScxHrl AA1aDD1dBW1q2T2XFJQxI6IhN4vbkscaLTNgPaRRH16zPZMYKnS+xw1wrGv4xxEobgvP v3ixcAuFMMUdLBvfQOgIpeVRG9d7mthCnV8ZoyLFISDEm9+mSA/tdEW2xAhlUF0ZR3Kg fDawdvrKfX+sgd7k1bjF8o3cBEfefb+W4yUt9ElPrqOqgudpvAIUvsGhz/hMakMSiSNN X1T4Nmd+qPZn9qd3QiURcMcpAdyMfdLAJjWdAhV7BuBAneZkQ6bRSwh6mfq2N7WkJiRS Yf9g== X-Gm-Message-State: AHQUAuZt0BthRsDFMntaajAubuUMl5WCCkk36fmiobU5pxuiw/k9Gh2D +FxibrTA4NMXN/5tHc3gLAxwnvBQoBmDtAK6USo= X-Google-Smtp-Source: AHgI3IbIeKx3wATaNvdtt2nNjW6v0A+ktUiVw6Fniny1gw2+4boGchyewPpYn/tjfrbZtpEjSJl6SsL2In8Jigb70hE= X-Received: by 2002:aca:5d87:: with SMTP id r129mr9232994oib.39.1551037971667; Sun, 24 Feb 2019 11:52:51 -0800 (PST) MIME-Version: 1.0 References: <20190212151413.24632-1-narmstrong@baylibre.com> <20190212151413.24632-5-narmstrong@baylibre.com> In-Reply-To: <20190212151413.24632-5-narmstrong@baylibre.com> From: Martin Blumenstingl Date: Sun, 24 Feb 2019 20:52:40 +0100 Message-ID: Subject: Re: [PATCH 4/8] dt-bindings: usb: dwc3: Add Amlogic G12A DWC3 Glue Bindings To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190224_115253_159167_8210C666 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, hminas@synopsys.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Neil, On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong wrote: [...] > + > +Example device nodes: > + usb: usb@ffe09000 { > + compatible = "amlogic,meson-g12a-usb-ctrl"; > + reg = <0x0 0xffe09000 0x0 0xa0>; > + interrupts = ; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + clocks = <&clkc CLKID_USB>; > + clock-names = "usb"; > + resets = <&reset RESET_USB>; > + reset-names = "usb"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* USB2 Port 0 */ > + usb20: port@0 { > + reg = <0>; > + phys = <&usb2_phy0>; > + }; > + > + /* USB2 Port 1 */ > + usb21: port@1 { > + reg = <1>; > + phys = <&usb2_phy1>; > + }; > + > + /* USB3 Port 0 */ > + usb3: port@4 { > + reg = <4>; > + phys = <&usb3_pcie_phy PHY_TYPE_USB3>; > + }; > + }; > + > + dwc2: usb@ff400000 { > + compatible = "amlogic,meson-g12a-usb", "snps,dwc2"; > + reg = <0x0 0xff400000 0x0 0x40000>; > + interrupts = ; > + clocks = <&clkc CLKID_USB1_DDR_BRIDGE>; > + clock-names = "ddr"; > + dr_mode = "peripheral"; > + g-rx-fifo-size = <192>; > + g-np-tx-fifo-size = <128>; > + g-tx-fifo-size = <128 128 16 16 16>; > + }; you suggested (off-list) that the OTG capable PHY should be passed to the dwc2 instance I'm aware that this is an example - could you please still add it for consistency? > + > + dwc3: dwc3@ff500000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0xff500000 0x0 0x100000>; > + interrupts = ; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment; > + }; maybe the phys should also be passed to the dwc3 instance? Regards Martin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic