From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755002AbdCITiB (ORCPT ); Thu, 9 Mar 2017 14:38:01 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36671 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbdCITh7 (ORCPT ); Thu, 9 Mar 2017 14:37:59 -0500 MIME-Version: 1.0 In-Reply-To: References: <1488918961-4666-1-git-send-email-linux.amoon@gmail.com> <0204bbde-c437-e11b-cb3b-d9f4b55a5810@baylibre.com> From: Martin Blumenstingl Date: Thu, 9 Mar 2017 20:36:52 +0100 Message-ID: Subject: Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes To: Anand Moon Cc: Neil Armstrong , devicetree , Kevin Hilman , Linux Kernel , Rob Herring , Carlo Caione , linux-amlogic@lists.infradead.org, Brian Kim , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anand, On Thu, Mar 9, 2017 at 6:58 PM, Anand Moon wrote: >> Hi Anand, >> >> For this specific use case, the only way to manage this is to use the Work-In-Progress >> Power Sequence Library proposer by Peter Chen at : >> https://lkml.org/lkml/2016/11/13/315 >> >> Since this is the USB Hub reset link and has no direct link with either the USB controller >> or the USB PHY, and the USB Hus cannot be modeled (yet ?) in the DT. >> >> One intermediate, but crappy, solution would be to add a GPIO hog until the power >> sequence code has been merged, with a proper big fat warning in the dts file. >> >> You can find doc about the gpio-hog in : >> Documentation/devicetree/bindings/gpio/gpio.txt >> >> It should look like : >> >> usb-hub { >> gpio-hog; >> gpios = ; >> output-high; >> line-name = "usb-hub-reset"; >> }; >> >> in the gpio_ao controller node. >> >> Neil > > Thanks for this input. > > I will check this series of patches, and work on this new approach. you might want to look at the following two patches as well: [0] and [1] I didn't test them as I don't have an Odroid-C2 but they should work with the series that Neil has mentioned. feel free to take my patches and fix them where needed Regards, Martin [0] https://github.com/xdarklight/linux/commit/f0bc8f826b465fbf24279ce78654b65282790dc6 [1] https://github.com/xdarklight/linux/commit/7b5a69bf5bad992249aa39a96360fe90ccde9cd5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Subject: Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes Date: Thu, 9 Mar 2017 20:36:52 +0100 Message-ID: References: <1488918961-4666-1-git-send-email-linux.amoon@gmail.com> <0204bbde-c437-e11b-cb3b-d9f4b55a5810@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Anand Moon Cc: Neil Armstrong , devicetree , Kevin Hilman , Linux Kernel , Rob Herring , Carlo Caione , linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Brian Kim , linux-arm-kernel List-Id: devicetree@vger.kernel.org Hi Anand, On Thu, Mar 9, 2017 at 6:58 PM, Anand Moon wrote: >> Hi Anand, >> >> For this specific use case, the only way to manage this is to use the Work-In-Progress >> Power Sequence Library proposer by Peter Chen at : >> https://lkml.org/lkml/2016/11/13/315 >> >> Since this is the USB Hub reset link and has no direct link with either the USB controller >> or the USB PHY, and the USB Hus cannot be modeled (yet ?) in the DT. >> >> One intermediate, but crappy, solution would be to add a GPIO hog until the power >> sequence code has been merged, with a proper big fat warning in the dts file. >> >> You can find doc about the gpio-hog in : >> Documentation/devicetree/bindings/gpio/gpio.txt >> >> It should look like : >> >> usb-hub { >> gpio-hog; >> gpios = ; >> output-high; >> line-name = "usb-hub-reset"; >> }; >> >> in the gpio_ao controller node. >> >> Neil > > Thanks for this input. > > I will check this series of patches, and work on this new approach. you might want to look at the following two patches as well: [0] and [1] I didn't test them as I don't have an Odroid-C2 but they should work with the series that Neil has mentioned. feel free to take my patches and fix them where needed Regards, Martin [0] https://github.com/xdarklight/linux/commit/f0bc8f826b465fbf24279ce78654b65282790dc6 [1] https://github.com/xdarklight/linux/commit/7b5a69bf5bad992249aa39a96360fe90ccde9cd5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin.blumenstingl@googlemail.com (Martin Blumenstingl) Date: Thu, 9 Mar 2017 20:36:52 +0100 Subject: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes In-Reply-To: References: <1488918961-4666-1-git-send-email-linux.amoon@gmail.com> <0204bbde-c437-e11b-cb3b-d9f4b55a5810@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Anand, On Thu, Mar 9, 2017 at 6:58 PM, Anand Moon wrote: >> Hi Anand, >> >> For this specific use case, the only way to manage this is to use the Work-In-Progress >> Power Sequence Library proposer by Peter Chen at : >> https://lkml.org/lkml/2016/11/13/315 >> >> Since this is the USB Hub reset link and has no direct link with either the USB controller >> or the USB PHY, and the USB Hus cannot be modeled (yet ?) in the DT. >> >> One intermediate, but crappy, solution would be to add a GPIO hog until the power >> sequence code has been merged, with a proper big fat warning in the dts file. >> >> You can find doc about the gpio-hog in : >> Documentation/devicetree/bindings/gpio/gpio.txt >> >> It should look like : >> >> usb-hub { >> gpio-hog; >> gpios = ; >> output-high; >> line-name = "usb-hub-reset"; >> }; >> >> in the gpio_ao controller node. >> >> Neil > > Thanks for this input. > > I will check this series of patches, and work on this new approach. you might want to look at the following two patches as well: [0] and [1] I didn't test them as I don't have an Odroid-C2 but they should work with the series that Neil has mentioned. feel free to take my patches and fix them where needed Regards, Martin [0] https://github.com/xdarklight/linux/commit/f0bc8f826b465fbf24279ce78654b65282790dc6 [1] https://github.com/xdarklight/linux/commit/7b5a69bf5bad992249aa39a96360fe90ccde9cd5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin.blumenstingl@googlemail.com (Martin Blumenstingl) Date: Thu, 9 Mar 2017 20:36:52 +0100 Subject: [PATCH] ARM64: dts: meson-gxbb-odroidc2: enable USB Host Nodes In-Reply-To: References: <1488918961-4666-1-git-send-email-linux.amoon@gmail.com> <0204bbde-c437-e11b-cb3b-d9f4b55a5810@baylibre.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Hi Anand, On Thu, Mar 9, 2017 at 6:58 PM, Anand Moon wrote: >> Hi Anand, >> >> For this specific use case, the only way to manage this is to use the Work-In-Progress >> Power Sequence Library proposer by Peter Chen at : >> https://lkml.org/lkml/2016/11/13/315 >> >> Since this is the USB Hub reset link and has no direct link with either the USB controller >> or the USB PHY, and the USB Hus cannot be modeled (yet ?) in the DT. >> >> One intermediate, but crappy, solution would be to add a GPIO hog until the power >> sequence code has been merged, with a proper big fat warning in the dts file. >> >> You can find doc about the gpio-hog in : >> Documentation/devicetree/bindings/gpio/gpio.txt >> >> It should look like : >> >> usb-hub { >> gpio-hog; >> gpios = ; >> output-high; >> line-name = "usb-hub-reset"; >> }; >> >> in the gpio_ao controller node. >> >> Neil > > Thanks for this input. > > I will check this series of patches, and work on this new approach. you might want to look at the following two patches as well: [0] and [1] I didn't test them as I don't have an Odroid-C2 but they should work with the series that Neil has mentioned. feel free to take my patches and fix them where needed Regards, Martin [0] https://github.com/xdarklight/linux/commit/f0bc8f826b465fbf24279ce78654b65282790dc6 [1] https://github.com/xdarklight/linux/commit/7b5a69bf5bad992249aa39a96360fe90ccde9cd5