From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52A5AC433E1 for ; Mon, 27 Jul 2020 17:50:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3595D20714 for ; Mon, 27 Jul 2020 17:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="jLtvF/aQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731056AbgG0RuD (ORCPT ); Mon, 27 Jul 2020 13:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726846AbgG0RuC (ORCPT ); Mon, 27 Jul 2020 13:50:02 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 425DEC061794; Mon, 27 Jul 2020 10:50:02 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id kq25so5002746ejb.3; Mon, 27 Jul 2020 10:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E3P4kvBv8Rleuknjs/EKTdnAw0nGwmEOuGwij7lqxeU=; b=jLtvF/aQ5RtTONzbSrQDOZ1CQZgDhxf9HDJmnPZud7lgph0ilkpZaU78GtBhDuvd/2 XmfXbx35DAI4/SglbNcNHF7h7zU7e4p0cA0f0vciUXtNUk85F31iGXiz12kBr4+fWgRD hb+sgtPHobb0bF263fhJxgjNXPA4nZiC0u01RdMJ7iuCtNx9s8Wrvl2lOVSatGcBy6Y7 SWxtFNAI6SpEcTTrI96iv1FIfoF6atpJdLZ4tM/SjnLDB5flQ6szb6JfblsDE3BNMXVY wbvsp0o3+hXk3D4C2T0BZgwg2apRKpQYk/XrcaLxEAIr98Y9MMoaRATEJKcwDv8Sgoh8 61aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E3P4kvBv8Rleuknjs/EKTdnAw0nGwmEOuGwij7lqxeU=; b=scPW5OJ+TZB6P9OGsHPw9eOKm/5HGVx1OkeXDIMEhmHLzFqxa6y43eMdC0M667F7QA pgPafJ2aQaO1U4aaTSl1idTP/wWm3MzAHO+BCKuJXXP5GwS1Bhh/UDiSik7//zgwBttx scam5ZEIwdkcQvsGk9BN4Vch2lT7t6UzK0jxanLEKa8yLT93GRVMA3mZwojLcyWz/GxG 0jPDEFRkoVeTmxopeBpM7WApNMnaeAfNKp1ARMIOLgIkU0pMT5jnZkkU/L9nY5IS7KvO BwVbHxK3E7MP+X95dqiDSZCK2momCMk3y4xDvh4+vnLus6Ruu011gxRZGeQPs/UqoR4R yQ1w== X-Gm-Message-State: AOAM531vIlPzU+ntyTBtN/hJcAmlw9nTbFQFf6g1zH7Ztv9CR6soszwm q7qrC5oKiGTuvzDp9lqef9lVhv95TMs8gbUiI24= X-Google-Smtp-Source: ABdhPJx00cueCvmkr54gaDTC1tq+EK0jdh4p/C2xAIh4A01uMkWJLB4IiShofhBWPvcEAq/5YL+6MG9izDKcQfaj+q4= X-Received: by 2002:a17:906:aad2:: with SMTP id kt18mr4042699ejb.537.1595872200937; Mon, 27 Jul 2020 10:50:00 -0700 (PDT) MIME-Version: 1.0 References: <20200727092346.19780-1-amelie.delaunay@st.com> <20200727092346.19780-4-amelie.delaunay@st.com> In-Reply-To: <20200727092346.19780-4-amelie.delaunay@st.com> From: Martin Blumenstingl Date: Mon, 27 Jul 2020 19:49:50 +0200 Message-ID: Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs To: Amelie Delaunay Cc: Minas Harutyunyan , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Maxime Coquelin , Alexandre Torgue , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Fabrice Gasnier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Amelie, On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay wrote: [...] > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index a3611cdd1dea..65f8596f6795 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -183,9 +183,11 @@ static void dwc2_set_stm32mp15_fsotg_params(struct dwc2_hsotg *hsotg) > static void dwc2_set_stm32mp15_hsotg_params(struct dwc2_hsotg *hsotg) > { > struct dwc2_core_params *p = &hsotg->params; > + struct device_node *np = hsotg->dev->of_node; > > p->otg_cap = DWC2_CAP_PARAM_NO_HNP_SRP_CAPABLE; > - p->activate_stm_id_vb_detection = true; > + p->activate_stm_id_vb_detection = > + !of_property_read_bool(np, "usb-role-switch"); the rest of params.c uses device_property_read_* instead of of_read_property_* I thought I'd mention it so you can decide yourself whether this is fine or needs to be changed Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ACFAC433E0 for ; Mon, 27 Jul 2020 17:51:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A7E32070B for ; Mon, 27 Jul 2020 17:51:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lYKaIQdz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="jLtvF/aQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A7E32070B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1DX+3DEMr88b28slVuL0XepOFBDgD/Uw9HVuIHQ9B9w=; b=lYKaIQdzJIfIbbh7LasoWyuhh ReqtX5b2/1DLU4P7vfU54yU2A+pzfgGS56JYkq8hF3Lds0lYT5znA/voYkT1e5+jyhKnRdMKtEiFU eYFATekhx2LthplAkmQTpe3wk0Tq0kXmsBdlZeCeGMTfGIseM9sOeyzn+OVSLzuGxs4rmakK/Bkty duBEdqeO91Dv/rjDDXHk89ysQTme42y+YZWNIeh8kpkqlzUlHPLft+LUfCmRtPuzcJTYKCE4EZfAY RTOcaowJwya4eeOuVdKF+RcDYpMwogM2GHAMrtgEEzQQRx6OhNlibZqsxX/CbF8m+vs8qnknhNz7k gg3lEYXqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k07GG-0003Fr-1A; Mon, 27 Jul 2020 17:50:04 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k07GD-0003FD-VI for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 17:50:02 +0000 Received: by mail-ej1-x641.google.com with SMTP id o18so17921404eje.7 for ; Mon, 27 Jul 2020 10:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E3P4kvBv8Rleuknjs/EKTdnAw0nGwmEOuGwij7lqxeU=; b=jLtvF/aQ5RtTONzbSrQDOZ1CQZgDhxf9HDJmnPZud7lgph0ilkpZaU78GtBhDuvd/2 XmfXbx35DAI4/SglbNcNHF7h7zU7e4p0cA0f0vciUXtNUk85F31iGXiz12kBr4+fWgRD hb+sgtPHobb0bF263fhJxgjNXPA4nZiC0u01RdMJ7iuCtNx9s8Wrvl2lOVSatGcBy6Y7 SWxtFNAI6SpEcTTrI96iv1FIfoF6atpJdLZ4tM/SjnLDB5flQ6szb6JfblsDE3BNMXVY wbvsp0o3+hXk3D4C2T0BZgwg2apRKpQYk/XrcaLxEAIr98Y9MMoaRATEJKcwDv8Sgoh8 61aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E3P4kvBv8Rleuknjs/EKTdnAw0nGwmEOuGwij7lqxeU=; b=e1r8RDVFyedgYcxnYcmH3eW8CvBgQajfN1B8a2ULzvz+tKnaO8z/TPrt5IG9V7+6zB 8TiXn7SPHbPLrAel3ydF2R9lVgjWno9kf3VMcO5Eis+r9F+a3U3I+b6Zyg8km3FwYx6t sMaohEyQ39Z4dBF1ORNvTb5vOdwmylRi9savyR60FJnbeADZqf7q0zAo7L4MR/BqoH3+ UXJFxuc8AyqbsTucHeaACRtoC2i+WocNbTqicazABc7Ktc652YSSNHnoPMm8BKy9sb0F YBxi7bMbR5ir2EnL0GE2mcbrVg1iKB0CSaW1pc9dUSWEW1lhdOfMM7w5DUbCyXpriNgA 7JTQ== X-Gm-Message-State: AOAM530W9uFI70cIlElMfVdX5fUpUgeCuQEVlBYfOQPFZtiPvJr5bVr0 jwwDOuL3SUDVmSxere11KCL2+YhfnC/9ByTqcN8= X-Google-Smtp-Source: ABdhPJx00cueCvmkr54gaDTC1tq+EK0jdh4p/C2xAIh4A01uMkWJLB4IiShofhBWPvcEAq/5YL+6MG9izDKcQfaj+q4= X-Received: by 2002:a17:906:aad2:: with SMTP id kt18mr4042699ejb.537.1595872200937; Mon, 27 Jul 2020 10:50:00 -0700 (PDT) MIME-Version: 1.0 References: <20200727092346.19780-1-amelie.delaunay@st.com> <20200727092346.19780-4-amelie.delaunay@st.com> In-Reply-To: <20200727092346.19780-4-amelie.delaunay@st.com> From: Martin Blumenstingl Date: Mon, 27 Jul 2020 19:49:50 +0200 Message-ID: Subject: Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs To: Amelie Delaunay X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_135002_114966_3CFF8CB7 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Alexandre Torgue , devicetree@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Maxime Coquelin , Minas Harutyunyan , Fabrice Gasnier , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Amelie, On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay wrote: [...] > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index a3611cdd1dea..65f8596f6795 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -183,9 +183,11 @@ static void dwc2_set_stm32mp15_fsotg_params(struct dwc2_hsotg *hsotg) > static void dwc2_set_stm32mp15_hsotg_params(struct dwc2_hsotg *hsotg) > { > struct dwc2_core_params *p = &hsotg->params; > + struct device_node *np = hsotg->dev->of_node; > > p->otg_cap = DWC2_CAP_PARAM_NO_HNP_SRP_CAPABLE; > - p->activate_stm_id_vb_detection = true; > + p->activate_stm_id_vb_detection = > + !of_property_read_bool(np, "usb-role-switch"); the rest of params.c uses device_property_read_* instead of of_read_property_* I thought I'd mention it so you can decide yourself whether this is fine or needs to be changed Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel