All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Meng Tang <tangmeng@uniontech.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
	luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3 2/2] Bluetooth: btrtl: btmrvl: Fix firmware filename for some rtl chipsets
Date: Tue, 15 Mar 2022 19:52:46 +0100	[thread overview]
Message-ID: <CAFBinCCZ7Hqq=dSSYtd5UL8NyZMu5q2jJiTJkdTupwUy8yy5GQ@mail.gmail.com> (raw)
In-Reply-To: <20220315095129.15254-2-tangmeng@uniontech.com>

Hi,

On Tue, Mar 15, 2022 at 10:52 AM Meng Tang <tangmeng@uniontech.com> wrote:
>
> Firmware for rtl chipset is as part of the linux-firmware repository
> in dir linux-firmware/rtl_bt. Today, the rtl8761a_config,
> rtl8821a_config and rtl8723b_config files are used in btrtl, but it
> doesn't actually exist, which causes errors like:
>
> bluetooth: Direct firmware load for rtl_bt/rtl8821a_config.bin
> failed with error -2
These config files can be board specific. I don't know the policy for
MODULE_FIRMWARE macros.
Personally I think: if the driver tries to load a specific firmware
file then it's fine to have a MODULE_FIRMWARE entry. Even if this
firmware is not part of the linux-firmware repository.


Best regards,
Martin

  reply	other threads:[~2022-03-15 18:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  9:51 [PATCH v3 1/2] Bluetooth: btrtl: btmrvl: Fix firmware filename for rtl8723bs chipset Meng Tang
2022-03-15  9:51 ` [PATCH v3 2/2] Bluetooth: btrtl: btmrvl: Fix firmware filename for some rtl chipsets Meng Tang
2022-03-15 18:52   ` Martin Blumenstingl [this message]
2022-03-16 15:30   ` Marcel Holtmann
2022-03-15 11:04 ` [v3,1/2] Bluetooth: btrtl: btmrvl: Fix firmware filename for rtl8723bs chipset bluez.test.bot
2022-03-15 18:49 ` [PATCH v3 1/2] " Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFBinCCZ7Hqq=dSSYtd5UL8NyZMu5q2jJiTJkdTupwUy8yy5GQ@mail.gmail.com' \
    --to=martin.blumenstingl@googlemail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=tangmeng@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.