From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCCE9C433F5 for ; Tue, 31 May 2022 20:00:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 02C6310E24E; Tue, 31 May 2022 20:00:16 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F36610E24E for ; Tue, 31 May 2022 20:00:15 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id rs12so28653831ejb.13 for ; Tue, 31 May 2022 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=BfAzztMNm1Jp/TdVi0t4iVReEv4ID5XLse+uh2O08vd5p45IIiN2ru9VwuJU6Um5Nv 0qh6aXb3IQyqKe5AJz5SZ3TUw59Bs/A9IZpkkj26xiglqeckNDZL6KrBNR2L9m0gzOW9 xN8FWpowprhXG7MbtRfuG5IEYYtXp1UOcQ2cjuare7jC91K6A1IVfw9NE4TttMwgjjjN mkiznqExdK01IwGOBpobCBk5lXWvmApbyMdx+Zp6iOQuLn696fC3m+i1EsKvqenaRQXY jia0fUobMIA/yV+n357zIRHHq3K9HD5P47G3l49XAHkYdD/+A/ITVdWhi2yroIFq60s2 mgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=Kju3YWb9mILBV9DqSIBN+zUhQ3mNv9P2boZWnMRqCYnrIUrPIDI5RCEJCwTjhm2VyB PozpOOFs/CcDptfDoI4OXSGCIw9b+9hryLZ6362RZ2d/gznBsUE3fAaWMIFENRHGm1y8 6V7O671d+28jOqTjOv5Wjcqb3SRYUhF/SnvDdSuV0pRSE3JPAsPKN44DAjrZNR7zAeFW F14UyH1WRHZUJDjZtjGpxLzO1wl8mPczHm1FLIbmjHSvJdTdQ1wqDTAKeeE0W1TjMMVJ PXQ1RHCwp7919GX9rjOo+vY+m8sYmKe5mMFo8E0w1lJB8OhykeyBAMfVjG67vUteZnTx O8Dw== X-Gm-Message-State: AOAM533BAdlbab5jSdghjwu+W9CjFvANew3b1GveqPWeEnWRNr5jevVF 9fqU6+KgM4Vu17VGcDBgtHeCXi1GzspI0B+f2dv7g9t16Jc= X-Google-Smtp-Source: ABdhPJy10QXI2/ZkHtl9TZrO9ctuZkG39qUaTuGRRuWnMdaywHiIXFoOLxMbU2TIJIGuNyp5YTDWSwDcDQgsRT5WYgM= X-Received: by 2002:a17:907:381:b0:6fe:9ca8:c4b4 with SMTP id ss1-20020a170907038100b006fe9ca8c4b4mr52565612ejb.147.1654027203570; Tue, 31 May 2022 13:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20220531144818.26943-1-linmq006@gmail.com> In-Reply-To: <20220531144818.26943-1-linmq006@gmail.com> From: Martin Blumenstingl Date: Tue, 31 May 2022 21:59:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init To: Miaoqian Lin Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Kevin Hilman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, Sam Ravnborg , linux-arm-kernel@lists.infradead.org, Jerome Brunet Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin wrote: > > of_graph_get_remote_node() returns remote device nodepointer with > refcount incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR") > Signed-off-by: Miaoqian Lin Reviewed-by: Martin Blumenstingl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E245CC433FE for ; Tue, 31 May 2022 20:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347596AbiEaUAZ (ORCPT ); Tue, 31 May 2022 16:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347617AbiEaUAU (ORCPT ); Tue, 31 May 2022 16:00:20 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1218FD6A for ; Tue, 31 May 2022 13:00:15 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id f21so28654261ejh.11 for ; Tue, 31 May 2022 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=BfAzztMNm1Jp/TdVi0t4iVReEv4ID5XLse+uh2O08vd5p45IIiN2ru9VwuJU6Um5Nv 0qh6aXb3IQyqKe5AJz5SZ3TUw59Bs/A9IZpkkj26xiglqeckNDZL6KrBNR2L9m0gzOW9 xN8FWpowprhXG7MbtRfuG5IEYYtXp1UOcQ2cjuare7jC91K6A1IVfw9NE4TttMwgjjjN mkiznqExdK01IwGOBpobCBk5lXWvmApbyMdx+Zp6iOQuLn696fC3m+i1EsKvqenaRQXY jia0fUobMIA/yV+n357zIRHHq3K9HD5P47G3l49XAHkYdD/+A/ITVdWhi2yroIFq60s2 mgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=MLTIKN2TjfK5EgtNXr/b4W/RmyQ/kkAyjNQCS1BeIOXP1RW9jE5W1CE/xLra66YFHj LfTyEJ1w3Bj5UXBzeoMkNEMB4+xg2Lfm/oSTHQdd10hnIwMxunNfumeLWDs4jy2zvqGy 9I2CYtTWLE21Ft07voHhl/7K3nPPTfmE5JSGJbprvT1doannKzbQiOlZaVgVp6HN7Mdu ILCqrVUwrcS34y041GGhWeQRDH67c5vCAmzoeX4DXw+IvdnzUN/e/69sbazDCBKUWiLU +AFFan83CdQTlrCeNBMA4b85R4fJf/g9MS1m4lhH3vOPf1tfnV6Lfmr3a/DlQHFXm5gr BJTw== X-Gm-Message-State: AOAM53146IUSoxHzMvylBZqFHXHh3gNUN5Ntbz3o5hzMc7zL0ZYRiNki TZ/Qvuobmfq/frcBVtq8PG4cGbhAtiBmrWFlZ1sjRb2X0Rw= X-Google-Smtp-Source: ABdhPJy10QXI2/ZkHtl9TZrO9ctuZkG39qUaTuGRRuWnMdaywHiIXFoOLxMbU2TIJIGuNyp5YTDWSwDcDQgsRT5WYgM= X-Received: by 2002:a17:907:381:b0:6fe:9ca8:c4b4 with SMTP id ss1-20020a170907038100b006fe9ca8c4b4mr52565612ejb.147.1654027203570; Tue, 31 May 2022 13:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20220531144818.26943-1-linmq006@gmail.com> In-Reply-To: <20220531144818.26943-1-linmq006@gmail.com> From: Martin Blumenstingl Date: Tue, 31 May 2022 21:59:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init To: Miaoqian Lin Cc: Neil Armstrong , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin wrote: > > of_graph_get_remote_node() returns remote device nodepointer with > refcount incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR") > Signed-off-by: Miaoqian Lin Reviewed-by: Martin Blumenstingl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D71FC433F5 for ; Tue, 31 May 2022 20:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5RWBSqXLqfDrRT28p8OHsUIF74oUBYs48U0BKnZXTHw=; b=Y+WuSIUxv6sE+z GHbTz+Jjpi9powa7moQaI/0dU5ZAXcF3clmvl6M9hL3pnlSxY4IswBy4vpsvo2qRsw5ifgUPYNQI6 YHk21GzHK3t/O5/58QuauaiXe/8TslEi8huOZuQ5oxFSDOAWXHkgB/3iFRTkPUFAGhYBCuFbnZYo6 5vIagJjJN1WssKkA2sn+CrzbZT5+CY9F5x3zykoSggiH0lrm5L/8yM7jsHfZAgFqmVOtCnEj/+ZES BMN2LEWyJl8HrjboGnSXPxRu0Zs3lPIrMyQJJdoAvs7cl9B2wOOSgSg8fEGy1qhpc+9QREN6XJhDP k8f3cI0FlVFRlACeMGmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw82N-00CPQ0-IE; Tue, 31 May 2022 20:00:19 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw82K-00CPOW-Ty; Tue, 31 May 2022 20:00:18 +0000 Received: by mail-lf1-x12e.google.com with SMTP id a15so3944098lfb.9; Tue, 31 May 2022 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=BfAzztMNm1Jp/TdVi0t4iVReEv4ID5XLse+uh2O08vd5p45IIiN2ru9VwuJU6Um5Nv 0qh6aXb3IQyqKe5AJz5SZ3TUw59Bs/A9IZpkkj26xiglqeckNDZL6KrBNR2L9m0gzOW9 xN8FWpowprhXG7MbtRfuG5IEYYtXp1UOcQ2cjuare7jC91K6A1IVfw9NE4TttMwgjjjN mkiznqExdK01IwGOBpobCBk5lXWvmApbyMdx+Zp6iOQuLn696fC3m+i1EsKvqenaRQXY jia0fUobMIA/yV+n357zIRHHq3K9HD5P47G3l49XAHkYdD/+A/ITVdWhi2yroIFq60s2 mgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=PFtT0Veh9tJ7V2rWEjUXAGtE0pbi89qXiUJ2OONAI1dGAkCm1yF2P3zFoGrm+fRmNM nT5IrvlWtlrlTjzbleaKzfAf2tSuAvhqAOWAgzBSKp+bjy1SI8k/N10JM6O5JWDYan3w vgSXQVSUht0rBOQmU9oB5LZzIOLOs2/jflZM6+R5nFEdBEqfkpKyJL3PnN4yX64ivJ9A lD53BqOQgmW0lzG8sDhxsGRClOTC4G4rJk9JljIZYNrTCKPAXN8WJhqL4QVd5sH29BKX zNp/hydipVsNILBsZsN7lg0I1RoYrBUQh3k1SUoZexVuVD5PWce49AtLjcnAz0KFefmW 2leQ== X-Gm-Message-State: AOAM531Rgjmu+ogX8hq+LiGIm9kd2jkI5lM19FDs2uqy4kpqA1z6MSLP oLp4kW7F7O1zPg4PfB3fqvjIirVMM9YmBTjXeh/vRzCw4iw= X-Google-Smtp-Source: ABdhPJy10QXI2/ZkHtl9TZrO9ctuZkG39qUaTuGRRuWnMdaywHiIXFoOLxMbU2TIJIGuNyp5YTDWSwDcDQgsRT5WYgM= X-Received: by 2002:a17:907:381:b0:6fe:9ca8:c4b4 with SMTP id ss1-20020a170907038100b006fe9ca8c4b4mr52565612ejb.147.1654027203570; Tue, 31 May 2022 13:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20220531144818.26943-1-linmq006@gmail.com> In-Reply-To: <20220531144818.26943-1-linmq006@gmail.com> From: Martin Blumenstingl Date: Tue, 31 May 2022 21:59:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init To: Miaoqian Lin Cc: Neil Armstrong , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_130017_024054_AD341A29 X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin wrote: > > of_graph_get_remote_node() returns remote device nodepointer with > refcount incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR") > Signed-off-by: Miaoqian Lin Reviewed-by: Martin Blumenstingl _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AE35C43217 for ; Tue, 31 May 2022 20:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LhS46LNsu8Xii8YgGksWBI6VTUO+DKVFNJmZM9bQ0AU=; b=OzNQdCQbaF7vn6 tGfW5+ivVu+8efvTBDlgQCrgvF4eZsFTANhYn8JTIaxAhLFP/SY0Vf5jr3F52t8YVcole5RNQ4pxE 4QJd1Owy9cIU8nEcY6R7CcDeUnRwOGamMHcufWsijqkV3BO9cMPY4HcA73SMCrNokSkT2l7owauha Cgx4UyMIiu1FkmboC8rvwXnVIV3R842MQL03cOXQiAL775By2sAsAhdotSgRi9KRcc8hE7T1eHROv d7BdoE3PdW5RQ28xWrDgOiZknY6vddc+DpRXgqmxS92NokuF8Ldpniba8zm/g/PpzgA594Oyal23C Papih3u+uoACqeYLMU+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw82O-00CPQ6-Pw; Tue, 31 May 2022 20:00:20 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw82K-00CPOW-Ty; Tue, 31 May 2022 20:00:18 +0000 Received: by mail-lf1-x12e.google.com with SMTP id a15so3944098lfb.9; Tue, 31 May 2022 13:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=BfAzztMNm1Jp/TdVi0t4iVReEv4ID5XLse+uh2O08vd5p45IIiN2ru9VwuJU6Um5Nv 0qh6aXb3IQyqKe5AJz5SZ3TUw59Bs/A9IZpkkj26xiglqeckNDZL6KrBNR2L9m0gzOW9 xN8FWpowprhXG7MbtRfuG5IEYYtXp1UOcQ2cjuare7jC91K6A1IVfw9NE4TttMwgjjjN mkiznqExdK01IwGOBpobCBk5lXWvmApbyMdx+Zp6iOQuLn696fC3m+i1EsKvqenaRQXY jia0fUobMIA/yV+n357zIRHHq3K9HD5P47G3l49XAHkYdD/+A/ITVdWhi2yroIFq60s2 mgIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N/5hFp0lMWC4dYsgyS8F7d3AZ1PIyvtWlhq+Sm07wFE=; b=PFtT0Veh9tJ7V2rWEjUXAGtE0pbi89qXiUJ2OONAI1dGAkCm1yF2P3zFoGrm+fRmNM nT5IrvlWtlrlTjzbleaKzfAf2tSuAvhqAOWAgzBSKp+bjy1SI8k/N10JM6O5JWDYan3w vgSXQVSUht0rBOQmU9oB5LZzIOLOs2/jflZM6+R5nFEdBEqfkpKyJL3PnN4yX64ivJ9A lD53BqOQgmW0lzG8sDhxsGRClOTC4G4rJk9JljIZYNrTCKPAXN8WJhqL4QVd5sH29BKX zNp/hydipVsNILBsZsN7lg0I1RoYrBUQh3k1SUoZexVuVD5PWce49AtLjcnAz0KFefmW 2leQ== X-Gm-Message-State: AOAM531Rgjmu+ogX8hq+LiGIm9kd2jkI5lM19FDs2uqy4kpqA1z6MSLP oLp4kW7F7O1zPg4PfB3fqvjIirVMM9YmBTjXeh/vRzCw4iw= X-Google-Smtp-Source: ABdhPJy10QXI2/ZkHtl9TZrO9ctuZkG39qUaTuGRRuWnMdaywHiIXFoOLxMbU2TIJIGuNyp5YTDWSwDcDQgsRT5WYgM= X-Received: by 2002:a17:907:381:b0:6fe:9ca8:c4b4 with SMTP id ss1-20020a170907038100b006fe9ca8c4b4mr52565612ejb.147.1654027203570; Tue, 31 May 2022 13:00:03 -0700 (PDT) MIME-Version: 1.0 References: <20220531144818.26943-1-linmq006@gmail.com> In-Reply-To: <20220531144818.26943-1-linmq006@gmail.com> From: Martin Blumenstingl Date: Tue, 31 May 2022 21:59:52 +0200 Message-ID: Subject: Re: [PATCH 1/2] drm/meson: encoder_cvbs: Fix refcount leak in meson_encoder_cvbs_init To: Miaoqian Lin Cc: Neil Armstrong , David Airlie , Daniel Vetter , Kevin Hilman , Jerome Brunet , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_130017_024054_AD341A29 X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 31, 2022 at 4:49 PM Miaoqian Lin wrote: > > of_graph_get_remote_node() returns remote device nodepointer with > refcount incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 318ba02cd8a8 ("drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR") > Signed-off-by: Miaoqian Lin Reviewed-by: Martin Blumenstingl _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel