From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH 09/16] drm/amdkfd: Use wait_queue_t to implement event waiting Date: Wed, 25 Oct 2017 13:28:58 +0300 Message-ID: References: <1508545400-24338-1-git-send-email-Felix.Kuehling@amd.com> <1508545400-24338-10-git-send-email-Felix.Kuehling@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508545400-24338-10-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling Cc: Kent Russell , amd-gfx list T24gU2F0LCBPY3QgMjEsIDIwMTcgYXQgMzoyMyBBTSwgRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1 ZWhsaW5nQGFtZC5jb20+IHdyb3RlOgo+IFNpZ25lZC1vZmYtYnk6IEtlbnQgUnVzc2VsbCA8a2Vu dC5ydXNzZWxsQGFtZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRmVsaXggS3VlaGxpbmcgPEZlbGl4 Lkt1ZWhsaW5nQGFtZC5jb20+CgpJIHdvdWxkIGxpa2Ugc29tZSBtb3JlIGV4cGxhbmF0aW9uIGlu IHRoZSBjb21taXQgbWVzc2FnZSBhYm91dCB0aGlzIGNoYW5nZS4KLSBXaGF0IGlzIHRoZSBnZW5l cmFsIGlkZWEgaW4gdGhpcyBzb2x1dGlvbi4KLSBXaHkgaXQgd2FzIGRvbmUsIGkuZS4gd2hhdCBp cyB0aGUgaW1wcm92ZW1lbnQKVGhhbmtzLApPZGVkCgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5jIHwgNTMgKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9ldmVudHMuaCB8ICAzICst Cj4gIDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMzcgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5jCj4gaW5kZXggOTQ5YjgwYS4u ZjE3ODI0OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZXZl bnRzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZXZlbnRzLmMKPiBA QCAtMzMsMjIgKzMzLDEyIEBACj4gICNpbmNsdWRlIDxsaW51eC9kZXZpY2UuaD4KPgo+ICAvKgo+ IC0gKiBBIHRhc2sgY2FuIG9ubHkgYmUgb24gYSBzaW5nbGUgd2FpdF9xdWV1ZSBhdCBhIHRpbWUs IGJ1dCB3ZSBuZWVkIHRvIHN1cHBvcnQKPiAtICogd2FpdGluZyBvbiBtdWx0aXBsZSBldmVudHMg KGFueS9hbGwpLgo+IC0gKiBJbnN0ZWFkIG9mIGVhY2ggZXZlbnQgc2ltcGx5IGhhdmluZyBhIHdh aXRfcXVldWUgd2l0aCBzbGVlcGluZyB0YXNrcywgaXQKPiAtICogaGFzIGEgc2luZ2x5LWxpbmtl ZCBsaXN0IG9mIHRhc2tzLgo+IC0gKiBBIHRocmVhZCB0aGF0IHdhbnRzIHRvIHNsZWVwIGNyZWF0 ZXMgYW4gYXJyYXkgb2YgdGhlc2UsIG9uZSBmb3IgZWFjaCBldmVudAo+IC0gKiBhbmQgYWRkcyBv bmUgdG8gZWFjaCBldmVudCdzIHdhaXRlciBjaGFpbi4KPiArICogV3JhcHBlciBhcm91bmQgd2Fp dF9xdWV1ZV9lbnRyeV90Cj4gICAqLwo+ICBzdHJ1Y3Qga2ZkX2V2ZW50X3dhaXRlciB7Cj4gLSAg ICAgICBzdHJ1Y3QgbGlzdF9oZWFkIHdhaXRlcnM7Cj4gLSAgICAgICBzdHJ1Y3QgdGFza19zdHJ1 Y3QgKnNsZWVwaW5nX3Rhc2s7Cj4gLQo+IC0gICAgICAgLyogVHJhbnNpdGlvbnMgdG8gdHJ1ZSB3 aGVuIHRoZSBldmVudCB0aGlzIGJlbG9uZ3MgdG8gaXMgc2lnbmFsZWQuICovCj4gLSAgICAgICBi b29sIGFjdGl2YXRlZDsKPiAtCj4gLSAgICAgICAvKiBFdmVudCAqLwo+IC0gICAgICAgc3RydWN0 IGtmZF9ldmVudCAqZXZlbnQ7Cj4gKyAgICAgICB3YWl0X3F1ZXVlX2VudHJ5X3Qgd2FpdDsKPiAr ICAgICAgIHN0cnVjdCBrZmRfZXZlbnQgKmV2ZW50OyAvKiBFdmVudCB0byB3YWl0IGZvciAqLwo+ ICsgICAgICAgYm9vbCBhY3RpdmF0ZWQ7ICAgICAgICAgIC8qIEJlY29tZXMgdHJ1ZSB3aGVuIGV2 ZW50IGlzIHNpZ25hbGVkICovCj4gIH07Cj4KPiAgLyoKPiBAQCAtMzQ0LDE3ICszMzQsMTIgQEAg dm9pZCBrZmRfZXZlbnRfaW5pdF9wcm9jZXNzKHN0cnVjdCBrZmRfcHJvY2VzcyAqcCkKPgo+ICBz dGF0aWMgdm9pZCBkZXN0cm95X2V2ZW50KHN0cnVjdCBrZmRfcHJvY2VzcyAqcCwgc3RydWN0IGtm ZF9ldmVudCAqZXYpCj4gIHsKPiAtICAgICAgIC8qIFdha2UgdXAgcGVuZGluZyB3YWl0ZXJzLiBU aGV5IHdpbGwgcmV0dXJuIGZhaWx1cmUgKi8KPiAtICAgICAgIHdoaWxlICghbGlzdF9lbXB0eSgm ZXYtPndhaXRlcnMpKSB7Cj4gLSAgICAgICAgICAgICAgIHN0cnVjdCBrZmRfZXZlbnRfd2FpdGVy ICp3YWl0ZXIgPQo+IC0gICAgICAgICAgICAgICAgICAgICAgIGxpc3RfZmlyc3RfZW50cnkoJmV2 LT53YWl0ZXJzLCBzdHJ1Y3Qga2ZkX2V2ZW50X3dhaXRlciwKPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHdhaXRlcnMpOwo+ICsgICAgICAgc3RydWN0IGtmZF9ldmVu dF93YWl0ZXIgKndhaXRlcjsKPgo+ICsgICAgICAgLyogV2FrZSB1cCBwZW5kaW5nIHdhaXRlcnMu IFRoZXkgd2lsbCByZXR1cm4gZmFpbHVyZSAqLwo+ICsgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRy eSh3YWl0ZXIsICZldi0+d3EuaGVhZCwgd2FpdC5lbnRyeSkKPiAgICAgICAgICAgICAgICAgd2Fp dGVyLT5ldmVudCA9IE5VTEw7Cj4gLSAgICAgICAgICAgICAgIC8qIF9pbml0IGJlY2F1c2UgZnJl ZV93YWl0ZXJzIHdpbGwgY2FsbCBsaXN0X2RlbCAqLwo+IC0gICAgICAgICAgICAgICBsaXN0X2Rl bF9pbml0KCZ3YWl0ZXItPndhaXRlcnMpOwo+IC0gICAgICAgICAgICAgICB3YWtlX3VwX3Byb2Nl c3Mod2FpdGVyLT5zbGVlcGluZ190YXNrKTsKPiAtICAgICAgIH0KPiArICAgICAgIHdha2VfdXBf YWxsKCZldi0+d3EpOwo+Cj4gICAgICAgICBpZiAoZXYtPnNpZ25hbF9wYWdlKSB7Cj4gICAgICAg ICAgICAgICAgIHJlbGVhc2VfZXZlbnRfbm90aWZpY2F0aW9uX3Nsb3QoZXYtPnNpZ25hbF9wYWdl LAo+IEBAIC00MjQsNyArNDA5LDcgQEAgaW50IGtmZF9ldmVudF9jcmVhdGUoc3RydWN0IGZpbGUg KmRldmtmZCwgc3RydWN0IGtmZF9wcm9jZXNzICpwLAo+ICAgICAgICAgZXYtPmF1dG9fcmVzZXQg PSBhdXRvX3Jlc2V0Owo+ICAgICAgICAgZXYtPnNpZ25hbGVkID0gZmFsc2U7Cj4KPiAtICAgICAg IElOSVRfTElTVF9IRUFEKCZldi0+d2FpdGVycyk7Cj4gKyAgICAgICBpbml0X3dhaXRxdWV1ZV9o ZWFkKCZldi0+d3EpOwo+Cj4gICAgICAgICAqZXZlbnRfcGFnZV9vZmZzZXQgPSAwOwo+Cj4gQEAg LTQ4MiwxOSArNDY3LDE0IEBAIGludCBrZmRfZXZlbnRfZGVzdHJveShzdHJ1Y3Qga2ZkX3Byb2Nl c3MgKnAsIHVpbnQzMl90IGV2ZW50X2lkKQo+ICBzdGF0aWMgdm9pZCBzZXRfZXZlbnQoc3RydWN0 IGtmZF9ldmVudCAqZXYpCj4gIHsKPiAgICAgICAgIHN0cnVjdCBrZmRfZXZlbnRfd2FpdGVyICp3 YWl0ZXI7Cj4gLSAgICAgICBzdHJ1Y3Qga2ZkX2V2ZW50X3dhaXRlciAqbmV4dDsKPgo+ICAgICAg ICAgLyogQXV0byByZXNldCBpZiB0aGUgbGlzdCBpcyBub24tZW1wdHkgYW5kIHdlJ3JlIHdha2lu ZyBzb21lb25lLiAqLwo+IC0gICAgICAgZXYtPnNpZ25hbGVkID0gIWV2LT5hdXRvX3Jlc2V0IHx8 IGxpc3RfZW1wdHkoJmV2LT53YWl0ZXJzKTsKPiArICAgICAgIGV2LT5zaWduYWxlZCA9ICFldi0+ YXV0b19yZXNldCB8fCAhd2FpdHF1ZXVlX2FjdGl2ZSgmZXYtPndxKTsKClRoaXMgbGluZSBnaXZl cyBhIHdhcm5pbmcgaW4gdGhlIGNoZWNrcGF0Y2ggc2NyaXB0LiBQZXIgTGludXMncyBwYXRjaAoo aHR0cDovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9tbS1jb21taXRzL21zZzExMTY2MC5odG1sKSwg cGxlYXNlIGFkZCBhCmNvbW1lbnQgZXhwbGFpbmluZyB0aGUgdXNlIG9mIHdhaXRxdWV1ZV9hY3Rp dmUgYW5kIHdoeSBpdHMgbm90IHJhY3kKd2l0aCB0aGUgY2FsbGVyLgoKT2RlZAoKPgo+IC0gICAg ICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHdhaXRlciwgbmV4dCwgJmV2LT53YWl0ZXJzLCB3 YWl0ZXJzKSB7Cj4gKyAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KHdhaXRlciwgJmV2LT53cS5o ZWFkLCB3YWl0LmVudHJ5KQo+ICAgICAgICAgICAgICAgICB3YWl0ZXItPmFjdGl2YXRlZCA9IHRy dWU7Cj4KPiAtICAgICAgICAgICAgICAgLyogX2luaXQgYmVjYXVzZSBmcmVlX3dhaXRlcnMgd2ls bCBjYWxsIGxpc3RfZGVsICovCj4gLSAgICAgICAgICAgICAgIGxpc3RfZGVsX2luaXQoJndhaXRl ci0+d2FpdGVycyk7Cj4gLQo+IC0gICAgICAgICAgICAgICB3YWtlX3VwX3Byb2Nlc3Mod2FpdGVy LT5zbGVlcGluZ190YXNrKTsKPiAtICAgICAgIH0KPiArICAgICAgIHdha2VfdXBfYWxsKCZldi0+ d3EpOwo+ICB9Cj4KPiAgLyogQXNzdW1lcyB0aGF0IHAgaXMgY3VycmVudC4gKi8KPiBAQCAtNjE0 LDggKzU5NCw3IEBAIHN0YXRpYyBzdHJ1Y3Qga2ZkX2V2ZW50X3dhaXRlciAqYWxsb2NfZXZlbnRf d2FpdGVycyh1aW50MzJfdCBudW1fZXZlbnRzKQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBHRlBfS0VSTkVMKTsKPgo+ICAgICAgICAgZm9yIChpID0gMDsgKGV2ZW50 X3dhaXRlcnMpICYmIChpIDwgbnVtX2V2ZW50cykgOyBpKyspIHsKPiAtICAgICAgICAgICAgICAg SU5JVF9MSVNUX0hFQUQoJmV2ZW50X3dhaXRlcnNbaV0ud2FpdGVycyk7Cj4gLSAgICAgICAgICAg ICAgIGV2ZW50X3dhaXRlcnNbaV0uc2xlZXBpbmdfdGFzayA9IGN1cnJlbnQ7Cj4gKyAgICAgICAg ICAgICAgIGluaXRfd2FpdCgmZXZlbnRfd2FpdGVyc1tpXS53YWl0KTsKPiAgICAgICAgICAgICAg ICAgZXZlbnRfd2FpdGVyc1tpXS5hY3RpdmF0ZWQgPSBmYWxzZTsKPiAgICAgICAgIH0KPgo+IEBA IC02NDYsNyArNjI1LDcgQEAgc3RhdGljIHZvaWQgaW5pdF9ldmVudF93YWl0ZXJfYWRkX3RvX3dh aXRsaXN0KHN0cnVjdCBrZmRfZXZlbnRfd2FpdGVyICp3YWl0ZXIpCj4gICAgICAgICAgKiB3YWl0 IG9uIHRoaXMgZXZlbnQuCj4gICAgICAgICAgKi8KPiAgICAgICAgIGlmICghd2FpdGVyLT5hY3Rp dmF0ZWQpCj4gLSAgICAgICAgICAgICAgIGxpc3RfYWRkKCZ3YWl0ZXItPndhaXRlcnMsICZldi0+ d2FpdGVycyk7Cj4gKyAgICAgICAgICAgICAgIGFkZF93YWl0X3F1ZXVlKCZldi0+d3EsICZ3YWl0 ZXItPndhaXQpOwo+ICB9Cj4KPiAgLyogdGVzdF9ldmVudF9jb25kaXRpb24gLSBUZXN0IGNvbmRp dGlvbiBvZiBldmVudHMgYmVpbmcgd2FpdGVkIGZvcgo+IEBAIC03MzYsNyArNzE1LDkgQEAgc3Rh dGljIHZvaWQgZnJlZV93YWl0ZXJzKHVpbnQzMl90IG51bV9ldmVudHMsIHN0cnVjdCBrZmRfZXZl bnRfd2FpdGVyICp3YWl0ZXJzKQo+ICAgICAgICAgdWludDMyX3QgaTsKPgo+ICAgICAgICAgZm9y IChpID0gMDsgaSA8IG51bV9ldmVudHM7IGkrKykKPiAtICAgICAgICAgICAgICAgbGlzdF9kZWwo JndhaXRlcnNbaV0ud2FpdGVycyk7Cj4gKyAgICAgICAgICAgICAgIGlmICh3YWl0ZXJzW2ldLmV2 ZW50KQo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJlbW92ZV93YWl0X3F1ZXVlKCZ3YWl0ZXJz W2ldLmV2ZW50LT53cSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAmd2FpdGVyc1tpXS53YWl0KTsKPgo+ICAgICAgICAga2ZyZWUod2FpdGVycyk7Cj4gIH0KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5oIGIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2V2ZW50cy5oCj4gaW5kZXggMjhmNjgzOC4uOTZm OTEyMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZXZlbnRz LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZXZlbnRzLmgKPiBAQCAt MjcsNiArMjcsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgvaGFzaHRhYmxlLmg+Cj4gICNpbmNsdWRl IDxsaW51eC90eXBlcy5oPgo+ICAjaW5jbHVkZSA8bGludXgvbGlzdC5oPgo+ICsjaW5jbHVkZSA8 bGludXgvd2FpdC5oPgo+ICAjaW5jbHVkZSAia2ZkX3ByaXYuaCIKPiAgI2luY2x1ZGUgPHVhcGkv bGludXgva2ZkX2lvY3RsLmg+Cj4KPiBAQCAtNTYsNyArNTcsNyBAQCBzdHJ1Y3Qga2ZkX2V2ZW50 IHsKPgo+ICAgICAgICAgaW50IHR5cGU7Cj4KPiAtICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgd2Fp dGVyczsgLyogTGlzdCBvZiBrZmRfZXZlbnRfd2FpdGVyIGJ5IHdhaXRlcnMuICovCj4gKyAgICAg ICB3YWl0X3F1ZXVlX2hlYWRfdCB3cTsgLyogTGlzdCBvZiBldmVudCB3YWl0ZXJzLiAqLwo+Cj4g ICAgICAgICAvKiBPbmx5IGZvciBzaWduYWwgZXZlbnRzLiAqLwo+ICAgICAgICAgc3RydWN0IHNp Z25hbF9wYWdlICpzaWduYWxfcGFnZTsKPiAtLQo+IDIuNy40Cj4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==