From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756464AbeDXJw3 (ORCPT ); Tue, 24 Apr 2018 05:52:29 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:43709 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755791AbeDXJw0 (ORCPT ); Tue, 24 Apr 2018 05:52:26 -0400 X-Google-Smtp-Source: AIpwx4+Tl5e4UEefQuIeZJFK/+HT71V1/iQzttbx22O7x7zgiA23C4DQfdP/AmsqKRimpXoeX6oj4qs+DmOtV3KuZ80= MIME-Version: 1.0 In-Reply-To: References: <20180414002933.6h3S5%akpm@linux-foundation.org> From: Oded Gabbay Date: Tue, 24 Apr 2018 12:51:55 +0300 Message-ID: Subject: Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER To: Anders Roxell Cc: Randy Dunlap , Andrew Morton , Stephen Rothwell , linux-next@vger.kernel.org, Linux Kernel Mailing List , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 19, 2018 at 1:46 PM, Anders Roxell wrote: > On 14 April 2018 at 04:49, Randy Dunlap wrote: >> From: Randy Dunlap >> >> When CONFIG_MMU_NOTIFIER is not enabled, struct mmu_notifier has an >> incomplete type definition, which causes build errors. >> >> ../drivers/gpu/drm/amd/amdkfd/kfd_priv.h:607:22: error: field 'mmu_notifier' has incomplete type >> ../include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type >> ../include/linux/kernel.h:980:18: error: dereferencing pointer to incomplete type >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:434:2: error: implicit declaration of function 'mmu_notifier_unregister_no_release' [-Werror=implicit-function-declaration] >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:435:2: error: implicit declaration of function 'mmu_notifier_call_srcu' [-Werror=implicit-function-declaration] >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:438:21: error: variable 'kfd_process_mmu_notifier_ops' has initializer but incomplete type >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: error: unknown field 'release' specified in initializer >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: excess elements in struct initializer [enabled by default] >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near initialization for 'kfd_process_mmu_notifier_ops') [enabled by default] >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit declaration of function 'mmu_notifier_register' [-Werror=implicit-function-declaration] >> >> Signed-off-by: Randy Dunlap >> Cc: Oded Gabbay >> Cc: dri-devel@lists.freedesktop.org > > Tested-by: Anders Roxell > >> --- >> From linux-next, not mmotm, but found in mmotm builds. >> >> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- mmotm-2018-0413-1728.orig/drivers/gpu/drm/amd/amdkfd/Kconfig >> +++ mmotm-2018-0413-1728/drivers/gpu/drm/amd/amdkfd/Kconfig >> @@ -6,5 +6,6 @@ config HSA_AMD >> tristate "HSA kernel driver for AMD GPU devices" >> depends on DRM_AMDGPU && X86_64 >> imply AMD_IOMMU_V2 >> + select MMU_NOTIFIER >> help >> Enable this if you want to use HSA features on AMD GPU devices. >> Thanks, taken to -fixes Oded From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER Date: Tue, 24 Apr 2018 12:51:55 +0300 Message-ID: References: <20180414002933.6h3S5%akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Anders Roxell Cc: Stephen Rothwell , Randy Dunlap , Linux Kernel Mailing List , dri-devel , linux-next@vger.kernel.org, Andrew Morton List-Id: linux-next.vger.kernel.org T24gVGh1LCBBcHIgMTksIDIwMTggYXQgMTo0NiBQTSwgQW5kZXJzIFJveGVsbCA8YW5kZXJzLnJv eGVsbEBsaW5hcm8ub3JnPiB3cm90ZToKPiBPbiAxNCBBcHJpbCAyMDE4IGF0IDA0OjQ5LCBSYW5k eSBEdW5sYXAgPHJkdW5sYXBAaW5mcmFkZWFkLm9yZz4gd3JvdGU6Cj4+IEZyb206IFJhbmR5IER1 bmxhcCA8cmR1bmxhcEBpbmZyYWRlYWQub3JnPgo+Pgo+PiBXaGVuIENPTkZJR19NTVVfTk9USUZJ RVIgaXMgbm90IGVuYWJsZWQsIHN0cnVjdCBtbXVfbm90aWZpZXIgaGFzIGFuCj4+IGluY29tcGxl dGUgdHlwZSBkZWZpbml0aW9uLCB3aGljaCBjYXVzZXMgYnVpbGQgZXJyb3JzLgo+Pgo+PiAuLi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJpdi5oOjYwNzoyMjogZXJyb3I6IGZpZWxk ICdtbXVfbm90aWZpZXInIGhhcyBpbmNvbXBsZXRlIHR5cGUKPj4gLi4vaW5jbHVkZS9saW51eC9r ZXJuZWwuaDo5Nzk6MzI6IGVycm9yOiBkZXJlZmVyZW5jaW5nIHBvaW50ZXIgdG8gaW5jb21wbGV0 ZSB0eXBlCj4+IC4uL2luY2x1ZGUvbGludXgva2VybmVsLmg6OTgwOjE4OiBlcnJvcjogZGVyZWZl cmVuY2luZyBwb2ludGVyIHRvIGluY29tcGxldGUgdHlwZQo+PiAuLi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGtmZC9rZmRfcHJvY2Vzcy5jOjQzNDoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRp b24gb2YgZnVuY3Rpb24gJ21tdV9ub3RpZmllcl91bnJlZ2lzdGVyX25vX3JlbGVhc2UnIFstV2Vy cm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQo+PiAuLi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGtmZC9rZmRfcHJvY2Vzcy5jOjQzNToyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRp b24gb2YgZnVuY3Rpb24gJ21tdV9ub3RpZmllcl9jYWxsX3NyY3UnIFstV2Vycm9yPWltcGxpY2l0 LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQo+PiAuLi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9r ZmRfcHJvY2Vzcy5jOjQzODoyMTogZXJyb3I6IHZhcmlhYmxlICdrZmRfcHJvY2Vzc19tbXVfbm90 aWZpZXJfb3BzJyBoYXMgaW5pdGlhbGl6ZXIgYnV0IGluY29tcGxldGUgdHlwZQo+PiAuLi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJvY2Vzcy5jOjQzOToyOiBlcnJvcjogdW5rbm93 biBmaWVsZCAncmVsZWFzZScgc3BlY2lmaWVkIGluIGluaXRpYWxpemVyCj4+IC4uL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9wcm9jZXNzLmM6NDM5OjI6IHdhcm5pbmc6IGV4Y2VzcyBl bGVtZW50cyBpbiBzdHJ1Y3QgaW5pdGlhbGl6ZXIgW2VuYWJsZWQgYnkgZGVmYXVsdF0KPj4gLi4v ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Byb2Nlc3MuYzo0Mzk6Mjogd2FybmluZzog KG5lYXIgaW5pdGlhbGl6YXRpb24gZm9yICdrZmRfcHJvY2Vzc19tbXVfbm90aWZpZXJfb3BzJykg W2VuYWJsZWQgYnkgZGVmYXVsdF0KPj4gLi4vZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2Zk X3Byb2Nlc3MuYzo1MzQ6MjogZXJyb3I6IGltcGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9u ICdtbXVfbm90aWZpZXJfcmVnaXN0ZXInIFstV2Vycm9yPWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xh cmF0aW9uXQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBSYW5keSBEdW5sYXAgPHJkdW5sYXBAaW5mcmFk ZWFkLm9yZz4KPj4gQ2M6IE9kZWQgR2FiYmF5IDxvZGVkLmdhYmJheUBnbWFpbC5jb20+Cj4+IENj OiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4KPiBUZXN0ZWQtYnk6IEFuZGVycyBS b3hlbGwgPGFuZGVycy5yb3hlbGxAbGluYXJvLm9yZz4KPgo+PiAtLS0KPj4gRnJvbSBsaW51eC1u ZXh0LCBub3QgbW1vdG0sIGJ1dCBmb3VuZCBpbiBtbW90bSBidWlsZHMuCj4+Cj4+ICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGtmZC9LY29uZmlnIHwgICAgMSArCj4+ICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKykKPj4KPj4gLS0tIG1tb3RtLTIwMTgtMDQxMy0xNzI4Lm9yaWcvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRrZmQvS2NvbmZpZwo+PiArKysgbW1vdG0tMjAxOC0wNDEzLTE3Mjgv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQvS2NvbmZpZwo+PiBAQCAtNiw1ICs2LDYgQEAgY29u ZmlnIEhTQV9BTUQKPj4gICAgICAgICB0cmlzdGF0ZSAiSFNBIGtlcm5lbCBkcml2ZXIgZm9yIEFN RCBHUFUgZGV2aWNlcyIKPj4gICAgICAgICBkZXBlbmRzIG9uIERSTV9BTURHUFUgJiYgWDg2XzY0 Cj4+ICAgICAgICAgaW1wbHkgQU1EX0lPTU1VX1YyCj4+ICsgICAgICAgc2VsZWN0IE1NVV9OT1RJ RklFUgo+PiAgICAgICAgIGhlbHAKPj4gICAgICAgICAgIEVuYWJsZSB0aGlzIGlmIHlvdSB3YW50 IHRvIHVzZSBIU0EgZmVhdHVyZXMgb24gQU1EIEdQVSBkZXZpY2VzLgo+PgoKVGhhbmtzLCB0YWtl biB0byAtZml4ZXMKT2RlZApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK