From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933210AbcDKNkZ (ORCPT ); Mon, 11 Apr 2016 09:40:25 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34199 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932513AbcDKNkU convert rfc822-to-8bit (ORCPT ); Mon, 11 Apr 2016 09:40:20 -0400 MIME-Version: 1.0 In-Reply-To: <570BA694.8040900@amd.com> References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> <570BA694.8040900@amd.com> From: Oded Gabbay Date: Mon, 11 Apr 2016 16:39:43 +0300 Message-ID: Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: "Luis R. Rodriguez" , Joerg Roedel , iommu@lists.linux-foundation.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2016 at 4:28 PM, Christian König wrote: > > Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: >> >> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: >>> >>> We need to ensure amd iommu v2 initializes before >>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, >>> to do this make its init routine a subsys_initcall() which >>> ensures its load init is called first than modules when >>> built-in. >>> >>> This reverts the old work around implemented through commit >>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"), >>> instead of making the dependency implicit by linker order this >>> makes the ordering requirement explicit through proper kernel >>> APIs. >>> >>> Cc: Oded Gabbay >>> Cc: Christian König >>> Signed-off-by: Luis R. Rodriguez > > > Sorry for not responding earlier. Just coming back to all the stuff on my TODO list. > > Patch is Acked-by: Christian König Christian, Just wanted to be sure if you tested this patch-set or not. I don't think it should be merged without testing. If you already tested it than fine. If not, I think I can do it in the next week or so (just came back from PTO). Oded > > > Regards, > Christian. > >> *poke* >> >> Luis > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu Date: Mon, 11 Apr 2016 16:39:43 +0300 Message-ID: References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> <570BA694.8040900@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <570BA694.8040900-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: "Luis R. Rodriguez" , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: iommu@lists.linux-foundation.org T24gTW9uLCBBcHIgMTEsIDIwMTYgYXQgNDoyOCBQTSwgQ2hyaXN0aWFuIEvDtm5pZwo8Y2hyaXN0 aWFuLmtvZW5pZ0BhbWQuY29tPiB3cm90ZToKPgo+IEFtIDA5LjA0LjIwMTYgdW0gMDI6MjUgc2No cmllYiBMdWlzIFIuIFJvZHJpZ3VlejoKPj4KPj4gT24gVHVlLCBNYXIgMjksIDIwMTYgYXQgMTA6 NDEgQU0sIEx1aXMgUi4gUm9kcmlndWV6IDxtY2dyb2ZAa2VybmVsLm9yZz4gd3JvdGU6Cj4+Pgo+ Pj4gV2UgbmVlZCB0byBlbnN1cmUgYW1kIGlvbW11IHYyIGluaXRpYWxpemVzIGJlZm9yZQo+Pj4g ZHJpdmVyIHVzZXMgc3VjaCBhcyBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfbW9kdWxl LmMsCj4+PiB0byBkbyB0aGlzIG1ha2UgaXRzIGluaXQgcm91dGluZSBhIHN1YnN5c19pbml0Y2Fs bCgpIHdoaWNoCj4+PiBlbnN1cmVzIGl0cyBsb2FkIGluaXQgaXMgY2FsbGVkIGZpcnN0IHRoYW4g bW9kdWxlcyB3aGVuCj4+PiBidWlsdC1pbi4KPj4+Cj4+PiBUaGlzIHJldmVydHMgdGhlIG9sZCB3 b3JrIGFyb3VuZCBpbXBsZW1lbnRlZCB0aHJvdWdoIGNvbW1pdAo+Pj4gMWJhY2M4OTRjMjI3ZmFk OGE3ICgiZHJpdmVyczogTW92ZSBpb21tdS8gYmVmb3JlIGdwdS8gaW4gTWFrZWZpbGUiKSwKPj4+ IGluc3RlYWQgb2YgbWFraW5nIHRoZSBkZXBlbmRlbmN5IGltcGxpY2l0IGJ5IGxpbmtlciBvcmRl ciB0aGlzCj4+PiBtYWtlcyB0aGUgb3JkZXJpbmcgcmVxdWlyZW1lbnQgZXhwbGljaXQgdGhyb3Vn aCBwcm9wZXIga2VybmVsCj4+PiBBUElzLgo+Pj4KPj4+IENjOiBPZGVkIEdhYmJheSA8b2RlZC5n YWJiYXlAYW1kLmNvbT4KPj4+IENjOiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmln QGFtZC5jb20+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMdWlzIFIuIFJvZHJpZ3VleiA8bWNncm9mQGtl cm5lbC5vcmc+Cj4KPgo+IFNvcnJ5IGZvciBub3QgcmVzcG9uZGluZyBlYXJsaWVyLiBKdXN0IGNv bWluZyBiYWNrIHRvIGFsbCB0aGUgc3R1ZmYgb24gbXkgVE9ETyBsaXN0Lgo+Cj4gUGF0Y2ggaXMg QWNrZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KCgpD aHJpc3RpYW4sCkp1c3Qgd2FudGVkIHRvIGJlIHN1cmUgaWYgeW91IHRlc3RlZCB0aGlzIHBhdGNo LXNldCBvciBub3QuCgpJIGRvbid0IHRoaW5rIGl0IHNob3VsZCBiZSBtZXJnZWQgd2l0aG91dCB0 ZXN0aW5nLiBJZiB5b3UgYWxyZWFkeQp0ZXN0ZWQgaXQgdGhhbiBmaW5lLiBJZiBub3QsIEkgdGhp bmsgSSBjYW4gZG8gaXQgaW4gdGhlIG5leHQgd2VlayBvcgpzbyAoanVzdCBjYW1lIGJhY2sgZnJv bSBQVE8pLgoKT2RlZAoKPgo+Cj4gUmVnYXJkcywKPiBDaHJpc3RpYW4uCj4KPj4gKnBva2UqCj4+ Cj4+ICAgTHVpcwo+Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3Jn Cmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11