From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739AbeEPIJv (ORCPT ); Wed, 16 May 2018 04:09:51 -0400 Received: from mail-ua0-f196.google.com ([209.85.217.196]:46102 "EHLO mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbeEPIJs (ORCPT ); Wed, 16 May 2018 04:09:48 -0400 X-Google-Smtp-Source: AB8JxZpNyykppowDh3pqwsFKI1rjTw0xtSfAidZyZSNyasabpHZZEuXdL5lSS/sJXHJSTmwSPQOBBS+jrMVV2PiqHlY= MIME-Version: 1.0 In-Reply-To: <20180516165326.47e96000@canb.auug.org.au> References: <20180516165326.47e96000@canb.auug.org.au> From: Oded Gabbay Date: Wed, 16 May 2018 11:09:16 +0300 Message-ID: Subject: Re: linux-next: build failure after merge of the drm tree To: Stephen Rothwell Cc: Dave Airlie , DRI , Linux-Next Mailing List , Linux Kernel Mailing List , Felix Kuehling Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 16, 2018 at 9:53 AM, Stephen Rothwell wrote: > Hi all, > > After merging the drm tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function 'init_user_pages': > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:632:3: error: implicit declaration of function 'release_pages'; did you mean 'release_task'? [-Werror=implicit-function-declaration] > release_pages(mem->user_pages, bo->tbo.ttm->num_pages); > ^~~~~~~~~~~~~ > release_task > > Caused by commit > > 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD") > > I have applied the following patch for today: > > From: Stephen Rothwell > Date: Wed, 16 May 2018 16:43:34 +1000 > Subject: [PATCH] drm/amdgpu: include pagemap.h for release_pages() > > Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD" > Cc: Felix Kuehling > Cc: Oded Gabbay > Signed-off-by: Stephen Rothwell > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > index 72ab2b1ffe75..ff8fd75f7ca5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c > @@ -23,6 +23,7 @@ > #define pr_fmt(fmt) "kfd2kgd: " fmt > > #include > +#include > #include > #include > #include "amdgpu_object.h" > -- > 2.17.0 > > -- > Cheers, > Stephen Rothwell Thanks Stephen, I'll add it to amdkfd-next and send it to Dave with other fixes. Oded From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: linux-next: build failure after merge of the drm tree Date: Wed, 16 May 2018 11:09:16 +0300 Message-ID: References: <20180516165326.47e96000@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180516165326.47e96000@canb.auug.org.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stephen Rothwell Cc: Dave Airlie , Felix Kuehling , Linux-Next Mailing List , Linux Kernel Mailing List , DRI List-Id: linux-next.vger.kernel.org T24gV2VkLCBNYXkgMTYsIDIwMTggYXQgOTo1MyBBTSwgU3RlcGhlbiBSb3Rod2VsbCA8c2ZyQGNh bmIuYXV1Zy5vcmcuYXU+IHdyb3RlOgo+IEhpIGFsbCwKPgo+IEFmdGVyIG1lcmdpbmcgdGhlIGRy bSB0cmVlLCB0b2RheSdzIGxpbnV4LW5leHQgYnVpbGQgKHBvd2VycGMKPiBhbGx5ZXNjb25maWcp IGZhaWxlZCBsaWtlIHRoaXM6Cj4KPiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf YW1ka2ZkX2dwdXZtLmM6IEluIGZ1bmN0aW9uICdpbml0X3VzZXJfcGFnZXMnOgo+IGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRfZ3B1dm0uYzo2MzI6MzogZXJyb3I6IGlt cGxpY2l0IGRlY2xhcmF0aW9uIG9mIGZ1bmN0aW9uICdyZWxlYXNlX3BhZ2VzJzsgZGlkIHlvdSBt ZWFuICdyZWxlYXNlX3Rhc2snPyBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlv bl0KPiAgICByZWxlYXNlX3BhZ2VzKG1lbS0+dXNlcl9wYWdlcywgYm8tPnRiby50dG0tPm51bV9w YWdlcyk7Cj4gICAgXn5+fn5+fn5+fn5+fgo+ICAgIHJlbGVhc2VfdGFzawo+Cj4gQ2F1c2VkIGJ5 IGNvbW1pdAo+Cj4gICA1YWUwMjgzZTgzMWEgKCJkcm0vYW1kZ3B1OiBBZGQgdXNlcnB0ciBzdXBw b3J0IGZvciBLRkQiKQo+Cj4gSSBoYXZlIGFwcGxpZWQgdGhlIGZvbGxvd2luZyBwYXRjaCBmb3Ig dG9kYXk6Cj4KPiBGcm9tOiBTdGVwaGVuIFJvdGh3ZWxsIDxzZnJAY2FuYi5hdXVnLm9yZy5hdT4K PiBEYXRlOiBXZWQsIDE2IE1heSAyMDE4IDE2OjQzOjM0ICsxMDAwCj4gU3ViamVjdDogW1BBVENI XSBkcm0vYW1kZ3B1OiBpbmNsdWRlIHBhZ2VtYXAuaCBmb3IgcmVsZWFzZV9wYWdlcygpCj4KPiBG aXhlczogNWFlMDI4M2U4MzFhICgiZHJtL2FtZGdwdTogQWRkIHVzZXJwdHIgc3VwcG9ydCBmb3Ig S0ZEIgo+IENjOiBGZWxpeCBLdWVobGluZyA8RmVsaXguS3VlaGxpbmdAYW1kLmNvbT4KPiBDYzog T2RlZCBHYWJiYXkgPG9kZWQuZ2FiYmF5QGdtYWlsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTdGVw aGVuIFJvdGh3ZWxsIDxzZnJAY2FuYi5hdXVnLm9yZy5hdT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2FtZGtmZF9ncHV2bS5jIHwgMSArCj4gIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9hbWRrZmRfZ3B1dm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9hbWRrZmRfZ3B1dm0uYwo+IGluZGV4IDcyYWIyYjFmZmU3NS4uZmY4ZmQ3NWY3Y2E1 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRf Z3B1dm0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9hbWRrZmRf Z3B1dm0uYwo+IEBAIC0yMyw2ICsyMyw3IEBACj4gICNkZWZpbmUgcHJfZm10KGZtdCkgImtmZDJr Z2Q6ICIgZm10Cj4KPiAgI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4KPiArI2luY2x1ZGUgPGxpbnV4 L3BhZ2VtYXAuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3NjaGVkL21tLmg+Cj4gICNpbmNsdWRlIDxk cm0vZHJtUC5oPgo+ICAjaW5jbHVkZSAiYW1kZ3B1X29iamVjdC5oIgo+IC0tCj4gMi4xNy4wCj4K PiAtLQo+IENoZWVycywKPiBTdGVwaGVuIFJvdGh3ZWxsCgpUaGFua3MgU3RlcGhlbiwKCkknbGwg YWRkIGl0IHRvIGFtZGtmZC1uZXh0IGFuZCBzZW5kIGl0IHRvIERhdmUgd2l0aCBvdGhlciBmaXhl cy4KCk9kZWQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==