From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH 13/16] drm/amdkfd: use standard kernel kfifo for IH Date: Wed, 25 Oct 2017 15:15:09 +0300 Message-ID: References: <1508545400-24338-1-git-send-email-Felix.Kuehling@amd.com> <1508545400-24338-14-git-send-email-Felix.Kuehling@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1508545400-24338-14-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Felix Kuehling Cc: Andres Rodriguez , amd-gfx list T24gU2F0LCBPY3QgMjEsIDIwMTcgYXQgMzoyMyBBTSwgRmVsaXggS3VlaGxpbmcgPEZlbGl4Lkt1 ZWhsaW5nQGFtZC5jb20+IHdyb3RlOgo+IEZyb206IEFuZHJlcyBSb2RyaWd1ZXogPGFuZHJlcy5y b2RyaWd1ZXpAYW1kLmNvbT4KPgo+IFJlcGxhY2Ugb3VyIGltcGxlbWVudGF0aW9uIG9mIGEgbG9j a2xlc3MgcmluZyBidWZmZXIgd2l0aCB0aGUgc3RhbmRhcmQKPiBsaW51eCBrZXJuZWwga2ZpZm8u Cj4KPiBXZSBzaG91bGRuJ3QgbWFpbnRhaW4gb3VyIG93biB2ZXJzaW9uIG9mIGEgc3RhbmRhcmQg ZGF0YSBzdHJ1Y3R1cmUuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXMgUm9kcmlndWV6IDxhbmRy ZXMucm9kcmlndWV6QGFtZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRmVsaXggS3VlaGxpbmcgPEZl bGl4Lkt1ZWhsaW5nQGFtZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2Zk L2tmZF9pbnRlcnJ1cHQuYyB8IDc4ICsrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfcHJpdi5oICAgICAgfCAgNiArLS0KPiAgMiBm aWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA1NyBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfaW50ZXJydXB0LmMgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfaW50ZXJydXB0LmMKPiBpbmRleCA3MGIzYTk5Yy4u ZmZiYjkxYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfaW50 ZXJydXB0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfaW50ZXJydXB0 LmMKPiBAQCAtNDIsMjUgKzQyLDI0IEBACj4KPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgo+ICsjaW5jbHVkZSA8bGludXgva2ZpZm8uaD4KPiAg I2luY2x1ZGUgImtmZF9wcml2LmgiCj4KPiAtI2RlZmluZSBLRkRfSU5URVJSVVBUX1JJTkdfU0la RSAxMDI0Cj4gKyNkZWZpbmUgS0ZEX0lIX05VTV9FTlRSSUVTIDEwMjQKPgo+ICBzdGF0aWMgdm9p ZCBpbnRlcnJ1cHRfd3Eoc3RydWN0IHdvcmtfc3RydWN0ICopOwo+Cj4gIGludCBrZmRfaW50ZXJy dXB0X2luaXQoc3RydWN0IGtmZF9kZXYgKmtmZCkKPiAgewo+IC0gICAgICAgdm9pZCAqaW50ZXJy dXB0X3JpbmcgPSBrbWFsbG9jX2FycmF5KEtGRF9JTlRFUlJVUFRfUklOR19TSVpFLAo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZmQtPmRldmljZV9pbmZvLT5paF9y aW5nX2VudHJ5X3NpemUsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IEdGUF9LRVJORUwpOwo+IC0gICAgICAgaWYgKCFpbnRlcnJ1cHRfcmluZykKPiAtICAgICAgICAg ICAgICAgcmV0dXJuIC1FTk9NRU07Cj4gLQo+IC0gICAgICAga2ZkLT5pbnRlcnJ1cHRfcmluZyA9 IGludGVycnVwdF9yaW5nOwo+IC0gICAgICAga2ZkLT5pbnRlcnJ1cHRfcmluZ19zaXplID0KPiAt ICAgICAgICAgICAgICAgS0ZEX0lOVEVSUlVQVF9SSU5HX1NJWkUgKiBrZmQtPmRldmljZV9pbmZv LT5paF9yaW5nX2VudHJ5X3NpemU7Cj4gLSAgICAgICBhdG9taWNfc2V0KCZrZmQtPmludGVycnVw dF9yaW5nX3dwdHIsIDApOwo+IC0gICAgICAgYXRvbWljX3NldCgma2ZkLT5pbnRlcnJ1cHRfcmlu Z19ycHRyLCAwKTsKPiArICAgICAgIGludCByOwo+ICsKPiArICAgICAgIHIgPSBrZmlmb19hbGxv Yygma2ZkLT5paF9maWZvLAo+ICsgICAgICAgICAgICAgICBLRkRfSUhfTlVNX0VOVFJJRVMgKiBr ZmQtPmRldmljZV9pbmZvLT5paF9yaW5nX2VudHJ5X3NpemUsCj4gKyAgICAgICAgICAgICAgIEdG UF9LRVJORUwpOwo+ICsgICAgICAgaWYgKHIpIHsKPiArICAgICAgICAgICAgICAgZGV2X2Vycihr ZmRfY2hhcmRldigpLCAiRmFpbGVkIHRvIGFsbG9jYXRlIElIIGZpZm9cbiIpOwo+ICsgICAgICAg ICAgICAgICByZXR1cm4gcjsKPiArICAgICAgIH0KPgo+ICAgICAgICAgc3Bpbl9sb2NrX2luaXQo JmtmZC0+aW50ZXJydXB0X2xvY2spOwo+Cj4gQEAgLTk4LDY4ICs5Nyw0MSBAQCB2b2lkIGtmZF9p bnRlcnJ1cHRfZXhpdChzdHJ1Y3Qga2ZkX2RldiAqa2ZkKQo+ICAgICAgICAgICovCj4gICAgICAg ICBmbHVzaF9zY2hlZHVsZWRfd29yaygpOwo+Cj4gLSAgICAgICBrZnJlZShrZmQtPmludGVycnVw dF9yaW5nKTsKPiArICAgICAgIGtmaWZvX2ZyZWUoJmtmZC0+aWhfZmlmbyk7Cj4gIH0KPgo+ICAv Kgo+IC0gKiBUaGlzIGFzc3VtZXMgdGhhdCBpdCBjYW4ndCBiZSBjYWxsZWQgY29uY3VycmVudGx5 IHdpdGggaXRzZWxmCj4gLSAqIGJ1dCBvbmx5IHdpdGggZGVxdWV1ZV9paF9yaW5nX2VudHJ5Lgo+ ICsgKiBBc3N1bXB0aW9uOiBzaW5nbGUgcmVhZGVyL3dyaXRlci4gVGhpcyBmdW5jdGlvbiBpcyBu b3QgcmUtZW50cmFudAo+ICAgKi8KPiAgYm9vbCBlbnF1ZXVlX2loX3JpbmdfZW50cnkoc3RydWN0 IGtmZF9kZXYgKmtmZCwgICAgICAgIGNvbnN0IHZvaWQgKmloX3JpbmdfZW50cnkpCj4gIHsKPiAt ICAgICAgIHVuc2lnbmVkIGludCBycHRyID0gYXRvbWljX3JlYWQoJmtmZC0+aW50ZXJydXB0X3Jp bmdfcnB0cik7Cj4gLSAgICAgICB1bnNpZ25lZCBpbnQgd3B0ciA9IGF0b21pY19yZWFkKCZrZmQt PmludGVycnVwdF9yaW5nX3dwdHIpOwo+ICsgICAgICAgaW50IGNvdW50Owo+Cj4gLSAgICAgICBp ZiAoKHJwdHIgLSB3cHRyKSAlIGtmZC0+aW50ZXJydXB0X3Jpbmdfc2l6ZSA9PQo+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBrZmQtPmRldmljZV9pbmZvLT5paF9yaW5n X2VudHJ5X3NpemUpIHsKPiAtICAgICAgICAgICAgICAgLyogVGhpcyBpcyB2ZXJ5IGJhZCwgdGhl IHN5c3RlbSBpcyBsaWtlbHkgdG8gaGFuZy4gKi8KPiArICAgICAgIGNvdW50ID0ga2ZpZm9faW4o JmtmZC0+aWhfZmlmbywgaWhfcmluZ19lbnRyeSwKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGtmZC0+ZGV2aWNlX2luZm8tPmloX3JpbmdfZW50cnlfc2l6ZSk7Cj4gKyAgICAgICBp ZiAoY291bnQgIT0ga2ZkLT5kZXZpY2VfaW5mby0+aWhfcmluZ19lbnRyeV9zaXplKSB7Cj4gICAg ICAgICAgICAgICAgIGRldl9lcnJfcmF0ZWxpbWl0ZWQoa2ZkX2NoYXJkZXYoKSwKPiAtICAgICAg ICAgICAgICAgICAgICAgICAiSW50ZXJydXB0IHJpbmcgb3ZlcmZsb3csIGRyb3BwaW5nIGludGVy cnVwdC5cbiIpOwo+ICsgICAgICAgICAgICAgICAgICAgICAgICJJbnRlcnJ1cHQgcmluZyBvdmVy ZmxvdywgZHJvcHBpbmcgaW50ZXJydXB0ICVkXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgICAg IGNvdW50KTsKPiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ICAgICAgICAgfQo+Cj4g LSAgICAgICBtZW1jcHkoa2ZkLT5pbnRlcnJ1cHRfcmluZyArIHdwdHIsIGloX3JpbmdfZW50cnks Cj4gLSAgICAgICAgICAgICAgICAgICAgICAga2ZkLT5kZXZpY2VfaW5mby0+aWhfcmluZ19lbnRy eV9zaXplKTsKPiAtCj4gLSAgICAgICB3cHRyID0gKHdwdHIgKyBrZmQtPmRldmljZV9pbmZvLT5p aF9yaW5nX2VudHJ5X3NpemUpICUKPiAtICAgICAgICAgICAgICAgICAgICAgICBrZmQtPmludGVy cnVwdF9yaW5nX3NpemU7Cj4gLSAgICAgICBzbXBfd21iKCk7IC8qIEVuc3VyZSBtZW1jcHknZCBk YXRhIGlzIHZpc2libGUgYmVmb3JlIHdwdHIgdXBkYXRlLiAqLwo+IC0gICAgICAgYXRvbWljX3Nl dCgma2ZkLT5pbnRlcnJ1cHRfcmluZ193cHRyLCB3cHRyKTsKPiAtCj4gICAgICAgICByZXR1cm4g dHJ1ZTsKPiAgfQo+Cj4gIC8qCj4gLSAqIFRoaXMgYXNzdW1lcyB0aGF0IGl0IGNhbid0IGJlIGNh bGxlZCBjb25jdXJyZW50bHkgd2l0aCBpdHNlbGYKPiAtICogYnV0IG9ubHkgd2l0aCBlbnF1ZXVl X2loX3JpbmdfZW50cnkuCj4gKyAqIEFzc3VtcHRpb246IHNpbmdsZSByZWFkZXIvd3JpdGVyLiBU aGlzIGZ1bmN0aW9uIGlzIG5vdCByZS1lbnRyYW50Cj4gICAqLwo+ICBzdGF0aWMgYm9vbCBkZXF1 ZXVlX2loX3JpbmdfZW50cnkoc3RydWN0IGtmZF9kZXYgKmtmZCwgdm9pZCAqaWhfcmluZ19lbnRy eSkKPiAgewo+IC0gICAgICAgLyoKPiAtICAgICAgICAqIEFzc3VtZSB0aGF0IHdhaXQgcXVldWVz IGhhdmUgYW4gaW1wbGljaXQgYmFycmllciwgaS5lLiBhbnl0aGluZyB0aGF0Cj4gLSAgICAgICAg KiBoYXBwZW5lZCBpbiB0aGUgSVNSIGJlZm9yZSBpdCBxdWV1ZWQgd29yayBpcyB2aXNpYmxlLgo+ IC0gICAgICAgICovCj4gLQo+IC0gICAgICAgdW5zaWduZWQgaW50IHdwdHIgPSBhdG9taWNfcmVh ZCgma2ZkLT5pbnRlcnJ1cHRfcmluZ193cHRyKTsKPiAtICAgICAgIHVuc2lnbmVkIGludCBycHRy ID0gYXRvbWljX3JlYWQoJmtmZC0+aW50ZXJydXB0X3JpbmdfcnB0cik7Cj4gKyAgICAgICBpbnQg Y291bnQ7Cj4KPiAtICAgICAgIGlmIChycHRyID09IHdwdHIpCj4gLSAgICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKPiAtCj4gLSAgICAgICBtZW1jcHkoaWhfcmluZ19lbnRyeSwga2ZkLT5pbnRl cnJ1cHRfcmluZyArIHJwdHIsCj4gLSAgICAgICAgICAgICAgICAgICAgICAga2ZkLT5kZXZpY2Vf aW5mby0+aWhfcmluZ19lbnRyeV9zaXplKTsKPiAtCj4gLSAgICAgICBycHRyID0gKHJwdHIgKyBr ZmQtPmRldmljZV9pbmZvLT5paF9yaW5nX2VudHJ5X3NpemUpICUKPiAtICAgICAgICAgICAgICAg ICAgICAgICBrZmQtPmludGVycnVwdF9yaW5nX3NpemU7Cj4gKyAgICAgICBjb3VudCA9IGtmaWZv X291dCgma2ZkLT5paF9maWZvLCBpaF9yaW5nX2VudHJ5LAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAga2ZkLT5kZXZpY2VfaW5mby0+aWhfcmluZ19lbnRyeV9zaXplKTsKPgo+IC0g ICAgICAgLyoKPiAtICAgICAgICAqIEVuc3VyZSB0aGUgcnB0ciB3cml0ZSB1cGRhdGUgaXMgbm90 IHZpc2libGUgdW50aWwKPiAtICAgICAgICAqIG1lbWNweSBoYXMgZmluaXNoZWQgcmVhZGluZy4K PiAtICAgICAgICAqLwo+IC0gICAgICAgc21wX21iKCk7Cj4gLSAgICAgICBhdG9taWNfc2V0KCZr ZmQtPmludGVycnVwdF9yaW5nX3JwdHIsIHJwdHIpOwo+ICsgICAgICAgV0FSTl9PTihjb3VudCAm JiBjb3VudCAhPSBrZmQtPmRldmljZV9pbmZvLT5paF9yaW5nX2VudHJ5X3NpemUpOwo+Cj4gLSAg ICAgICByZXR1cm4gdHJ1ZTsKPiArICAgICAgIHJldHVybiBjb3VudCA9PSBrZmQtPmRldmljZV9p bmZvLT5paF9yaW5nX2VudHJ5X3NpemU7Cj4gIH0KPgo+ICBzdGF0aWMgdm9pZCBpbnRlcnJ1cHRf d3Eoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vYW1kL2FtZGtmZC9rZmRfcHJpdi5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2Zk X3ByaXYuaAo+IGluZGV4IGViYWU4ZTEuLmU4ZDZjMGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRrZmQva2ZkX3ByaXYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1ka2ZkL2tmZF9wcml2LmgKPiBAQCAtMzIsNiArMzIsNyBAQAo+ICAjaW5jbHVkZSA8bGludXgv c3BpbmxvY2suaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2tmZF9pb2N0bC5oPgo+ICAjaW5jbHVkZSA8 bGludXgvaWRyLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9rZmlmby5oPgo+ICAjaW5jbHVkZSA8a2dk X2tmZF9pbnRlcmZhY2UuaD4KPgo+ICAjaW5jbHVkZSAiYW1kX3NoYXJlZC5oIgo+IEBAIC0xODIs MTAgKzE4Myw3IEBAIHN0cnVjdCBrZmRfZGV2IHsKPiAgICAgICAgIHVuc2lnbmVkIGludCBndHRf c2FfbnVtX29mX2NodW5rczsKPgo+ICAgICAgICAgLyogSW50ZXJydXB0cyAqLwo+IC0gICAgICAg dm9pZCAqaW50ZXJydXB0X3Jpbmc7Cj4gLSAgICAgICBzaXplX3QgaW50ZXJydXB0X3Jpbmdfc2l6 ZTsKPiAtICAgICAgIGF0b21pY190IGludGVycnVwdF9yaW5nX3JwdHI7Cj4gLSAgICAgICBhdG9t aWNfdCBpbnRlcnJ1cHRfcmluZ193cHRyOwo+ICsgICAgICAgc3RydWN0IGtmaWZvIGloX2ZpZm87 Cj4gICAgICAgICBzdHJ1Y3Qgd29ya19zdHJ1Y3QgaW50ZXJydXB0X3dvcms7Cj4gICAgICAgICBz cGlubG9ja190IGludGVycnVwdF9sb2NrOwo+Cj4gLS0KPiAyLjcuNAo+CgpUaGlzIHBhdGNoIGlz OgpBY2tlZC1ieTogT2RlZCBHYWJiYXkgPG9kZWQuZ2FiYmF5QGdtYWlsLmNvbT4KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==