From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PULL] drm-amdkfd-next Date: Tue, 19 May 2015 07:39:08 +0300 Message-ID: References: <20150518062940.GA23029@odedg-home> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0122029054==" Return-path: Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com [209.85.214.173]) by gabe.freedesktop.org (Postfix) with ESMTP id 84D7D6E1EE for ; Mon, 18 May 2015 21:39:09 -0700 (PDT) Received: by obblk2 with SMTP id lk2so3479335obb.0 for ; Mon, 18 May 2015 21:39:09 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org --===============0122029054== Content-Type: multipart/alternative; boundary=001a113cd1382b00ec051667e44f --001a113cd1382b00ec051667e44f Content-Type: text/plain; charset=UTF-8 On May 19, 2015 3:16 AM, "Dave Airlie" wrote: > > >>> >>> drm-amdkfd-next-2015-05-18: >>> >>> - Add the interrupts & events modules, including new IOCTLs to create and wait >>> on events. The HSA RT open source stack is mainly using events to know when >>> a dispatched work has been completed. In addition, this module is >>> a pre-requisite for the next module I'm going to upstream - debugger support >>> >>> This module also handles H/W exceptions, such as memory exception received >>> through the IOMMUv2 H/W and Bad Opcode exception receieved from the GPU. >>> >>> - Adding a new kernel module parameter to let the user decide whether he wants >>> to receive a SIGTERM when a memory exception occurs inside the GPU kernel and >>> the HSA application doesn't wait on an appropriate event, or if he just want >>> to receive notification about this event in dmesg. The default is the latter. >>> >>> - Additional improvements for SDMA code >>> >>> - Update my email address in Maintainers file as I'm leaving AMD in two weeks. > > > Two things, > > a) pull request from ssh:// please fix scripts to generate git:// URLs, > > b) ioctls with bool in them make me worry, four packed bool's even more, > 4 packed bools with a 64-bit straight after them put me over the not pulling this edge. > > I don't trust bools in ioctl defintions, please use explicitly sized types. > > Dave. Thanks Dave, No problem, I'll fix and resend it today. Oded --001a113cd1382b00ec051667e44f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On May 19, 2015 3:16 AM, "Dave Airlie" <airlied@gmail.com> wrote:
>
>
>>>
>>> drm-amdkfd-next-2015-05-18:
>>>
>>> - Add the interrupts & events modules, including new IOCTL= s to create and wait
>>> =C2=A0 on events. The HSA RT open source stack is mainly using= events to know when
>>> =C2=A0 a dispatched work has been completed. In addition, this= module is
>>> =C2=A0 a pre-requisite for the next module I'm going to up= stream - debugger support
>>>
>>> =C2=A0 This module also handles H/W exceptions, such as memory= exception received
>>> =C2=A0 through the IOMMUv2 H/W and Bad Opcode exception receie= ved from the GPU.
>>>
>>> - Adding a new kernel module parameter to let the user decide = whether he wants
>>> =C2=A0 to receive a SIGTERM when a memory exception occurs ins= ide the GPU kernel and
>>> =C2=A0 the HSA application doesn't wait on an appropriate = event, or if he just want
>>> =C2=A0 to receive notification about this event in dmesg. The = default is the latter.
>>>
>>> - Additional improvements for SDMA code
>>>
>>> - Update my email address in Maintainers file as I'm leavi= ng AMD in two weeks.
>
>
> Two things,
>
> a) pull request from ssh:// please fix scripts to generate git:// URLs= ,
>
> b) ioctls with bool in them make me worry, four packed bool's even= more,
> 4 packed bools with a 64-bit straight after them put me over the not p= ulling this edge.
>
> I don't trust bools in ioctl defintions, please use explicitly siz= ed types.
>
> Dave.

Thanks Dave,
No problem, I'll fix and resend it today.

Oded

--001a113cd1382b00ec051667e44f-- --===============0122029054== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0122029054==--