From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751786AbcDRHC5 (ORCPT ); Mon, 18 Apr 2016 03:02:57 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35595 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbcDRHCz convert rfc822-to-8bit (ORCPT ); Mon, 18 Apr 2016 03:02:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> <570BA694.8040900@amd.com> <570BAC2B.4090508@amd.com> <20160412220715.GL1990@wotan.suse.de> From: Oded Gabbay Date: Mon, 18 Apr 2016 10:02:24 +0300 Message-ID: Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu To: "Luis R. Rodriguez" Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= , "Linux-Kernel@Vger. Kernel. Org" , iommu@lists.linux-foundation.org, Joerg Roedel Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 18, 2016 at 9:55 AM, Luis R. Rodriguez wrote: > > On Apr 18, 2016 7:48 AM, "Oded Gabbay" wrote: >> >> On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez >> wrote: >> > On Mon, Apr 11, 2016 at 03:52:43PM +0200, Christian König wrote: >> >> Am 11.04.2016 um 15:39 schrieb Oded Gabbay: >> >> >On Mon, Apr 11, 2016 at 4:28 PM, Christian König >> >> > wrote: >> >> >>Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: >> >> >>>On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez >> >> >>> wrote: >> >> >>>>We need to ensure amd iommu v2 initializes before >> >> >>>>driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, >> >> >>>>to do this make its init routine a subsys_initcall() which >> >> >>>>ensures its load init is called first than modules when >> >> >>>>built-in. >> >> >>>> >> >> >>>>This reverts the old work around implemented through commit >> >> >>>>1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in >> >> >>>> Makefile"), >> >> >>>>instead of making the dependency implicit by linker order this >> >> >>>>makes the ordering requirement explicit through proper kernel >> >> >>>>APIs. >> >> >>>> >> >> >>>>Cc: Oded Gabbay >> >> >>>>Cc: Christian König >> >> >>>>Signed-off-by: Luis R. Rodriguez >> >> >> >> >> >>Sorry for not responding earlier. Just coming back to all the stuff >> >> >> on my TODO list. >> >> >> >> >> >>Patch is Acked-by: Christian König >> >> > >> >> >Christian, >> >> >Just wanted to be sure if you tested this patch-set or not. >> >> >> >> I did NOT tested it. If AMD IOMMU requires something which will now >> >> initialize after the IOMMU module we will obviously run into trouble >> >> again. >> >> >> >> I assumed that the creator of the patch did some testing. >> > >> > Nope, hence [RTF] Request For Testing. >> > >> >> >I don't think it should be merged without testing. If you already >> >> >tested it than fine. If not, I think I can do it in the next week or >> >> >so (just came back from PTO). >> >> >> >> Yeah, agree totally. >> > >> > Agreed, please let me know if someone is able to test and confirm >> > this works. It should work. >> > >> > Luis >> >> Hi, >> So I finally got to test this patch and it's not working. >> The reason is that AMD IOMMUv2 gets initialized *before* AMD IOMMUv1 >> driver ! > > Thanks can you try using late_initcall() instead then? > > Luis That will make it initialize *after* drm subsystem, which will cause another bug. Oded From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu Date: Mon, 18 Apr 2016 10:02:24 +0300 Message-ID: References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> <570BA694.8040900@amd.com> <570BAC2B.4090508@amd.com> <20160412220715.GL1990@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Luis R. Rodriguez" Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, =?UTF-8?Q?Christian_K=C3=B6nig?= , "Linux-Kernel@Vger. Kernel. Org" List-Id: iommu@lists.linux-foundation.org T24gTW9uLCBBcHIgMTgsIDIwMTYgYXQgOTo1NSBBTSwgTHVpcyBSLiBSb2RyaWd1ZXogPG1jZ3Jv ZkBrZXJuZWwub3JnPiB3cm90ZToKPgo+IE9uIEFwciAxOCwgMjAxNiA3OjQ4IEFNLCAiT2RlZCBH YWJiYXkiIDxvZGVkLmdhYmJheUBnbWFpbC5jb20+IHdyb3RlOgo+Pgo+PiBPbiBXZWQsIEFwciAx MywgMjAxNiBhdCAxOjA3IEFNLCBMdWlzIFIuIFJvZHJpZ3VleiA8bWNncm9mQGtlcm5lbC5vcmc+ Cj4+IHdyb3RlOgo+PiA+IE9uIE1vbiwgQXByIDExLCAyMDE2IGF0IDAzOjUyOjQzUE0gKzAyMDAs IENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4+ID4+IEFtIDExLjA0LjIwMTYgdW0gMTU6Mzkgc2No cmllYiBPZGVkIEdhYmJheToKPj4gPj4gPk9uIE1vbiwgQXByIDExLCAyMDE2IGF0IDQ6MjggUE0s IENocmlzdGlhbiBLw7ZuaWcKPj4gPj4gPjxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+IHdyb3Rl Ogo+PiA+PiA+PkFtIDA5LjA0LjIwMTYgdW0gMDI6MjUgc2NocmllYiBMdWlzIFIuIFJvZHJpZ3Vl ejoKPj4gPj4gPj4+T24gVHVlLCBNYXIgMjksIDIwMTYgYXQgMTA6NDEgQU0sIEx1aXMgUi4gUm9k cmlndWV6Cj4+ID4+ID4+PiA8bWNncm9mQGtlcm5lbC5vcmc+IHdyb3RlOgo+PiA+PiA+Pj4+V2Ug bmVlZCB0byBlbnN1cmUgYW1kIGlvbW11IHYyIGluaXRpYWxpemVzIGJlZm9yZQo+PiA+PiA+Pj4+ ZHJpdmVyIHVzZXMgc3VjaCBhcyBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfbW9kdWxl LmMsCj4+ID4+ID4+Pj50byBkbyB0aGlzIG1ha2UgaXRzIGluaXQgcm91dGluZSBhIHN1YnN5c19p bml0Y2FsbCgpIHdoaWNoCj4+ID4+ID4+Pj5lbnN1cmVzIGl0cyBsb2FkIGluaXQgaXMgY2FsbGVk IGZpcnN0IHRoYW4gbW9kdWxlcyB3aGVuCj4+ID4+ID4+Pj5idWlsdC1pbi4KPj4gPj4gPj4+Pgo+ PiA+PiA+Pj4+VGhpcyByZXZlcnRzIHRoZSBvbGQgd29yayBhcm91bmQgaW1wbGVtZW50ZWQgdGhy b3VnaCBjb21taXQKPj4gPj4gPj4+PjFiYWNjODk0YzIyN2ZhZDhhNyAoImRyaXZlcnM6IE1vdmUg aW9tbXUvIGJlZm9yZSBncHUvIGluCj4+ID4+ID4+Pj4gTWFrZWZpbGUiKSwKPj4gPj4gPj4+Pmlu c3RlYWQgb2YgbWFraW5nIHRoZSBkZXBlbmRlbmN5IGltcGxpY2l0IGJ5IGxpbmtlciBvcmRlciB0 aGlzCj4+ID4+ID4+Pj5tYWtlcyB0aGUgb3JkZXJpbmcgcmVxdWlyZW1lbnQgZXhwbGljaXQgdGhy b3VnaCBwcm9wZXIga2VybmVsCj4+ID4+ID4+Pj5BUElzLgo+PiA+PiA+Pj4+Cj4+ID4+ID4+Pj5D YzogT2RlZCBHYWJiYXkgPG9kZWQuZ2FiYmF5QGFtZC5jb20+Cj4+ID4+ID4+Pj5DYzogQ2hyaXN0 aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+PiA+PiA+Pj4+U2lnbmVkLW9m Zi1ieTogTHVpcyBSLiBSb2RyaWd1ZXogPG1jZ3JvZkBrZXJuZWwub3JnPgo+PiA+PiA+Pgo+PiA+ PiA+PlNvcnJ5IGZvciBub3QgcmVzcG9uZGluZyBlYXJsaWVyLiBKdXN0IGNvbWluZyBiYWNrIHRv IGFsbCB0aGUgc3R1ZmYKPj4gPj4gPj4gb24gbXkgVE9ETyBsaXN0Lgo+PiA+PiA+Pgo+PiA+PiA+ PlBhdGNoIGlzIEFja2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFt ZC5jb20+Cj4+ID4+ID4KPj4gPj4gPkNocmlzdGlhbiwKPj4gPj4gPkp1c3Qgd2FudGVkIHRvIGJl IHN1cmUgaWYgeW91IHRlc3RlZCB0aGlzIHBhdGNoLXNldCBvciBub3QuCj4+ID4+Cj4+ID4+IEkg ZGlkIE5PVCB0ZXN0ZWQgaXQuIElmIEFNRCBJT01NVSByZXF1aXJlcyBzb21ldGhpbmcgd2hpY2gg d2lsbCBub3cKPj4gPj4gaW5pdGlhbGl6ZSBhZnRlciB0aGUgSU9NTVUgbW9kdWxlIHdlIHdpbGwg b2J2aW91c2x5IHJ1biBpbnRvIHRyb3VibGUKPj4gPj4gYWdhaW4uCj4+ID4+Cj4+ID4+IEkgYXNz dW1lZCB0aGF0IHRoZSBjcmVhdG9yIG9mIHRoZSBwYXRjaCBkaWQgc29tZSB0ZXN0aW5nLgo+PiA+ Cj4+ID4gTm9wZSwgaGVuY2UgW1JURl0gUmVxdWVzdCBGb3IgVGVzdGluZy4KPj4gPgo+PiA+PiA+ SSBkb24ndCB0aGluayBpdCBzaG91bGQgYmUgbWVyZ2VkIHdpdGhvdXQgdGVzdGluZy4gSWYgeW91 IGFscmVhZHkKPj4gPj4gPnRlc3RlZCBpdCB0aGFuIGZpbmUuIElmIG5vdCwgSSB0aGluayBJIGNh biBkbyBpdCBpbiB0aGUgbmV4dCB3ZWVrIG9yCj4+ID4+ID5zbyAoanVzdCBjYW1lIGJhY2sgZnJv bSBQVE8pLgo+PiA+Pgo+PiA+PiBZZWFoLCBhZ3JlZSB0b3RhbGx5Lgo+PiA+Cj4+ID4gQWdyZWVk LCBwbGVhc2UgbGV0IG1lIGtub3cgaWYgc29tZW9uZSBpcyBhYmxlIHRvIHRlc3QgYW5kIGNvbmZp cm0KPj4gPiB0aGlzIHdvcmtzLiBJdCBzaG91bGQgd29yay4KPj4gPgo+PiA+ICAgTHVpcwo+Pgo+ PiBIaSwKPj4gU28gSSBmaW5hbGx5IGdvdCB0byB0ZXN0IHRoaXMgcGF0Y2ggYW5kIGl0J3Mgbm90 IHdvcmtpbmcuCj4+IFRoZSByZWFzb24gaXMgdGhhdCBBTUQgSU9NTVV2MiBnZXRzIGluaXRpYWxp emVkICpiZWZvcmUqIEFNRCBJT01NVXYxCj4+IGRyaXZlciAhCj4KPiBUaGFua3MgY2FuIHlvdSB0 cnkgdXNpbmcgbGF0ZV9pbml0Y2FsbCgpIGluc3RlYWQgdGhlbj8KPgo+ICAgTHVpcwoKVGhhdCB3 aWxsIG1ha2UgaXQgaW5pdGlhbGl6ZSAqYWZ0ZXIqIGRybSBzdWJzeXN0ZW0sIHdoaWNoIHdpbGwg Y2F1c2UKYW5vdGhlciBidWcuCgpPZGVkCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmlvbW11IG1haWxpbmcgbGlzdAppb21tdUBsaXN0cy5saW51eC1mb3Vu ZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0 aW5mby9pb21tdQ==