From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AD8C433E3 for ; Mon, 29 Jun 2020 18:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 406172225F for ; Mon, 29 Jun 2020 18:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iJsS8hBM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgF2SiN (ORCPT ); Mon, 29 Jun 2020 14:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727969AbgF2SiC (ORCPT ); Mon, 29 Jun 2020 14:38:02 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEA47C02F032 for ; Mon, 29 Jun 2020 08:00:51 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id 5so13780100oty.11 for ; Mon, 29 Jun 2020 08:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=64cs0TbTbP8oXkjqFwlVyOK6sTxRyWaYSp+tM0bVADY=; b=iJsS8hBM9QxkxafcTMtycbQCdy9iovLnZQNdm8sCMuUW7wM0vJYf5QfWXoLeJioLI9 zuvRpVpeKmZt7ZodsyhJFd7sMFqdMhqfJaDmmNRU088OIknBDX2Qfw3w74wbyBichTco 0AoN+RjPb0ODn5sXj655D7NhIWazi7BLmbQ5QZkVjOjHcgRp8JDNfrBkm/Z/pmvtz5lW sqfT4dwvk9uyfa+TPJc7Rb1sANktKemkQv0y3XrC/ZHh+CvhL6rHiv5IcqUlLuRyNU9o ZN6zW0cF4acVTqClrpTBc3bdnzXC3B6KxGjzrkaZ7ViJ+uGfpZ8ARYYSTDPcvO0sKb5n 5RfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=64cs0TbTbP8oXkjqFwlVyOK6sTxRyWaYSp+tM0bVADY=; b=NuIo1VlcZv49m6B1n4c/lzUFZiUpCZG11pyYTVCnviiD1ppRJ/TXyVgpMqv0D4zrkp dDKbFLhUc7fhj/qNWM49I+KdDddFcvUOaHAyQfLrjIn5LeG1t4Xpo13yxo70F8m8PXZ4 LtYu59wWjWLUH1614ELGr05qUbCivAh9jK4RDAMvJKCC19Bcjr8JJw/M8lS7nB/020wv OVLKMBXwGm29xGJ0VrUJS4lII+6QuMasudTvWIw0GwvpAYMKMDRYp2JR+Q6qKiD6E2pf cRH+RVj/HSmUX+zMWVVu3sSrFl2zcXK6ViXcq1cx55bHxZFezJwhIelkLXt/Tb+XO/ei Jwgg== X-Gm-Message-State: AOAM532doZIboY7Xgwhr4+YsKfOpUWMS4PTKsM5WET7COFhGAevWSaSN cJxfJMkXO+MqmmYHd8C/joXBHrA3QB9X2ow9FRs= X-Google-Smtp-Source: ABdhPJzhdHJhL6wz1HDjdvznHpIGmS/1e0gDDMgS5NOP2fYaMZB7eIyrlZjLdTrGaY2+0NhG+ZKaNsBIJm4MAxyRH3Y= X-Received: by 2002:a9d:904:: with SMTP id 4mr14130648otp.339.1593442851032; Mon, 29 Jun 2020 08:00:51 -0700 (PDT) MIME-Version: 1.0 References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-7-lee.jones@linaro.org> In-Reply-To: <20200629140442.1043957-7-lee.jones@linaro.org> From: Oded Gabbay Date: Mon, 29 Jun 2020 18:00:21 +0300 Message-ID: Subject: Re: [PATCH 06/20] misc: habanalabs: goya: Omit pointless check ensuring addr is >=0 To: Lee Jones Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, "Linux-Kernel@Vger. Kernel. Org" , Tomer Tayar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 5:04 PM Lee Jones wrote: > > Seeing as 'addr' is unsigned, it would be impossible for the assigned > value to be anything other than zero or positive. > > Squashes the following W=3D1 warnings: > > drivers/misc/habanalabs/goya/goya.c: In function =E2=80=98goya_debugfs_r= ead32=E2=80=99: > drivers/misc/habanalabs/goya/goya.c:3945:19: warning: comparison of unsi= gned expression >=3D 0 is always true [-Wtype-limits] > 3945 | } else if ((addr >=3D DRAM_PHYS_BASE) && > | ^~ > drivers/misc/habanalabs/goya/goya.c: In function =E2=80=98goya_debugfs_w= rite32=E2=80=99: > drivers/misc/habanalabs/goya/goya.c:4002:19: warning: comparison of unsi= gned expression >=3D 0 is always true [-Wtype-limits] > 4002 | } else if ((addr >=3D DRAM_PHYS_BASE) && > | ^~ > drivers/misc/habanalabs/goya/goya.c: In function =E2=80=98goya_debugfs_r= ead64=E2=80=99: > drivers/misc/habanalabs/goya/goya.c:4047:19: warning: comparison of unsi= gned expression >=3D 0 is always true [-Wtype-limits] > 4047 | } else if ((addr >=3D DRAM_PHYS_BASE) && > | ^~ > drivers/misc/habanalabs/goya/goya.c: In function =E2=80=98goya_debugfs_w= rite64=E2=80=99: > drivers/misc/habanalabs/goya/goya.c:4091:19: warning: comparison of unsi= gned expression >=3D 0 is always true [-Wtype-limits] > 4091 | } else if ((addr >=3D DRAM_PHYS_BASE) && > | ^~ > drivers/misc/habanalabs/pci.c:328: warning: Excess function parameter 'd= ma_mask' description in 'hl_pci_set_dma_mask' > drivers/misc/habanalabs/goya/goya_coresight.c: In function =E2=80=98goya= _debug_coresight=E2=80=99: > drivers/misc/habanalabs/goya/goya_coresight.c:643:6: warning: variable = =E2=80=98val=E2=80=99 set but not used [-Wunused-but-set-variable] > 643 | u32 val; > | ^~~ > > Cc: Oded Gabbay > Cc: Tomer Tayar > Signed-off-by: Lee Jones > --- > drivers/misc/habanalabs/goya/goya.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalab= s/goya/goya.c > index 0d2952bb58dfb..a4a20e27ed3b4 100644 > --- a/drivers/misc/habanalabs/goya/goya.c > +++ b/drivers/misc/habanalabs/goya/goya.c > @@ -3942,8 +3942,7 @@ static int goya_debugfs_read32(struct hl_device *hd= ev, u64 addr, u32 *val) > *val =3D readl(hdev->pcie_bar[SRAM_CFG_BAR_ID] + > (addr - SRAM_BASE_ADDR)); > > - } else if ((addr >=3D DRAM_PHYS_BASE) && > - (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_siz= e)) { > + } else if (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_size) { > > u64 bar_base_addr =3D DRAM_PHYS_BASE + > (addr & ~(prop->dram_pci_bar_size - 0x1ul= l)); > @@ -3999,8 +3998,7 @@ static int goya_debugfs_write32(struct hl_device *h= dev, u64 addr, u32 val) > writel(val, hdev->pcie_bar[SRAM_CFG_BAR_ID] + > (addr - SRAM_BASE_ADDR)); > > - } else if ((addr >=3D DRAM_PHYS_BASE) && > - (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_siz= e)) { > + } else if (addr < DRAM_PHYS_BASE + hdev->asic_prop.dram_size) { > > u64 bar_base_addr =3D DRAM_PHYS_BASE + > (addr & ~(prop->dram_pci_bar_size - 0x1ul= l)); > @@ -4044,9 +4042,8 @@ static int goya_debugfs_read64(struct hl_device *hd= ev, u64 addr, u64 *val) > *val =3D readq(hdev->pcie_bar[SRAM_CFG_BAR_ID] + > (addr - SRAM_BASE_ADDR)); > > - } else if ((addr >=3D DRAM_PHYS_BASE) && > - (addr <=3D > - DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u= 64))) { > + } else if (addr <=3D > + DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u6= 4)) { > > u64 bar_base_addr =3D DRAM_PHYS_BASE + > (addr & ~(prop->dram_pci_bar_size - 0x1ul= l)); > @@ -4088,9 +4085,8 @@ static int goya_debugfs_write64(struct hl_device *h= dev, u64 addr, u64 val) > writeq(val, hdev->pcie_bar[SRAM_CFG_BAR_ID] + > (addr - SRAM_BASE_ADDR)); > > - } else if ((addr >=3D DRAM_PHYS_BASE) && > - (addr <=3D > - DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u= 64))) { > + } else if (addr <=3D > + DRAM_PHYS_BASE + hdev->asic_prop.dram_size - sizeof(u6= 4)) { > > u64 bar_base_addr =3D DRAM_PHYS_BASE + > (addr & ~(prop->dram_pci_bar_size - 0x1ul= l)); > -- > 2.25.1 > This patch is: Reviewed-by: Oded Gabbay From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24211C433E0 for ; Mon, 29 Jun 2020 15:02:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E440D23E53 for ; Mon, 29 Jun 2020 15:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w2zf7SP9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iJsS8hBM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E440D23E53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=93iuP9tCo5IOAI5da783HFDTgk+s7vHAf/dCNnC1OzM=; b=w2zf7SP9p1omCVyq2JIjFQsYC Lg8X0PTlBT8cdJVaKafg1gO4JuPwlXB11ZgQe0VGkD2iOpoWm/jlpBStIFsTtLwFnCQzsQ6qyOJJH sV507xbiLW6vrO2meNBJ20kmpmN0FmHMqjTxo8yUmwP9fKMCKPbFHOmNgNg/eRAKHJysCd7F12loD ou74mkT6hFXBR+6JYL708z9OGWj8dHKNx5TTUOGMw8X9m76lMIbvwsPkrSQc3jBXG0dK570WMeejW AFVIsCxl8qBG4fjxi9wfdVrVJo32Oj2zBIjkqagorF+dqsRpiKgw3IFCNeaS/7aTHHUfgWwMI0Bk5 iwTl1SL9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvHD-00085s-9O; Mon, 29 Jun 2020 15:00:55 +0000 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvHA-000859-ON for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 15:00:53 +0000 Received: by mail-ot1-x343.google.com with SMTP id q21so8253560otc.7 for ; Mon, 29 Jun 2020 08:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=64cs0TbTbP8oXkjqFwlVyOK6sTxRyWaYSp+tM0bVADY=; b=iJsS8hBM9QxkxafcTMtycbQCdy9iovLnZQNdm8sCMuUW7wM0vJYf5QfWXoLeJioLI9 zuvRpVpeKmZt7ZodsyhJFd7sMFqdMhqfJaDmmNRU088OIknBDX2Qfw3w74wbyBichTco 0AoN+RjPb0ODn5sXj655D7NhIWazi7BLmbQ5QZkVjOjHcgRp8JDNfrBkm/Z/pmvtz5lW sqfT4dwvk9uyfa+TPJc7Rb1sANktKemkQv0y3XrC/ZHh+CvhL6rHiv5IcqUlLuRyNU9o ZN6zW0cF4acVTqClrpTBc3bdnzXC3B6KxGjzrkaZ7ViJ+uGfpZ8ARYYSTDPcvO0sKb5n 5RfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=64cs0TbTbP8oXkjqFwlVyOK6sTxRyWaYSp+tM0bVADY=; b=BotQ4s8N1v3SHBIXV4wTSeJ06w/MbklfRV4Ne22cqI961djW+kQjBmF+yVdqvdkGnI 2QpjzDtg2NndIiClfD16YX+KA8eXBR1/AmKozO/iCVwDun5LSeZdSYBgziHmuUC1QSlY as3elieuNQdQBL8qfG53GMpxbvzzU/lVu23Tx8dh1Z7Tlh3u6tlS+jEhJQhAsKq2093m Y5hRq5wxrtPG9DsDEzPEc1GoWDjHxjLUKRwoL9CfgOWuH/c+5xsNWD8aeF9YVWJEFjin MHTlTVvMTPjMvYN+gss7qmgCCrQ58ivn0hzZ2ukL5OBoMC943FSWUZHIQA3A+I7IH0Ua 5wbw== X-Gm-Message-State: AOAM532Y3JuSddaRSEWQAhHC/iYofLhf50MsdTju1I0GnbvS8w6O9H7A b8kCRJkEfja+g10Y83Q9I8PXUTQIM15skOx0A8Y= X-Google-Smtp-Source: ABdhPJzhdHJhL6wz1HDjdvznHpIGmS/1e0gDDMgS5NOP2fYaMZB7eIyrlZjLdTrGaY2+0NhG+ZKaNsBIJm4MAxyRH3Y= X-Received: by 2002:a9d:904:: with SMTP id 4mr14130648otp.339.1593442851032; Mon, 29 Jun 2020 08:00:51 -0700 (PDT) MIME-Version: 1.0 References: <20200629140442.1043957-1-lee.jones@linaro.org> <20200629140442.1043957-7-lee.jones@linaro.org> In-Reply-To: <20200629140442.1043957-7-lee.jones@linaro.org> From: Oded Gabbay Date: Mon, 29 Jun 2020 18:00:21 +0300 Message-ID: Subject: Re: [PATCH 06/20] misc: habanalabs: goya: Omit pointless check ensuring addr is >=0 To: Lee Jones X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Tomer Tayar , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMjksIDIwMjAgYXQgNTowNCBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IFNlZWluZyBhcyAnYWRkcicgaXMgdW5zaWduZWQsIGl0IHdvdWxk IGJlIGltcG9zc2libGUgZm9yIHRoZSBhc3NpZ25lZAo+IHZhbHVlIHRvIGJlIGFueXRoaW5nIG90 aGVyIHRoYW4gemVybyBvciBwb3NpdGl2ZS4KPgo+IFNxdWFzaGVzIHRoZSBmb2xsb3dpbmcgVz0x IHdhcm5pbmdzOgo+Cj4gIGRyaXZlcnMvbWlzYy9oYWJhbmFsYWJzL2dveWEvZ295YS5jOiBJbiBm dW5jdGlvbiDigJhnb3lhX2RlYnVnZnNfcmVhZDMy4oCZOgo+ICBkcml2ZXJzL21pc2MvaGFiYW5h bGFicy9nb3lhL2dveWEuYzozOTQ1OjE5OiB3YXJuaW5nOiBjb21wYXJpc29uIG9mIHVuc2lnbmVk IGV4cHJlc3Npb24gPj0gMCBpcyBhbHdheXMgdHJ1ZSBbLVd0eXBlLWxpbWl0c10KPiAgMzk0NSB8 IH0gZWxzZSBpZiAoKGFkZHIgPj0gRFJBTV9QSFlTX0JBU0UpICYmCj4gIHwgXn4KPiAgZHJpdmVy cy9taXNjL2hhYmFuYWxhYnMvZ295YS9nb3lhLmM6IEluIGZ1bmN0aW9uIOKAmGdveWFfZGVidWdm c193cml0ZTMy4oCZOgo+ICBkcml2ZXJzL21pc2MvaGFiYW5hbGFicy9nb3lhL2dveWEuYzo0MDAy OjE5OiB3YXJuaW5nOiBjb21wYXJpc29uIG9mIHVuc2lnbmVkIGV4cHJlc3Npb24gPj0gMCBpcyBh bHdheXMgdHJ1ZSBbLVd0eXBlLWxpbWl0c10KPiAgNDAwMiB8IH0gZWxzZSBpZiAoKGFkZHIgPj0g RFJBTV9QSFlTX0JBU0UpICYmCj4gIHwgXn4KPiAgZHJpdmVycy9taXNjL2hhYmFuYWxhYnMvZ295 YS9nb3lhLmM6IEluIGZ1bmN0aW9uIOKAmGdveWFfZGVidWdmc19yZWFkNjTigJk6Cj4gIGRyaXZl cnMvbWlzYy9oYWJhbmFsYWJzL2dveWEvZ295YS5jOjQwNDc6MTk6IHdhcm5pbmc6IGNvbXBhcmlz b24gb2YgdW5zaWduZWQgZXhwcmVzc2lvbiA+PSAwIGlzIGFsd2F5cyB0cnVlIFstV3R5cGUtbGlt aXRzXQo+ICA0MDQ3IHwgfSBlbHNlIGlmICgoYWRkciA+PSBEUkFNX1BIWVNfQkFTRSkgJiYKPiAg fCBefgo+ICBkcml2ZXJzL21pc2MvaGFiYW5hbGFicy9nb3lhL2dveWEuYzogSW4gZnVuY3Rpb24g 4oCYZ295YV9kZWJ1Z2ZzX3dyaXRlNjTigJk6Cj4gIGRyaXZlcnMvbWlzYy9oYWJhbmFsYWJzL2dv eWEvZ295YS5jOjQwOTE6MTk6IHdhcm5pbmc6IGNvbXBhcmlzb24gb2YgdW5zaWduZWQgZXhwcmVz c2lvbiA+PSAwIGlzIGFsd2F5cyB0cnVlIFstV3R5cGUtbGltaXRzXQo+ICA0MDkxIHwgfSBlbHNl IGlmICgoYWRkciA+PSBEUkFNX1BIWVNfQkFTRSkgJiYKPiAgfCBefgo+ICBkcml2ZXJzL21pc2Mv aGFiYW5hbGFicy9wY2kuYzozMjg6IHdhcm5pbmc6IEV4Y2VzcyBmdW5jdGlvbiBwYXJhbWV0ZXIg J2RtYV9tYXNrJyBkZXNjcmlwdGlvbiBpbiAnaGxfcGNpX3NldF9kbWFfbWFzaycKPiAgZHJpdmVy cy9taXNjL2hhYmFuYWxhYnMvZ295YS9nb3lhX2NvcmVzaWdodC5jOiBJbiBmdW5jdGlvbiDigJhn b3lhX2RlYnVnX2NvcmVzaWdodOKAmToKPiAgZHJpdmVycy9taXNjL2hhYmFuYWxhYnMvZ295YS9n b3lhX2NvcmVzaWdodC5jOjY0Mzo2OiB3YXJuaW5nOiB2YXJpYWJsZSDigJh2YWzigJkgc2V0IGJ1 dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAgNjQzIHwgdTMyIHZhbDsK PiAgfCBefn4KPgo+IENjOiBPZGVkIEdhYmJheSA8b2RlZC5nYWJiYXlAZ21haWwuY29tPgo+IENj OiBUb21lciBUYXlhciA8dHRheWFyQGhhYmFuYS5haT4KPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9u ZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL21pc2MvaGFiYW5hbGFi cy9nb3lhL2dveWEuYyB8IDE2ICsrKysrKy0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDYg aW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t aXNjL2hhYmFuYWxhYnMvZ295YS9nb3lhLmMgYi9kcml2ZXJzL21pc2MvaGFiYW5hbGFicy9nb3lh L2dveWEuYwo+IGluZGV4IDBkMjk1MmJiNThkZmIuLmE0YTIwZTI3ZWQzYjQgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9taXNjL2hhYmFuYWxhYnMvZ295YS9nb3lhLmMKPiArKysgYi9kcml2ZXJzL21p c2MvaGFiYW5hbGFicy9nb3lhL2dveWEuYwo+IEBAIC0zOTQyLDggKzM5NDIsNyBAQCBzdGF0aWMg aW50IGdveWFfZGVidWdmc19yZWFkMzIoc3RydWN0IGhsX2RldmljZSAqaGRldiwgdTY0IGFkZHIs IHUzMiAqdmFsKQo+ICAgICAgICAgICAgICAgICAqdmFsID0gcmVhZGwoaGRldi0+cGNpZV9iYXJb U1JBTV9DRkdfQkFSX0lEXSArCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYWRk ciAtIFNSQU1fQkFTRV9BRERSKSk7Cj4KPiAtICAgICAgIH0gZWxzZSBpZiAoKGFkZHIgPj0gRFJB TV9QSFlTX0JBU0UpICYmCj4gLSAgICAgICAgICAgICAgICAgICAgICAgKGFkZHIgPCBEUkFNX1BI WVNfQkFTRSArIGhkZXYtPmFzaWNfcHJvcC5kcmFtX3NpemUpKSB7Cj4gKyAgICAgICB9IGVsc2Ug aWYgKGFkZHIgPCBEUkFNX1BIWVNfQkFTRSArIGhkZXYtPmFzaWNfcHJvcC5kcmFtX3NpemUpIHsK Pgo+ICAgICAgICAgICAgICAgICB1NjQgYmFyX2Jhc2VfYWRkciA9IERSQU1fUEhZU19CQVNFICsK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhZGRyICYgfihwcm9wLT5kcmFtX3Bj aV9iYXJfc2l6ZSAtIDB4MXVsbCkpOwo+IEBAIC0zOTk5LDggKzM5OTgsNyBAQCBzdGF0aWMgaW50 IGdveWFfZGVidWdmc193cml0ZTMyKHN0cnVjdCBobF9kZXZpY2UgKmhkZXYsIHU2NCBhZGRyLCB1 MzIgdmFsKQo+ICAgICAgICAgICAgICAgICB3cml0ZWwodmFsLCBoZGV2LT5wY2llX2JhcltTUkFN X0NGR19CQVJfSURdICsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGFkZHIgLSBTUkFNX0JBU0VfQUREUikpOwo+Cj4gLSAgICAgICB9IGVsc2UgaWYgKChhZGRyID49 IERSQU1fUEhZU19CQVNFKSAmJgo+IC0gICAgICAgICAgICAgICAgICAgICAgIChhZGRyIDwgRFJB TV9QSFlTX0JBU0UgKyBoZGV2LT5hc2ljX3Byb3AuZHJhbV9zaXplKSkgewo+ICsgICAgICAgfSBl bHNlIGlmIChhZGRyIDwgRFJBTV9QSFlTX0JBU0UgKyBoZGV2LT5hc2ljX3Byb3AuZHJhbV9zaXpl KSB7Cj4KPiAgICAgICAgICAgICAgICAgdTY0IGJhcl9iYXNlX2FkZHIgPSBEUkFNX1BIWVNfQkFT RSArCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYWRkciAmIH4ocHJvcC0+ZHJh bV9wY2lfYmFyX3NpemUgLSAweDF1bGwpKTsKPiBAQCAtNDA0NCw5ICs0MDQyLDggQEAgc3RhdGlj IGludCBnb3lhX2RlYnVnZnNfcmVhZDY0KHN0cnVjdCBobF9kZXZpY2UgKmhkZXYsIHU2NCBhZGRy LCB1NjQgKnZhbCkKPiAgICAgICAgICAgICAgICAgKnZhbCA9IHJlYWRxKGhkZXYtPnBjaWVfYmFy W1NSQU1fQ0ZHX0JBUl9JRF0gKwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFk ZHIgLSBTUkFNX0JBU0VfQUREUikpOwo+Cj4gLSAgICAgICB9IGVsc2UgaWYgKChhZGRyID49IERS QU1fUEhZU19CQVNFKSAmJgo+IC0gICAgICAgICAgICAgICAgICAoYWRkciA8PQo+IC0gICAgICAg ICAgICAgICAgICAgRFJBTV9QSFlTX0JBU0UgKyBoZGV2LT5hc2ljX3Byb3AuZHJhbV9zaXplIC0g c2l6ZW9mKHU2NCkpKSB7Cj4gKyAgICAgICB9IGVsc2UgaWYgKGFkZHIgPD0KPiArICAgICAgICAg ICAgICAgICAgRFJBTV9QSFlTX0JBU0UgKyBoZGV2LT5hc2ljX3Byb3AuZHJhbV9zaXplIC0gc2l6 ZW9mKHU2NCkpIHsKPgo+ICAgICAgICAgICAgICAgICB1NjQgYmFyX2Jhc2VfYWRkciA9IERSQU1f UEhZU19CQVNFICsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhZGRyICYgfihw cm9wLT5kcmFtX3BjaV9iYXJfc2l6ZSAtIDB4MXVsbCkpOwo+IEBAIC00MDg4LDkgKzQwODUsOCBA QCBzdGF0aWMgaW50IGdveWFfZGVidWdmc193cml0ZTY0KHN0cnVjdCBobF9kZXZpY2UgKmhkZXYs IHU2NCBhZGRyLCB1NjQgdmFsKQo+ICAgICAgICAgICAgICAgICB3cml0ZXEodmFsLCBoZGV2LT5w Y2llX2JhcltTUkFNX0NGR19CQVJfSURdICsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGFkZHIgLSBTUkFNX0JBU0VfQUREUikpOwo+Cj4gLSAgICAgICB9IGVsc2Ug aWYgKChhZGRyID49IERSQU1fUEhZU19CQVNFKSAmJgo+IC0gICAgICAgICAgICAgICAgICAoYWRk ciA8PQo+IC0gICAgICAgICAgICAgICAgICAgRFJBTV9QSFlTX0JBU0UgKyBoZGV2LT5hc2ljX3By b3AuZHJhbV9zaXplIC0gc2l6ZW9mKHU2NCkpKSB7Cj4gKyAgICAgICB9IGVsc2UgaWYgKGFkZHIg PD0KPiArICAgICAgICAgICAgICAgICAgRFJBTV9QSFlTX0JBU0UgKyBoZGV2LT5hc2ljX3Byb3Au ZHJhbV9zaXplIC0gc2l6ZW9mKHU2NCkpIHsKPgo+ICAgICAgICAgICAgICAgICB1NjQgYmFyX2Jh c2VfYWRkciA9IERSQU1fUEhZU19CQVNFICsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChhZGRyICYgfihwcm9wLT5kcmFtX3BjaV9iYXJfc2l6ZSAtIDB4MXVsbCkpOwo+IC0tCj4g Mi4yNS4xCj4KClRoaXMgcGF0Y2ggaXM6ClJldmlld2VkLWJ5OiBPZGVkIEdhYmJheSA8b2RlZC5n YWJiYXlAZ21haWwuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=