From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8285C4363D for ; Fri, 2 Oct 2020 19:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B633206DB for ; Fri, 2 Oct 2020 19:22:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyCYGPD3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388549AbgJBTWq (ORCPT ); Fri, 2 Oct 2020 15:22:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388451AbgJBTWS (ORCPT ); Fri, 2 Oct 2020 15:22:18 -0400 Received: from mail-oo1-xc42.google.com (mail-oo1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97FA9C0613D0; Fri, 2 Oct 2020 12:22:15 -0700 (PDT) Received: by mail-oo1-xc42.google.com with SMTP id g26so621628ooa.9; Fri, 02 Oct 2020 12:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=pyCYGPD3z231H+FQCXNEMLBtwRoKmxKBpFEKm871TgQU8g0X8z2LzGq3oGkeS5tId6 2OjBG9lDxg08oGQpJZn5YUoFRjrDuVdqQVFb4w+hBOrxNG6DqBJwawSIiKC9egvCjB02 Xw0waBU/U8aGynIrCK89k3Jdpw7z3gEFzB4jasOXhXEyNbxDcZrLX7dRpFGKQoKw1Tws aLL3JDgghZLFX8ZY8jZDZOeRMejsM+55Cdtpn64aGJMuNlg/C9MwjlV2q4dNBpKlf7yk 7CMS1H3Bkbl6Ac+k8YwG1V0D40n/6TqKugG/Uh9B1bMTgFcoERjMQ390o1uoJ6zqs1ZP ObOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=IlKRih1aUtcUykxiNm2BBs0g4FhIG2XCowYqCpAmBRYlL2Pj8xSc7Y/+l2d6rE4taX uwwFwDIWidpN3G585JF5lBD3PSkE+T8+sDt/yt0PHzFjzYwp0JYKDyIKvGHcRCXkCOKi ULNPFo2hjchogUW43sNZCQPLs18VPKWCImgJh3CeQKzacg8sOgiLy3YskjgU5wh+0IRY Fu2ox1mOr0lnL/X0QImD8A502xoC7n6VIKHbNPfpQ+eG9IsMUzCXFluo+f2BEYDQqSB2 u9oiO9OvRP5oHNhg6AOQYD1PyIlOh0g3VvBEJvo0JoQo1xPnWx3WW/vdcclxpsXXArVY drPw== X-Gm-Message-State: AOAM533ldunzwLVuaadzIGaDmllZAZh5+LEvyW9ZCs8AoiJfkgjWeueg 0sty1Oo11Tl1A75EWCavJkCVh9T75Oy3RFbNRRY= X-Google-Smtp-Source: ABdhPJx7YX8zviFjrOEhTKLkYmCq2KlFovtI8luMYDcSxruAN3b9De/JFEEiXwNOCHvtvZ+X9imhz+Hlu9vqUFcQCHI= X-Received: by 2002:a4a:d509:: with SMTP id m9mr3027482oos.77.1601666534935; Fri, 02 Oct 2020 12:22:14 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> In-Reply-To: From: Oded Gabbay Date: Fri, 2 Oct 2020 22:21:47 +0300 Message-ID: Subject: Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames() To: Tomasz Figa Cc: Daniel Vetter , DRI Development , LKML , Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Pawel Osciak , Marek Szyprowski , Andrew Morton , Omer Shpigelman , Tomer Tayar , Greg Kroah-Hartman , Pawel Piskorski , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-samsung-soc , Linux Media Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 2, 2020 at 9:23 PM Tomasz Figa wrote: > > On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > > simple dma device that can't guarantee write protection. Which is also > > what all the callers are using. > > > > So just simplify this. > > > > Signed-off-by: Daniel Vetter > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: Kukjin Kim > > Cc: Krzysztof Kozlowski > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Tomasz Figa > > Cc: Andrew Morton > > Cc: Oded Gabbay > > Cc: Omer Shpigelman > > Cc: Tomer Tayar > > Cc: Greg Kroah-Hartman > > Cc: Pawel Piskorski > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-mm@kvack.org > > --- > > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > > drivers/misc/habanalabs/common/memory.c | 3 +-- > > include/linux/mm.h | 2 +- > > mm/frame_vector.c | 4 ++-- > > 5 files changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > index 967a5cdc120e..ac452842bab3 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > > goto err_free; > > } > > > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > > - g2d_userptr->vec); > > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > > if (ret != npages) { > > DRM_DEV_ERROR(g2d->dev, > > "failed to get user pages from userptr.\n"); > > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c b/drivers/media/common/videobuf2/videobuf2-memops.c > > index 6e9e05153f4e..9dd6c27162f4 100644 > > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > unsigned long first, last; > > unsigned long nr; > > struct frame_vector *vec; > > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > > > first = start >> PAGE_SHIFT; > > last = (start + length - 1) >> PAGE_SHIFT; > > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > vec = frame_vector_create(nr); > > if (!vec) > > return ERR_PTR(-ENOMEM); > > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > > if (ret < 0) > > goto out_destroy; > > /* We accept only complete set of PFNs */ > > For drivers/media/common/videobuf2/: > > Acked-by: Tomasz Figa > > Best regards, > Tomasz For drivers/misc/habanalabs: Acked-by: Oded Gabbay Thanks, Oded From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA07CC35257 for ; Fri, 2 Oct 2020 19:22:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22206206DB for ; Fri, 2 Oct 2020 19:22:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyCYGPD3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22206206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1D9716B005C; Fri, 2 Oct 2020 15:22:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18AF96B005D; Fri, 2 Oct 2020 15:22:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09F206B0062; Fri, 2 Oct 2020 15:22:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0202.hostedemail.com [216.40.44.202]) by kanga.kvack.org (Postfix) with ESMTP id D24E56B005C for ; Fri, 2 Oct 2020 15:22:16 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 61EF9180AD807 for ; Fri, 2 Oct 2020 19:22:16 +0000 (UTC) X-FDA: 77327956272.10.push76_6010b23271a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 2921116A0DE for ; Fri, 2 Oct 2020 19:22:16 +0000 (UTC) X-HE-Tag: push76_6010b23271a6 X-Filterd-Recvd-Size: 7324 Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 19:22:15 +0000 (UTC) Received: by mail-oo1-f66.google.com with SMTP id z1so623205ooj.3 for ; Fri, 02 Oct 2020 12:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=pyCYGPD3z231H+FQCXNEMLBtwRoKmxKBpFEKm871TgQU8g0X8z2LzGq3oGkeS5tId6 2OjBG9lDxg08oGQpJZn5YUoFRjrDuVdqQVFb4w+hBOrxNG6DqBJwawSIiKC9egvCjB02 Xw0waBU/U8aGynIrCK89k3Jdpw7z3gEFzB4jasOXhXEyNbxDcZrLX7dRpFGKQoKw1Tws aLL3JDgghZLFX8ZY8jZDZOeRMejsM+55Cdtpn64aGJMuNlg/C9MwjlV2q4dNBpKlf7yk 7CMS1H3Bkbl6Ac+k8YwG1V0D40n/6TqKugG/Uh9B1bMTgFcoERjMQ390o1uoJ6zqs1ZP ObOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=lIghkGmEOox2GW/pLiSNgxfTXySGQyR1LKeoUDKC5UgKAVWZv3LU19TjIw2JsSDLMF rovmyj0/uOXE2KKN05Bp1pUqTl3KS4OvoiniQp40/404H9dk1n6P88wjtX1paj1twL2y OrUTbgcTm1y1bbShzXkZRuWrNP5V63Sv5IqzIeatbGA/QMrfBq/fOyw6tQMiXfXr9cWL WVjHo7fmi3GGfxFzNdNcphUwqGdV91VP/Ojt6CLnObc4RRTXWMadV318/feuGx88IfSa wwnRj3tGC+w1LuFBjqPrjVHIdPAyu0gzGn44ngYqeu0CaXb2yc5O5ivz+wdmByGm+NNv fgTQ== X-Gm-Message-State: AOAM5309eEjBrCVCiHBFYWhGjWv1AfrXOz5nvbOUP5s6V5C2xBWNwl0F AtpV/pcJM6uvPC5MZuybD0hY86kPAJvhSk4+IrI= X-Google-Smtp-Source: ABdhPJx7YX8zviFjrOEhTKLkYmCq2KlFovtI8luMYDcSxruAN3b9De/JFEEiXwNOCHvtvZ+X9imhz+Hlu9vqUFcQCHI= X-Received: by 2002:a4a:d509:: with SMTP id m9mr3027482oos.77.1601666534935; Fri, 02 Oct 2020 12:22:14 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> In-Reply-To: From: Oded Gabbay Date: Fri, 2 Oct 2020 22:21:47 +0300 Message-ID: Subject: Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames() To: Tomasz Figa Cc: Daniel Vetter , DRI Development , LKML , Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Pawel Osciak , Marek Szyprowski , Andrew Morton , Omer Shpigelman , Tomer Tayar , Greg Kroah-Hartman , Pawel Piskorski , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-samsung-soc , Linux Media Mailing List , linux-mm Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 2, 2020 at 9:23 PM Tomasz Figa wrote: > > On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > > simple dma device that can't guarantee write protection. Which is also > > what all the callers are using. > > > > So just simplify this. > > > > Signed-off-by: Daniel Vetter > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: Kukjin Kim > > Cc: Krzysztof Kozlowski > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Tomasz Figa > > Cc: Andrew Morton > > Cc: Oded Gabbay > > Cc: Omer Shpigelman > > Cc: Tomer Tayar > > Cc: Greg Kroah-Hartman > > Cc: Pawel Piskorski > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-mm@kvack.org > > --- > > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > > drivers/misc/habanalabs/common/memory.c | 3 +-- > > include/linux/mm.h | 2 +- > > mm/frame_vector.c | 4 ++-- > > 5 files changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > index 967a5cdc120e..ac452842bab3 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > > goto err_free; > > } > > > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > > - g2d_userptr->vec); > > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > > if (ret != npages) { > > DRM_DEV_ERROR(g2d->dev, > > "failed to get user pages from userptr.\n"); > > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c b/drivers/media/common/videobuf2/videobuf2-memops.c > > index 6e9e05153f4e..9dd6c27162f4 100644 > > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > unsigned long first, last; > > unsigned long nr; > > struct frame_vector *vec; > > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > > > first = start >> PAGE_SHIFT; > > last = (start + length - 1) >> PAGE_SHIFT; > > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > vec = frame_vector_create(nr); > > if (!vec) > > return ERR_PTR(-ENOMEM); > > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > > if (ret < 0) > > goto out_destroy; > > /* We accept only complete set of PFNs */ > > For drivers/media/common/videobuf2/: > > Acked-by: Tomasz Figa > > Best regards, > Tomasz For drivers/misc/habanalabs: Acked-by: Oded Gabbay Thanks, Oded From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBAFDC4363D for ; Fri, 2 Oct 2020 19:23:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ED7D206DB for ; Fri, 2 Oct 2020 19:23:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uXHn0wYV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyCYGPD3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ED7D206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+ApWiMZ75DxzFN7RlsrjRl1Gzp49NwdKARCe8ww/qjY=; b=uXHn0wYVZRDa37fGwMBm7S5AQ ClvrOcDPGeritIOv/Nr4E5e2/T3oMHm4XNu19GHaoHGqaPmMCHfIGQXgEnq7rYCFXkU18CuLzhPoF C2G/33WXqNdFKoHmGkHHT/zgdyaGoA7s32AUxxdwOKmpQp8k2/dgP/mX1ZC4SyElcYuOIQVkw5yk/ qPpOI4W7IebeqXKhKXdZqQOV72JFkR0A0AJs/t6PssKRbRwy2ZsO09HPfUQG/JfMziQkq9oGo0bkv mGqhZ3rpLGx6Lj4A6w8Tbu6Fy/b+gfTZVMCa+/zuOC67e/m6VqV2jgvW7+fa060IJuV6/UuQYses1 4gwJN/bOA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOQdJ-0008Cp-Bl; Fri, 02 Oct 2020 19:22:21 +0000 Received: from mail-oo1-xc43.google.com ([2607:f8b0:4864:20::c43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOQdG-0008A2-7W for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 19:22:19 +0000 Received: by mail-oo1-xc43.google.com with SMTP id r4so623439ooq.7 for ; Fri, 02 Oct 2020 12:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=pyCYGPD3z231H+FQCXNEMLBtwRoKmxKBpFEKm871TgQU8g0X8z2LzGq3oGkeS5tId6 2OjBG9lDxg08oGQpJZn5YUoFRjrDuVdqQVFb4w+hBOrxNG6DqBJwawSIiKC9egvCjB02 Xw0waBU/U8aGynIrCK89k3Jdpw7z3gEFzB4jasOXhXEyNbxDcZrLX7dRpFGKQoKw1Tws aLL3JDgghZLFX8ZY8jZDZOeRMejsM+55Cdtpn64aGJMuNlg/C9MwjlV2q4dNBpKlf7yk 7CMS1H3Bkbl6Ac+k8YwG1V0D40n/6TqKugG/Uh9B1bMTgFcoERjMQ390o1uoJ6zqs1ZP ObOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=dik7uynMELGEm3oiE/d0otEzl3f1FcAW6dNUVHGqK9sZTBnvIit0h0pcF3hWVMLHlB ULTEmvcAiduaPWDOWPPVWJIiuq9ttRTKXs8RUP4Agna6iCYHctNHk6p3H0R4sE8ruK6X hbXowbx90HvE7AAQGhFP7G8QQNG4EBWItHuRYJjhOgm5YLVG9RxuLULbY5NkuM9y0Oa1 Vyelm0Fptoebg2fUsrLnWK/3qhvclRuOhUMhXxt/yulKS7ZtrKnDkw8JBBHFCcLGmmwn FIKYt+rMBThTm3SavKjUQM75w7CKEaB8eC7SXk+vTrrf35Pj3wQevJ3gx6NoP/xQ4pAQ 48OQ== X-Gm-Message-State: AOAM530Zd0VKSaZIk3JdTYby+z+zDAKTiDZMv1Mvitdc3bQUGpq9P6Je Uu9j4BszxF56JUF0HbyptxOfdDxC255ybk2REJyoiB+WRDuq+Q== X-Google-Smtp-Source: ABdhPJx7YX8zviFjrOEhTKLkYmCq2KlFovtI8luMYDcSxruAN3b9De/JFEEiXwNOCHvtvZ+X9imhz+Hlu9vqUFcQCHI= X-Received: by 2002:a4a:d509:: with SMTP id m9mr3027482oos.77.1601666534935; Fri, 02 Oct 2020 12:22:14 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> In-Reply-To: From: Oded Gabbay Date: Fri, 2 Oct 2020 22:21:47 +0300 Message-ID: Subject: Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames() To: Tomasz Figa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_152218_279129_4AC9D066 X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc , Joonyoung Shim , Pawel Osciak , linux-mm , Pawel Piskorski , Daniel Vetter , Seung-Woo Kim , LKML , DRI Development , Inki Dae , Omer Shpigelman , Kyungmin Park , Kukjin Kim , Tomer Tayar , Krzysztof Kozlowski , Greg Kroah-Hartman , Daniel Vetter , Andrew Morton , Linux Media Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 2, 2020 at 9:23 PM Tomasz Figa wrote: > > On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > > simple dma device that can't guarantee write protection. Which is also > > what all the callers are using. > > > > So just simplify this. > > > > Signed-off-by: Daniel Vetter > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: Kukjin Kim > > Cc: Krzysztof Kozlowski > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Tomasz Figa > > Cc: Andrew Morton > > Cc: Oded Gabbay > > Cc: Omer Shpigelman > > Cc: Tomer Tayar > > Cc: Greg Kroah-Hartman > > Cc: Pawel Piskorski > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-mm@kvack.org > > --- > > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > > drivers/misc/habanalabs/common/memory.c | 3 +-- > > include/linux/mm.h | 2 +- > > mm/frame_vector.c | 4 ++-- > > 5 files changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > index 967a5cdc120e..ac452842bab3 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > > goto err_free; > > } > > > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > > - g2d_userptr->vec); > > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > > if (ret != npages) { > > DRM_DEV_ERROR(g2d->dev, > > "failed to get user pages from userptr.\n"); > > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c b/drivers/media/common/videobuf2/videobuf2-memops.c > > index 6e9e05153f4e..9dd6c27162f4 100644 > > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > unsigned long first, last; > > unsigned long nr; > > struct frame_vector *vec; > > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > > > first = start >> PAGE_SHIFT; > > last = (start + length - 1) >> PAGE_SHIFT; > > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > vec = frame_vector_create(nr); > > if (!vec) > > return ERR_PTR(-ENOMEM); > > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > > if (ret < 0) > > goto out_destroy; > > /* We accept only complete set of PFNs */ > > For drivers/media/common/videobuf2/: > > Acked-by: Tomasz Figa > > Best regards, > Tomasz For drivers/misc/habanalabs: Acked-by: Oded Gabbay Thanks, Oded _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D5E8C4363D for ; Fri, 2 Oct 2020 19:22:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 239B9206DD for ; Fri, 2 Oct 2020 19:22:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyCYGPD3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 239B9206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 471B1896FA; Fri, 2 Oct 2020 19:22:16 +0000 (UTC) Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3FF2896FA for ; Fri, 2 Oct 2020 19:22:15 +0000 (UTC) Received: by mail-oo1-xc43.google.com with SMTP id h8so616882ooc.12 for ; Fri, 02 Oct 2020 12:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=pyCYGPD3z231H+FQCXNEMLBtwRoKmxKBpFEKm871TgQU8g0X8z2LzGq3oGkeS5tId6 2OjBG9lDxg08oGQpJZn5YUoFRjrDuVdqQVFb4w+hBOrxNG6DqBJwawSIiKC9egvCjB02 Xw0waBU/U8aGynIrCK89k3Jdpw7z3gEFzB4jasOXhXEyNbxDcZrLX7dRpFGKQoKw1Tws aLL3JDgghZLFX8ZY8jZDZOeRMejsM+55Cdtpn64aGJMuNlg/C9MwjlV2q4dNBpKlf7yk 7CMS1H3Bkbl6Ac+k8YwG1V0D40n/6TqKugG/Uh9B1bMTgFcoERjMQ390o1uoJ6zqs1ZP ObOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtkiGjkyzPqhHXvj+x4KevVCs1UVs2TLajO5QFK46lc=; b=aH6/tq80MW3MG47Jmd7iDuy5f+P/WK9475k5nlG/4iiYATG3HLoc46ozQI7iy+YYw5 EViTy3Po/MqlLyBXdQRhbJd4xigPFwAnkL47EWCke5T1gHPKFuYIPkkp+2JGlUtfL3pW SWn9+TUjuxuJxNy90ukrWDIe7X1viwq8xEZUvQ9Rq8hB8NAXvxKx6WNPi6gmz/EYpt+f TayUYYYu/8inIHsq+gPFBZA351Tbfvh23rtWF3umDGtl441jG/97blSJr4aa2+leQ0Sd I5SAG64jxOEYcgmOW3oSiq3vLY9yBBFRBGJrmplNUjMfbqzjNpOPzjPb8Qkesn3K+ibK dAZQ== X-Gm-Message-State: AOAM5333LCr/yKWa7nK5VYkyOIcekLiMYHteiHjjfCAfhNH6SMOB8cRC n94pV55Azn4cE+Va/+BIjGoKlMoiYGqPJsyI48I= X-Google-Smtp-Source: ABdhPJx7YX8zviFjrOEhTKLkYmCq2KlFovtI8luMYDcSxruAN3b9De/JFEEiXwNOCHvtvZ+X9imhz+Hlu9vqUFcQCHI= X-Received: by 2002:a4a:d509:: with SMTP id m9mr3027482oos.77.1601666534935; Fri, 02 Oct 2020 12:22:14 -0700 (PDT) MIME-Version: 1.0 References: <20201002175303.390363-1-daniel.vetter@ffwll.ch> In-Reply-To: From: Oded Gabbay Date: Fri, 2 Oct 2020 22:21:47 +0300 Message-ID: Subject: Re: [PATCH 1/2] mm/frame-vec: Drop gup_flags from get_vaddr_frames() To: Tomasz Figa X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc , Joonyoung Shim , Pawel Osciak , linux-mm , Pawel Piskorski , Daniel Vetter , Seung-Woo Kim , LKML , DRI Development , Omer Shpigelman , Kyungmin Park , Kukjin Kim , Tomer Tayar , Krzysztof Kozlowski , Greg Kroah-Hartman , Daniel Vetter , Andrew Morton , Linux Media Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Oct 2, 2020 at 9:23 PM Tomasz Figa wrote: > > On Fri, Oct 2, 2020 at 7:53 PM Daniel Vetter wrote: > > > > FOLL_WRITE | FOLL_FORCE is really the only reasonable thing to do for > > simple dma device that can't guarantee write protection. Which is also > > what all the callers are using. > > > > So just simplify this. > > > > Signed-off-by: Daniel Vetter > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: Kukjin Kim > > Cc: Krzysztof Kozlowski > > Cc: Pawel Osciak > > Cc: Marek Szyprowski > > Cc: Tomasz Figa > > Cc: Andrew Morton > > Cc: Oded Gabbay > > Cc: Omer Shpigelman > > Cc: Tomer Tayar > > Cc: Greg Kroah-Hartman > > Cc: Pawel Piskorski > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-mm@kvack.org > > --- > > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 +-- > > drivers/media/common/videobuf2/videobuf2-memops.c | 3 +-- > > drivers/misc/habanalabs/common/memory.c | 3 +-- > > include/linux/mm.h | 2 +- > > mm/frame_vector.c | 4 ++-- > > 5 files changed, 6 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > index 967a5cdc120e..ac452842bab3 100644 > > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > > @@ -480,8 +480,7 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d, > > goto err_free; > > } > > > > - ret = get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > > - g2d_userptr->vec); > > + ret = get_vaddr_frames(start, npages, g2d_userptr->vec); > > if (ret != npages) { > > DRM_DEV_ERROR(g2d->dev, > > "failed to get user pages from userptr.\n"); > > diff --git a/drivers/media/common/videobuf2/videobuf2-memops.c b/drivers/media/common/videobuf2/videobuf2-memops.c > > index 6e9e05153f4e..9dd6c27162f4 100644 > > --- a/drivers/media/common/videobuf2/videobuf2-memops.c > > +++ b/drivers/media/common/videobuf2/videobuf2-memops.c > > @@ -40,7 +40,6 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > unsigned long first, last; > > unsigned long nr; > > struct frame_vector *vec; > > - unsigned int flags = FOLL_FORCE | FOLL_WRITE; > > > > first = start >> PAGE_SHIFT; > > last = (start + length - 1) >> PAGE_SHIFT; > > @@ -48,7 +47,7 @@ struct frame_vector *vb2_create_framevec(unsigned long start, > > vec = frame_vector_create(nr); > > if (!vec) > > return ERR_PTR(-ENOMEM); > > - ret = get_vaddr_frames(start & PAGE_MASK, nr, flags, vec); > > + ret = get_vaddr_frames(start & PAGE_MASK, nr, vec); > > if (ret < 0) > > goto out_destroy; > > /* We accept only complete set of PFNs */ > > For drivers/media/common/videobuf2/: > > Acked-by: Tomasz Figa > > Best regards, > Tomasz For drivers/misc/habanalabs: Acked-by: Oded Gabbay Thanks, Oded _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel