From: Oded Gabbay <oded.gabbay@gmail.com>
To: "Bridgman, John" <John.Bridgman@amd.com>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] hsakmt: allow building with gcc 4.x v2
Date: Sun, 17 Apr 2016 15:43:11 +0300 [thread overview]
Message-ID: <CAFCwf13Gf70ucLk491GLht8VnBeGgOBvAo-dL6fuQ0GwpMWXxQ@mail.gmail.com> (raw)
In-Reply-To: <DM3PR12MB09054DBB0C97739792EB9AB0E8870@DM3PR12MB0905.namprd12.prod.outlook.com>
On Wed, Mar 30, 2016 at 2:12 AM, Bridgman, John <John.Bridgman@amd.com> wrote:
> The hsakmt code requires C99 compiler support, however gcc 4.x
> defaults to C89 (gcc 5 defaults to C11). v2 patch copies code
> from libdrm, using AC_PROG_CC_C99 and checking success.
>
> v1 used AC_PROG_CC_STDC and did not check C99 was enabled.
>
> Signed-off-by: John Bridgman <john.bridgman@amd.com>
> ---
> configure.ac | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index b8e9bea..0111067 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -66,6 +66,12 @@ AC_CANONICAL_HOST
> AC_PROG_AWK
> test_CFLAGS=${CFLAGS+set} # We may override autoconf default CFLAGS.
> AC_PROG_CC
> +AC_PROG_CC_C99
> +
> +if test "x$ac_cv_prog_cc_c99" = xno; then
> + AC_MSG_ERROR([Building hsakmt requires C99 enabled compiler])
> +fi
> +
> AC_PROG_INSTALL
> AC_PROG_LIBTOOL
> AC_PROG_MAKE_SET
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks John,
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Can you push it to the repo ?
If you get permission error, we need to set-up permissions.
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-04-17 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 23:12 [PATCH] hsakmt: allow building with gcc 4.x v2 Bridgman, John
2016-04-17 12:43 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFCwf13Gf70ucLk491GLht8VnBeGgOBvAo-dL6fuQ0GwpMWXxQ@mail.gmail.com \
--to=oded.gabbay@gmail.com \
--cc=John.Bridgman@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.